Roles and Groups Handlers Support Project Scope (#154)
* Adding project level scopes for groups and roles. * Adding tests to verify the routes are working as expected.
This commit is contained in:
1 parent
3e3144117e
commit
8399764442
13 files changed
+3193
-389
No files matched your search
@@ -2,17 +2,127 @@ package controller
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"fmt"
|
||||
"io/ioutil"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
"github.com/grpc-ecosystem/grpc-gateway/runtime"
|
||||
"github.com/hashicorp/watchtower/internal/gen/controller/api/services"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestGrpcGatewayRouting(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
// The unimplemented result indicates the grpc routing is happening successfully otherwise it would return NotFound.
|
||||
routed := http.StatusNotImplemented
|
||||
unrouted := http.StatusNotFound
|
||||
|
||||
cases := []struct {
|
||||
name string
|
||||
setup func(mux *runtime.ServeMux)
|
||||
url string
|
||||
expectedResult int
|
||||
}{
|
||||
{
|
||||
name: "project",
|
||||
setup: func(mux *runtime.ServeMux) {
|
||||
require.NoError(t, services.RegisterProjectServiceHandlerServer(ctx, mux, &services.UnimplementedProjectServiceServer{}))
|
||||
},
|
||||
url: "v1/orgs/someid/projects",
|
||||
expectedResult: routed,
|
||||
},
|
||||
{
|
||||
name: "users",
|
||||
setup: func(mux *runtime.ServeMux) {
|
||||
require.NoError(t, services.RegisterUserServiceHandlerServer(ctx, mux, &services.UnimplementedUserServiceServer{}))
|
||||
},
|
||||
url: "v1/orgs/someid/users",
|
||||
expectedResult: routed,
|
||||
},
|
||||
{
|
||||
name: "roles",
|
||||
setup: func(mux *runtime.ServeMux) {
|
||||
require.NoError(t, services.RegisterRoleServiceHandlerServer(ctx, mux, &services.UnimplementedRoleServiceServer{}))
|
||||
},
|
||||
url: "v1/orgs/someid/roles",
|
||||
expectedResult: routed,
|
||||
},
|
||||
{
|
||||
name: "project_scoped_roles",
|
||||
setup: func(mux *runtime.ServeMux) {
|
||||
require.NoError(t, services.RegisterRoleServiceHandlerServer(ctx, mux, &services.UnimplementedRoleServiceServer{}))
|
||||
},
|
||||
url: "v1/orgs/someid/projects/_someprojectid/roles",
|
||||
expectedResult: routed,
|
||||
},
|
||||
{
|
||||
name: "groups",
|
||||
setup: func(mux *runtime.ServeMux) {
|
||||
require.NoError(t, services.RegisterGroupServiceHandlerServer(ctx, mux, &services.UnimplementedGroupServiceServer{}))
|
||||
},
|
||||
url: "v1/orgs/someid/groups",
|
||||
expectedResult: routed,
|
||||
},
|
||||
{
|
||||
name: "project_scoped_groups",
|
||||
setup: func(mux *runtime.ServeMux) {
|
||||
require.NoError(t, services.RegisterGroupServiceHandlerServer(ctx, mux, &services.UnimplementedGroupServiceServer{}))
|
||||
},
|
||||
url: "v1/orgs/someid/projects/_someprojectid/groups",
|
||||
expectedResult: routed,
|
||||
},
|
||||
{
|
||||
name: "not routed",
|
||||
setup: func(mux *runtime.ServeMux) {},
|
||||
url: "v1/nothing",
|
||||
expectedResult: unrouted,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
mux := runtime.NewServeMux()
|
||||
tc.setup(mux)
|
||||
|
||||
// List request
|
||||
req := httptest.NewRequest("GET", fmt.Sprintf("http://localhost/%s", tc.url), nil)
|
||||
resp := httptest.NewRecorder()
|
||||
mux.ServeHTTP(resp, req)
|
||||
assert.Equal(t, tc.expectedResult, resp.Result().StatusCode, "Got response %v", resp)
|
||||
|
||||
// Create request
|
||||
req = httptest.NewRequest("POST", fmt.Sprintf("http://localhost/%s", tc.url), nil)
|
||||
resp = httptest.NewRecorder()
|
||||
mux.ServeHTTP(resp, req)
|
||||
assert.Equal(t, tc.expectedResult, resp.Result().StatusCode, "Got response %v", resp)
|
||||
|
||||
// Get request
|
||||
req = httptest.NewRequest("GET", fmt.Sprintf("http://localhost/%s/somemadeupid", tc.url), nil)
|
||||
resp = httptest.NewRecorder()
|
||||
mux.ServeHTTP(resp, req)
|
||||
assert.Equal(t, tc.expectedResult, resp.Result().StatusCode, "Got response %v", resp)
|
||||
|
||||
// Update request
|
||||
req = httptest.NewRequest("PATCH", fmt.Sprintf("http://localhost/%s/somemadeupid", tc.url), nil)
|
||||
resp = httptest.NewRecorder()
|
||||
mux.ServeHTTP(resp, req)
|
||||
assert.Equal(t, tc.expectedResult, resp.Result().StatusCode, "Got response %v", resp)
|
||||
|
||||
// Delete request
|
||||
req = httptest.NewRequest("DELETE", fmt.Sprintf("http://localhost/%s/somemadeupid", tc.url), nil)
|
||||
resp = httptest.NewRecorder()
|
||||
mux.ServeHTTP(resp, req)
|
||||
assert.Equal(t, tc.expectedResult, resp.Result().StatusCode, "Got response %v", resp)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleGrpcGateway(t *testing.T) {
|
||||
c := NewTestController(t, nil)
|
||||
defer c.Shutdown()
|
||||
@@ -43,6 +153,7 @@ func TestHandleGrpcGateway(t *testing.T) {
|
||||
if got, want := resp.StatusCode, tc.code; got != want {
|
||||
t.Errorf("GET on %q got code %d, wanted %d", tc.path, got, want)
|
||||
}
|
||||
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user