From 9f01e1b3c10110a6eaf2829b70004fe478180f31 Mon Sep 17 00:00:00 2001 From: Jim Date: Mon, 3 Apr 2023 13:53:12 -0400 Subject: [PATCH] refact: RegisterUpstreamMessageHandler stop returning dup err Stop returning an error if RegisterUpstreamMessageHandler is called multiple times, since it provides little/no value and creates invalid errors when more than one test controller is started across all the unit tests. --- .../cluster/handlers/upstream_message_service_controller.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/internal/daemon/cluster/handlers/upstream_message_service_controller.go b/internal/daemon/cluster/handlers/upstream_message_service_controller.go index 545587c9a..7ea41fcaa 100644 --- a/internal/daemon/cluster/handlers/upstream_message_service_controller.go +++ b/internal/daemon/cluster/handlers/upstream_message_service_controller.go @@ -55,10 +55,7 @@ func RegisterUpstreamMessageHandler(ctx context.Context, msgType pbs.MsgType, h case util.IsNil(h): return errors.New(ctx, errors.InvalidParameter, op, "missing handler") } - if _, loaded := upstreamMessageHandler.LoadOrStore(msgType, h); loaded { - return errors.New(ctx, errors.InvalidParameter, op, "handler already registered for msg type") - } - + upstreamMessageHandler.Store(msgType, h) return nil }