Some test fixes (#5084)

* internal/session: update variable name in test

This was missed in #5071

* internal/tests/cluster: skip failing tests

These tests will need to be fixed or removed. It is not
clear why they are failing, but they are always failing.

* Makefile: try upgrading golangci-lint

* internal/host/plugin: fix flaky test

Hosts contain IP addresses in string form, whose
order is not defined.
This commit is contained in:
Johan Brandhorst-Satzkorn authored and GitHub committed 2024-09-09 09:22:34 -07:00
1 parent d45aa402d8
commit a830892fec
4 files changed
+21 -2

No files matched your search

@@ -221,6 +221,9 @@ func TestJob_UpsertHosts(t *testing.T) {
cmpopts.SortSlices(func(x, y *Host) bool {
return x.GetPublicId() < y.GetPublicId()
}),
cmpopts.SortSlices(func(x, y string) bool {
return x < y
}),
),
)
@@ -242,6 +245,9 @@ func TestJob_UpsertHosts(t *testing.T) {
cmpopts.SortSlices(func(x, y *Host) bool {
return x.GetPublicId() < y.GetPublicId()
}),
cmpopts.SortSlices(func(x, y string) bool {
return x < y
}),
),
)
plg := plg
@@ -274,6 +280,9 @@ func TestJob_UpsertHosts(t *testing.T) {
got,
cmpopts.IgnoreUnexported(Host{}, store.Host{}),
cmpopts.IgnoreTypes(&timestamp.Timestamp{}),
cmpopts.SortSlices(func(x, y string) bool {
return x < y
}),
),
)
assert.Empty(