Move update versioning to query parameter, and fix up scope API tests (#244)

* Move update versioning to query parameter, and fix up scope API tests

* Add version checks for update requests in other services

internal/cmd/commands/scopes/create.go

@@ -86,6 +86,7 @@ func (c *CreateScopeCommand) Run(args []string) int {
 	}
 
 	scp, apiErr, err := scopes.NewScopesClient(client).Create(c.Context,
+		client.ScopeId(),
 		scopes.WithName(c.flagName),
 		scopes.WithDescription(c.flagDescription))
 

internal/servers/controller/handlers/groups/group_service.go

@@ -409,6 +409,9 @@ func validateUpdateRequest(req *pbs.UpdateGroupRequest) error {
 	if req.GetUpdateMask() == nil {
 		badFields["update_mask"] = "UpdateMask not provided but is required to update a group."
 	}
+	if req.GetVersion() == 0 {
+		badFields["version"] = "Existing resource version is required for an update."
+	}
 
 	item := req.GetItem()
 	if item == nil {

internal/servers/controller/handlers/roles/role_service.go

@@ -574,6 +574,9 @@ func validateUpdateRequest(req *pbs.UpdateRoleRequest, scope *scopes.ScopeInfo)
 	if req.GetUpdateMask() == nil {
 		badFields["update_mask"] = "UpdateMask not provided but is required to update a role."
 	}
+	if req.GetVersion() == 0 {
+		badFields["version"] = "Existing resource version is required for an update."
+	}
 
 	item := req.GetItem()
 	if item == nil {

internal/servers/controller/handlers/scopes/scope_service.go

@@ -364,6 +364,9 @@ func validateUpdateRequest(req *pbs.UpdateScopeRequest) error {
 	if req.GetUpdateMask() == nil {
 		badFields["update_mask"] = "UpdateMask not provided but is required to update a project."
 	}
+	if req.GetVersion() == 0 {
+		badFields["version"] = "Existing resource version is required for an update."
+	}
 
 	item := req.GetItem()
 	if item == nil {

internal/servers/controller/handlers/users/user_service.go

@@ -296,6 +296,9 @@ func validateUpdateRequest(req *pbs.UpdateUserRequest) error {
 	if req.GetUpdateMask() == nil {
 		badFields["update_mask"] = "UpdateMask not provided but is required to update a user."
 	}
+	if req.GetVersion() == 0 {
+		badFields["version"] = "Existing resource version is required for an update."
+	}
 
 	item := req.GetItem()
 	if item == nil {