Placeholder Plugin Providers for Repos and added testPlugin struct (#1532)

* Create minimalistic plugin map and test plugin.

* Pass secrets and attributes to the plugin when creating catalogs or sets.  Add tests for CreateSet and CreateCatalog repo methods.

* make fmt and extract out getPrivateCatalog and getCatalog helper methods.

* Exporting TestPluginServer so it can be used in the handlers.

* Keep separate persisted data from host catalogs lookups which facilitate passing it onto the plugins.

* Add TODO to merge get Catalog and get Persisted data.

* Adding tests for unimplemented being returned by the plugin.

* Use GetFields() instead of AsMap() to confirm attributes should be populated. Make clone consistent between catalog and sets.

Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>
This commit is contained in:
ToddandJeff Mitchell authored and GitHub committed 2021-09-21 09:18:49 -07:00
1 parent ea939a4445
commit bbfef2802f
30 files changed
+669 -227

No files matched your search

+9 -8
View File
@@ -2,7 +2,6 @@ package plugin
import (
"context"
"encoding/json"
"testing"
"github.com/google/go-cmp/cmp"
@@ -13,7 +12,9 @@ import (
"github.com/hashicorp/boundary/internal/plugin/host"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/testing/protocmp"
"google.golang.org/protobuf/types/known/structpb"
)
func TestHostCatalog_Create(t *testing.T) {
@@ -45,7 +46,7 @@ func TestHostCatalog_Create(t *testing.T) {
want: &HostCatalog{
HostCatalog: &store.HostCatalog{
PluginId: plg.GetPublicId(),
Attributes: []byte("{}"),
Attributes: []byte{},
},
},
wantCreateErr: true,
@@ -59,7 +60,7 @@ func TestHostCatalog_Create(t *testing.T) {
want: &HostCatalog{
HostCatalog: &store.HostCatalog{
ScopeId: prj.GetPublicId(),
Attributes: []byte("{}"),
Attributes: []byte{},
},
},
wantCreateErr: true,
@@ -74,7 +75,7 @@ func TestHostCatalog_Create(t *testing.T) {
HostCatalog: &store.HostCatalog{
PluginId: plg.GetPublicId(),
ScopeId: prj.GetPublicId(),
Attributes: []byte("{}"),
Attributes: []byte{},
},
},
},
@@ -92,7 +93,7 @@ func TestHostCatalog_Create(t *testing.T) {
PluginId: plg.GetPublicId(),
ScopeId: prj.GetPublicId(),
Name: "test-name",
Attributes: []byte("{}"),
Attributes: []byte{},
},
},
},
@@ -110,7 +111,7 @@ func TestHostCatalog_Create(t *testing.T) {
PluginId: plg.GetPublicId(),
ScopeId: prj.GetPublicId(),
Description: "test-description",
Attributes: []byte("{}"),
Attributes: []byte{},
},
},
},
@@ -120,7 +121,7 @@ func TestHostCatalog_Create(t *testing.T) {
pluginId: plg.GetPublicId(),
scopeId: prj.GetPublicId(),
opts: []Option{
WithAttributes(map[string]interface{}{"foo": "bar"}),
WithAttributes(&structpb.Struct{Fields: map[string]*structpb.Value{"foo": structpb.NewStringValue("bar")}}),
},
},
want: func() *HostCatalog {
@@ -131,7 +132,7 @@ func TestHostCatalog_Create(t *testing.T) {
},
}
var err error
hc.Attributes, err = json.Marshal(map[string]interface{}{"foo": "bar"})
hc.Attributes, err = proto.Marshal(&structpb.Struct{Fields: map[string]*structpb.Value{"foo": structpb.NewStringValue("bar")}})
require.NoError(t, err)
return hc
}(),