Placeholder Plugin Providers for Repos and added testPlugin struct (#1532)

* Create minimalistic plugin map and test plugin.

* Pass secrets and attributes to the plugin when creating catalogs or sets.  Add tests for CreateSet and CreateCatalog repo methods.

* make fmt and extract out getPrivateCatalog and getCatalog helper methods.

* Exporting TestPluginServer so it can be used in the handlers.

* Keep separate persisted data from host catalogs lookups which facilitate passing it onto the plugins.

* Add TODO to merge get Catalog and get Persisted data.

* Adding tests for unimplemented being returned by the plugin.

* Use GetFields() instead of AsMap() to confirm attributes should be populated. Make clone consistent between catalog and sets.

Co-authored-by: Jeff Mitchell <jeffrey.mitchell@gmail.com>

internal/host/plugin/repository_test.go

@@ -3,6 +3,7 @@ package plugin
 import (
 	"testing"
 
+	plgpb "github.com/hashicorp/boundary/sdk/pbs/plugin"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
@@ -18,11 +19,14 @@ func TestRepository_New(t *testing.T) {
 	wrapper := db.TestWrapper(t)
 	kmsCache := kms.TestKms(t, conn, wrapper)
 
+	plgs := map[string]plgpb.HostPluginServiceServer{}
+
 	type args struct {
-		r    db.Reader
-		w    db.Writer
-		kms  *kms.Kms
-		opts []host.Option
+		r       db.Reader
+		w       db.Writer
+		kms     *kms.Kms
+		plugins map[string]plgpb.HostPluginServiceServer
+		opts    []host.Option
 	}
 
 	tests := []struct {
@@ -34,38 +38,43 @@ func TestRepository_New(t *testing.T) {
 		{
 			name: "valid",
 			args: args{
-				r:   rw,
-				w:   rw,
-				kms: kmsCache,
+				r:       rw,
+				w:       rw,
+				kms:     kmsCache,
+				plugins: plgs,
 			},
 			want: &Repository{
 				reader:       rw,
 				writer:       rw,
 				kms:          kmsCache,
+				plugins:      plgs,
 				defaultLimit: db.DefaultLimit,
 			},
 		},
 		{
 			name: "valid-with-limit",
 			args: args{
-				r:    rw,
-				w:    rw,
-				kms:  kmsCache,
-				opts: []host.Option{host.WithLimit(5)},
+				r:       rw,
+				w:       rw,
+				kms:     kmsCache,
+				plugins: plgs,
+				opts:    []host.Option{host.WithLimit(5)},
 			},
 			want: &Repository{
 				reader:       rw,
 				writer:       rw,
 				kms:          kmsCache,
+				plugins:      plgs,
 				defaultLimit: 5,
 			},
 		},
 		{
 			name: "nil-reader",
 			args: args{
-				r:   nil,
-				w:   rw,
-				kms: kmsCache,
+				r:       nil,
+				w:       rw,
+				kms:     kmsCache,
+				plugins: plgs,
 			},
 			want:      nil,
 			wantIsErr: errors.InvalidParameter,
@@ -73,9 +82,10 @@ func TestRepository_New(t *testing.T) {
 		{
 			name: "nil-writer",
 			args: args{
-				r:   rw,
-				w:   nil,
-				kms: kmsCache,
+				r:       rw,
+				w:       nil,
+				kms:     kmsCache,
+				plugins: plgs,
 			},
 			want:      nil,
 			wantIsErr: errors.InvalidParameter,
@@ -83,9 +93,21 @@ func TestRepository_New(t *testing.T) {
 		{
 			name: "nil-kms",
 			args: args{
-				r:   rw,
-				w:   rw,
-				kms: nil,
+				r:       rw,
+				w:       rw,
+				kms:     nil,
+				plugins: plgs,
+			},
+			want:      nil,
+			wantIsErr: errors.InvalidParameter,
+		},
+		{
+			name: "nil-plugins",
+			args: args{
+				r:       rw,
+				w:       rw,
+				kms:     kmsCache,
+				plugins: nil,
 			},
 			want:      nil,
 			wantIsErr: errors.InvalidParameter,
@@ -93,9 +115,10 @@ func TestRepository_New(t *testing.T) {
 		{
 			name: "all-nils",
 			args: args{
-				r:   nil,
-				w:   nil,
-				kms: nil,
+				r:       nil,
+				w:       nil,
+				kms:     nil,
+				plugins: nil,
 			},
 			want:      nil,
 			wantIsErr: errors.InvalidParameter,
@@ -105,7 +128,7 @@ func TestRepository_New(t *testing.T) {
 		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			assert, require := assert.New(t), require.New(t)
-			got, err := NewRepository(tt.args.r, tt.args.w, tt.args.kms, tt.args.opts...)
+			got, err := NewRepository(tt.args.r, tt.args.w, tt.args.kms, tt.args.plugins, tt.args.opts...)
 			if tt.wantIsErr != 0 {
 				assert.Truef(errors.Match(errors.T(tt.wantIsErr), err), "want err: %q got: %q", tt.wantIsErr, err)
 				assert.Nil(got)