ICU-738/Refactor internal/db to domain errors (#815)

* Refactor internal/db to domain errors
This commit is contained in:
Louis Ruch authored and GitHub committed 2020-12-21 10:07:34 -08:00
1 parent b5d84495a3
commit bfbb179741
82 files changed
+742 -640

No files matched your search

+11 -4
View File
@@ -117,8 +117,10 @@ func Convert(e error) *Err {
if e == nil {
return nil
}
var err *Err
if As(e, &err) {
// TODO instead of casting the error here, we should do an As.
// Currently doing an As loses any additional context added by non-refactored packages
// that are still wrapping with stdlib
if err, ok := e.(*Err); ok {
return err
}
var pqError *pq.Error
@@ -126,7 +128,7 @@ func Convert(e error) *Err {
if pqError.Code.Class() == "23" { // class of integrity constraint violations
switch pqError.Code {
case "23505": // unique_violation
return E(WithMsg(pqError.Detail), WithWrap(ErrNotUnique)).(*Err)
return E(WithMsg(pqError.Message), WithWrap(ErrNotUnique)).(*Err)
case "23502": // not_null_violation
msg := fmt.Sprintf("%s must not be empty", pqError.Column)
return E(WithMsg(msg), WithWrap(ErrNotNull)).(*Err)
@@ -137,8 +139,13 @@ func Convert(e error) *Err {
return E(WithCode(NotSpecificIntegrity), WithMsg(pqError.Message)).(*Err)
}
}
if pqError.Code == "42P01" {
switch pqError.Code {
case "42P01":
return E(WithCode(MissingTable), WithMsg(pqError.Message)).(*Err)
case "42703":
return E(WithCode(ColumnNotFound), WithMsg(pqError.Message)).(*Err)
case "P0001":
return E(WithCode(Exception), WithMsg(pqError.Message)).(*Err)
}
}
// unfortunately, we can't help.