From cac944d94841335e9d7c79f7709ad44530374ede Mon Sep 17 00:00:00 2001 From: Irena Rindos Date: Thu, 7 Aug 2025 08:35:13 -0400 Subject: [PATCH] chore(rdp): fix command text and cred conversion (#1656) --- internal/cmd/commands/targetscmd/rdp_funcs.go | 2 +- .../daemon/controller/handlers/targets/credentials.go | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/internal/cmd/commands/targetscmd/rdp_funcs.go b/internal/cmd/commands/targetscmd/rdp_funcs.go index 0efba3753..b0073e641 100644 --- a/internal/cmd/commands/targetscmd/rdp_funcs.go +++ b/internal/cmd/commands/targetscmd/rdp_funcs.go @@ -89,7 +89,7 @@ func extraRdpFlagsFuncImpl(c *RdpCommand, set *base.FlagSets, f *base.FlagSet) { fs.StringVar(&base.StringVar{ Name: "default-port", Target: &c.flagDefaultPort, - Usage: "Optionally, the default port to set on the target. If not specified, it will be set to 22.", + Usage: "Optionally, the default port to set on the target. If not specified, it will be set to 3389.", }) case "default-client-port": fs.StringVar(&base.StringVar{ diff --git a/internal/daemon/controller/handlers/targets/credentials.go b/internal/daemon/controller/handlers/targets/credentials.go index 2fc4c539d..82279a944 100644 --- a/internal/daemon/controller/handlers/targets/credentials.go +++ b/internal/daemon/controller/handlers/targets/credentials.go @@ -178,6 +178,17 @@ func staticToWorkerCredential(ctx context.Context, cred credential.Static) (sess }, } + case *credstatic.UsernamePasswordDomainCredential: + workerCred = &serverpb.Credential{ + Credential: &serverpb.Credential_UsernamePasswordDomain{ + UsernamePasswordDomain: &serverpb.UsernamePasswordDomain{ + Username: c.GetUsername(), + Password: string(c.GetPassword()), + Domain: c.GetDomain(), + }, + }, + } + case *credstatic.SshPrivateKeyCredential: workerCred = &serverpb.Credential{ Credential: &serverpb.Credential_SshPrivateKey{