Handler hostcatalogs sdk (#103)

* Created host catalog service.

* Fixing uri generation for create.

* Use newly submitted static host catalog.

* Copying over tests from projects.

* Fix UpdateHostCatalogRequest merging proto.

* Properly use static host catalog prefixes in tests.

* Correct test to verify the expected uri and id prefix is set.

* Add test for unsetting descriptions.

* Correct bad spelling in comment.

* Tweaking variable names.

* Adding Stringer to the catalog type and setting the type on the response.

* Setting up the catalogType to contain more info regarding its type.

* Validate the type field in requests.

* Remove unused method.

* Comment describing invariants around types.

* Wiring in the repo into the static catalog handler.

* feature:  Add CRUD operations for host catalogs to the go api library.

* Updated comments to the exported methods.

* fix: return the result of handlers.NotFoundError instead of just calling it.

* Fixing typos referencing just hosts instead of host catlogs.

* Update NewService returns an error and a non pointer type.

* Pull "org_id" and "project_id" into constants and the validation of them into the ValidateAncestors.

* Check errors for all Register*HandlerServer calls.

* fix: Remove left over reference that could cause a panic.

* fix: Changing "x := []string{}" to "var x []string"

* fix: Log errors in test cleanup.

* Changing the code to use google.golang.org/protobuf instead of the older github based protobuf library.

* Changing all t.Fatal checks to require.NoError calls.

* Changing unrecognized prefixes to Invalid Argument instead of Not Found.

* fix: toDbUpdateMask now returns error if it was unable to find any valid paths.

* Define CreatedTime, UpdatedTime, and Type at initialization time in toProto.

* Adding sdk test for unsetting a value.

* Require that project is created correctly before testing the catalog.

* Remove unused host catalog from test.

* Change a t.Fatal to a require.NoError that I missed earlier.

* Change shutdown error logging to t.Errorfs.

* Shorten validateX function names.

* Inline API responses.

* Add todo to make a new repo per request.

* Inline regex check for invalid id.

* Change stored repos into repo creating functions which satisfies ICU-223.

* Wrap proto comments to be under 80 characters long.

* Remove the exception on the read only fields that can be set in an Update request.

* Removing out of date comment.

* Use iam.TestScopes instead of making the project myself.

* Renaming files to be consistant with go test standards and resource naming standards.

* Remove TODO related to a task completed in an earlier commit.

* Fix the previous commit which removed the wrong TODO.
This commit is contained in:
Todd Knight authored and GitHub committed 2020-06-05 13:02:58 -07:00
1 parent 7f6e78e66e
commit d374ac6d4c
11 files changed
+413 -111

No files matched your search

+24 -19
View File
@@ -18,21 +18,26 @@ type createInfo struct {
var createFuncs = map[string][]*createInfo{
"hosts": {
{
"HostCatalog",
"Host",
`fmt.Sprintf("host-catalogs/%s/hosts", s.Id)`,
baseType: "HostCatalog",
targetType: "Host",
path: `fmt.Sprintf("host-catalogs/%s/hosts", s.Id)`,
},
{
"HostCatalog",
"HostSet",
`fmt.Sprintf("host-catalogs/%s/host-sets", s.Id)`,
baseType: "HostCatalog",
targetType: "HostSet",
path: `fmt.Sprintf("host-catalogs/%s/host-sets", s.Id)`,
},
},
"scopes": {
{
"Organization",
"Project",
`"projects"`,
baseType: "Organization",
targetType: "Project",
path: `"projects"`,
},
{
baseType: "Project",
targetType: "hosts.HostCatalog",
path: `"host-catalogs"`,
},
},
}
@@ -46,15 +51,15 @@ package %s
`, outPkg)))
for _, createInfo := range funcs {
createFuncTemplate.Execute(outBuf, struct {
BaseType string
TargetType string
LowerTargetType string
Path string
BaseType string
TargetType string
TargetName string
Path string
}{
BaseType: createInfo.baseType,
TargetType: createInfo.targetType,
LowerTargetType: strings.ToLower(createInfo.targetType),
Path: createInfo.path,
BaseType: createInfo.baseType,
TargetType: createInfo.targetType,
TargetName: strings.Split(createInfo.targetType, ".")[strings.Count(createInfo.targetType, ".")],
Path: createInfo.path,
})
}
if err := ioutil.WriteFile(outFile, outBuf.Bytes(), 0644); err != nil {
@@ -66,7 +71,7 @@ package %s
var createFuncTemplate = template.Must(template.New("").Parse(
`
func (s {{ .BaseType }}) Create{{ .TargetType }}(ctx context.Context, {{ .LowerTargetType }} *{{ .TargetType }}) (*{{ .TargetType }}, *api.Error, error) {
func (s {{ .BaseType }}) Create{{ .TargetName }}(ctx context.Context, r *{{ .TargetType }}) (*{{ .TargetType }}, *api.Error, error) {
if s.Client == nil {
return nil, nil, fmt.Errorf("nil client in Create{{ .TargetType }} request")
}
@@ -90,7 +95,7 @@ func (s {{ .BaseType }}) Create{{ .TargetType }}(ctx context.Context, {{ .LowerT
{{ end }}
}
req, err := s.Client.NewRequest(ctx, "POST", {{ .Path }}, {{ .LowerTargetType }})
req, err := s.Client.NewRequest(ctx, "POST", {{ .Path }}, r)
if err != nil {
return nil, nil, fmt.Errorf("error creating Create{{ .TargetType }} request: %w", err)
}