feat(session): Include session recording id in auth-session resp (#4593)
This commit is contained in:
1 parent
446b790f02
commit
e9e3d7cad5
5 files changed
+53
-31
No files matched your search
@@ -99,11 +99,11 @@ var (
|
||||
action.List,
|
||||
)
|
||||
|
||||
validateCredentialSourcesFn = func(context.Context, globals.Subtype, []target.CredentialSource) error { return nil }
|
||||
ValidateIngressWorkerFilterFn = IngressWorkerFilterUnsupported
|
||||
AuthorizeSessionWorkerFilterFn = AuthorizeSessionWithWorkerFilter
|
||||
PostSessionAuthorizationCallback = DefaultPostSessionAuthorizationCallback
|
||||
WorkerFilterDeprecationMessage = fmt.Sprintf("This field is deprecated. Use %s instead.", globals.EgressWorkerFilterField)
|
||||
validateCredentialSourcesFn = func(context.Context, globals.Subtype, []target.CredentialSource) error { return nil }
|
||||
ValidateIngressWorkerFilterFn = IngressWorkerFilterUnsupported
|
||||
AuthorizeSessionWorkerFilterFn = AuthorizeSessionWithWorkerFilter
|
||||
SessionRecordingFn = NoSessionRecording
|
||||
WorkerFilterDeprecationMessage = fmt.Sprintf("This field is deprecated. Use %s instead.", globals.EgressWorkerFilterField)
|
||||
)
|
||||
|
||||
func init() {
|
||||
@@ -784,8 +784,8 @@ func AuthorizeSessionWithWorkerFilter(
|
||||
return selectedWorkers, nil, nil
|
||||
}
|
||||
|
||||
func DefaultPostSessionAuthorizationCallback(context.Context, intglobals.ControllerExtension, *kms.Kms, *target.Repository, target.Target, *session.Session, *server.Worker) error {
|
||||
return nil
|
||||
func NoSessionRecording(context.Context, intglobals.ControllerExtension, *kms.Kms, target.Target, *session.Session, *server.Worker) (string, error) {
|
||||
return "", nil
|
||||
}
|
||||
|
||||
func (s Service) AuthorizeSession(ctx context.Context, req *pbs.AuthorizeSessionRequest) (_ *pbs.AuthorizeSessionResponse, retErr error) {
|
||||
@@ -1217,15 +1217,15 @@ func (s Service) AuthorizeSession(ctx context.Context, req *pbs.AuthorizeSession
|
||||
Credentials: creds,
|
||||
}
|
||||
|
||||
if err := PostSessionAuthorizationCallback(
|
||||
ret.SessionRecordingId, err = SessionRecordingFn(
|
||||
ctx,
|
||||
s.controllerExt,
|
||||
s.kmsCache,
|
||||
repo,
|
||||
t,
|
||||
sess,
|
||||
protoWorker,
|
||||
); err != nil {
|
||||
)
|
||||
if err != nil {
|
||||
// Errors here will automatically delete the session and associated resources
|
||||
// using deferred statements above.
|
||||
return nil, errors.Wrap(ctx, err, op)
|
||||
|
||||
Reference in new issue
Block a user