Update API codes (#336)

api/hostsets/host_set.gen.go

@@ -5,6 +5,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"net/http"
 	"net/url"
 	"time"
 
@@ -213,18 +214,19 @@ func (c *Client) Delete(ctx context.Context, hostSetId string, opt ...Option) (b
 		return false, nil, fmt.Errorf("error performing client request during Delete call: %w", err)
 	}
 
-	type deleteResponse struct {
-		Existed bool
-	}
-	target := &deleteResponse{}
-	apiErr, err := resp.Decode(target)
+	apiErr, err := resp.Decode(nil)
 	if err != nil {
 		return false, nil, fmt.Errorf("error decoding Delete response: %w", err)
 	}
 	if apiErr != nil {
+		// We don't treat a 404 in this case as failure, in order for deletes to
+		// be idempotent
+		if apiErr.Status == http.StatusNotFound {
+			return false, nil, nil
+		}
 		return false, apiErr, nil
 	}
-	return target.Existed, apiErr, nil
+	return true, nil, nil
 }
 
 func (c *Client) List(ctx context.Context, hostCatalogId string, opt ...Option) ([]*HostSet, *api.Error, error) {

api/hostsets/host_set_test.go

@@ -175,8 +175,8 @@ func TestCrud(t *testing.T) {
 	assert.True(existed, "Expected existing catalog when deleted, but it wasn't.")
 	existed, apiErr, err = hClient.Delete(tc.Context(), h.Id)
 	require.NoError(err)
-	assert.NotNil(apiErr)
-	assert.EqualValues(http.StatusForbidden, apiErr.Status)
+	assert.Nil(apiErr)
+	assert.False(existed)
 }
 
 // TODO: Get better coverage for expected errors and error formats.
@@ -211,7 +211,7 @@ func TestErrors(t *testing.T) {
 	_, apiErr, err = hClient.Read(tc.Context(), static.HostSetPrefix+"_doesntexis")
 	require.NoError(err)
 	assert.NotNil(apiErr)
-	assert.EqualValues(http.StatusForbidden, apiErr.Status)
+	assert.EqualValues(http.StatusNotFound, apiErr.Status)
 
 	_, apiErr, err = hClient.Read(tc.Context(), "invalid id")
 	require.NoError(err)