* refactor (controller): Use a grpc server for the grpc-gateway This starts a grpc server for the grpc-gateway. The new gateway server uses an in-memory listener which also supports "dialing", so the http proxy can connect to the in-memory listener. This change allows us to use all grpc server features and was in part motivated by a need for an interceptor of inbound requests. With that said, having a "proper" grpc server for the gateway will provide a lot more flexibility and capabilities moving forward. The request context will still be verified via middleware in the http proxy (see wrapHandlerWithCommonFuncs). This verified context will be serialized into a protobuf and sent along to the grpc-gateway via metadata where an interceptor will add the verified request info to the request's context (see requestCtxInterceptor). The interceptor will verify the serialized request info via a shared ticket with it's companion in-memory http proxy. FYI: the ticket is simply random base62 string (see db.NewPrivateId). This change also necessitated a minor change to services. We need to return an empty response instead of nil, nil when there are no errors and the response is empty. * refactor (handlers): Rename gRPC Gateway filter Originally, this was called an OutgoingInterceptor, which is an unfortunate name since it's not an interceptor. Now that we're refactoring the gateway stuff and have proper interceptors, renaming this should remove ambiguity * refactor: Rework how 204 with empty msg is handled Recent changes to grpc gateway has necessitated a change to how 204s are handled by the gateway * tests (bats): Check status codes for delete operations
606 lines
21 KiB
Go
606 lines
21 KiB
Go
package sessions_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/hashicorp/boundary/internal/authtoken"
|
|
"github.com/hashicorp/boundary/internal/db"
|
|
"github.com/hashicorp/boundary/internal/errors"
|
|
pbs "github.com/hashicorp/boundary/internal/gen/controller/api/services"
|
|
authpb "github.com/hashicorp/boundary/internal/gen/controller/auth"
|
|
"github.com/hashicorp/boundary/internal/host/static"
|
|
"github.com/hashicorp/boundary/internal/iam"
|
|
"github.com/hashicorp/boundary/internal/kms"
|
|
"github.com/hashicorp/boundary/internal/servers"
|
|
"github.com/hashicorp/boundary/internal/servers/controller/auth"
|
|
"github.com/hashicorp/boundary/internal/servers/controller/handlers"
|
|
"github.com/hashicorp/boundary/internal/servers/controller/handlers/sessions"
|
|
"github.com/hashicorp/boundary/internal/session"
|
|
"github.com/hashicorp/boundary/internal/target"
|
|
"github.com/hashicorp/boundary/internal/target/tcp"
|
|
"github.com/hashicorp/boundary/internal/types/scope"
|
|
"github.com/hashicorp/boundary/sdk/pbs/controller/api/resources/scopes"
|
|
pb "github.com/hashicorp/boundary/sdk/pbs/controller/api/resources/sessions"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/protobuf/testing/protocmp"
|
|
)
|
|
|
|
var testAuthorizedActions = []string{"no-op", "read", "read:self", "cancel", "cancel:self"}
|
|
|
|
func TestGetSession(t *testing.T) {
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
wrap := db.TestWrapper(t)
|
|
kms := kms.TestKms(t, conn, wrap)
|
|
|
|
iamRepo := iam.TestRepo(t, conn, wrap)
|
|
|
|
rw := db.New(conn)
|
|
sessRepo, err := session.NewRepository(rw, rw, kms)
|
|
require.NoError(t, err)
|
|
|
|
iamRepoFn := func() (*iam.Repository, error) {
|
|
return iamRepo, nil
|
|
}
|
|
sessRepoFn := func() (*session.Repository, error) {
|
|
return sessRepo, nil
|
|
}
|
|
|
|
o, p := iam.TestScopes(t, iamRepo)
|
|
at := authtoken.TestAuthToken(t, conn, kms, o.GetPublicId())
|
|
uId := at.GetIamUserId()
|
|
hc := static.TestCatalogs(t, conn, p.GetPublicId(), 1)[0]
|
|
hs := static.TestSets(t, conn, hc.GetPublicId(), 1)[0]
|
|
h := static.TestHosts(t, conn, hc.GetPublicId(), 1)[0]
|
|
static.TestSetMembers(t, conn, hs.GetPublicId(), []*static.Host{h})
|
|
tar := tcp.TestTarget(t, conn, p.GetPublicId(), "test", target.WithHostSources([]string{hs.GetPublicId()}))
|
|
|
|
sess := session.TestSession(t, conn, wrap, session.ComposedOf{
|
|
UserId: uId,
|
|
HostId: h.GetPublicId(),
|
|
TargetId: tar.GetPublicId(),
|
|
HostSetId: hs.GetPublicId(),
|
|
AuthTokenId: at.GetPublicId(),
|
|
ScopeId: p.GetPublicId(),
|
|
Endpoint: "tcp://127.0.0.1:22",
|
|
})
|
|
|
|
wireSess := &pb.Session{
|
|
Id: sess.GetPublicId(),
|
|
ScopeId: p.GetPublicId(),
|
|
AuthTokenId: at.GetPublicId(),
|
|
Endpoint: sess.Endpoint,
|
|
UserId: at.GetIamUserId(),
|
|
TargetId: sess.TargetId,
|
|
HostSetId: sess.HostSetId,
|
|
HostId: sess.HostId,
|
|
Version: sess.Version,
|
|
Status: session.StatusPending.String(),
|
|
UpdatedTime: sess.UpdateTime.GetTimestamp(),
|
|
CreatedTime: sess.CreateTime.GetTimestamp(),
|
|
ExpirationTime: sess.ExpirationTime.GetTimestamp(),
|
|
Scope: &scopes.ScopeInfo{Id: p.GetPublicId(), Type: scope.Project.String(), ParentScopeId: o.GetPublicId()},
|
|
States: []*pb.SessionState{{Status: session.StatusPending.String(), StartTime: sess.CreateTime.GetTimestamp()}},
|
|
Certificate: sess.Certificate,
|
|
Type: tcp.Subtype.String(),
|
|
AuthorizedActions: testAuthorizedActions,
|
|
}
|
|
|
|
cases := []struct {
|
|
name string
|
|
scopeId string
|
|
req *pbs.GetSessionRequest
|
|
res *pbs.GetSessionResponse
|
|
err error
|
|
}{
|
|
{
|
|
name: "Get a session",
|
|
scopeId: sess.ScopeId,
|
|
req: &pbs.GetSessionRequest{Id: sess.GetPublicId()},
|
|
res: &pbs.GetSessionResponse{Item: wireSess},
|
|
},
|
|
{
|
|
name: "Get a non existant Session",
|
|
req: &pbs.GetSessionRequest{Id: session.SessionPrefix + "_DoesntExis"},
|
|
res: nil,
|
|
err: handlers.ApiErrorWithCode(codes.NotFound),
|
|
},
|
|
{
|
|
name: "Wrong id prefix",
|
|
req: &pbs.GetSessionRequest{Id: "j_1234567890"},
|
|
res: nil,
|
|
err: handlers.ApiErrorWithCode(codes.InvalidArgument),
|
|
},
|
|
{
|
|
name: "space in id",
|
|
req: &pbs.GetSessionRequest{Id: session.SessionPrefix + "_1 23456789"},
|
|
res: nil,
|
|
err: handlers.ApiErrorWithCode(codes.InvalidArgument),
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
|
|
s, err := sessions.NewService(sessRepoFn, iamRepoFn)
|
|
require.NoError(err, "Couldn't create new session service.")
|
|
|
|
got, gErr := s.GetSession(auth.DisabledAuthTestContext(iamRepoFn, tc.scopeId), tc.req)
|
|
if tc.err != nil {
|
|
require.Error(gErr)
|
|
assert.True(errors.Is(gErr, tc.err), "GetSession(%+v) got error %v, wanted %v", tc.req, gErr, tc.err)
|
|
}
|
|
if tc.res != nil {
|
|
assert.True(got.GetItem().GetExpirationTime().AsTime().Sub(tc.res.GetItem().GetExpirationTime().AsTime()) < 10*time.Millisecond)
|
|
tc.res.GetItem().ExpirationTime = got.GetItem().GetExpirationTime()
|
|
}
|
|
assert.Empty(cmp.Diff(got, tc.res, protocmp.Transform()), "GetSession(%q) got response\n%q, wanted\n%q", tc.req, got, tc.res)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestList_Self(t *testing.T) {
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
wrap := db.TestWrapper(t)
|
|
kms := kms.TestKms(t, conn, wrap)
|
|
iamRepo := iam.TestRepo(t, conn, wrap)
|
|
|
|
rw := db.New(conn)
|
|
|
|
iamRepoFn := func() (*iam.Repository, error) {
|
|
return iamRepo, nil
|
|
}
|
|
sessRepoFn := func() (*session.Repository, error) {
|
|
return session.NewRepository(rw, rw, kms)
|
|
}
|
|
tokenRepoFn := func() (*authtoken.Repository, error) {
|
|
return authtoken.NewRepository(rw, rw, kms)
|
|
}
|
|
serversRepoFn := func() (*servers.Repository, error) {
|
|
return servers.NewRepository(rw, rw, kms)
|
|
}
|
|
|
|
o, pWithSessions := iam.TestScopes(t, iamRepo)
|
|
|
|
at := authtoken.TestAuthToken(t, conn, kms, o.GetPublicId())
|
|
uId := at.GetIamUserId()
|
|
otherAt := authtoken.TestAuthToken(t, conn, kms, o.GetPublicId())
|
|
|
|
hc := static.TestCatalogs(t, conn, pWithSessions.GetPublicId(), 1)[0]
|
|
hs := static.TestSets(t, conn, hc.GetPublicId(), 1)[0]
|
|
h := static.TestHosts(t, conn, hc.GetPublicId(), 1)[0]
|
|
static.TestSetMembers(t, conn, hs.GetPublicId(), []*static.Host{h})
|
|
tar := tcp.TestTarget(t, conn, pWithSessions.GetPublicId(), "test", target.WithHostSources([]string{hs.GetPublicId()}))
|
|
|
|
// By default a user can read/cancel their own sessions.
|
|
session.TestSession(t, conn, wrap, session.ComposedOf{
|
|
UserId: uId,
|
|
HostId: h.GetPublicId(),
|
|
TargetId: tar.GetPublicId(),
|
|
HostSetId: hs.GetPublicId(),
|
|
AuthTokenId: at.GetPublicId(),
|
|
ScopeId: pWithSessions.GetPublicId(),
|
|
Endpoint: "tcp://127.0.0.1:22",
|
|
})
|
|
|
|
s, err := sessions.NewService(sessRepoFn, iamRepoFn)
|
|
require.NoError(t, err, "Couldn't create new session service.")
|
|
|
|
cases := []struct {
|
|
name string
|
|
requester *authtoken.AuthToken
|
|
count int
|
|
}{
|
|
{
|
|
name: "List Self Sessions",
|
|
requester: at,
|
|
count: 1,
|
|
},
|
|
{
|
|
name: "Can't List Others Sessions",
|
|
requester: otherAt,
|
|
count: 0,
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
// Setup the auth request information
|
|
req := httptest.NewRequest("GET", fmt.Sprintf("http://127.0.0.1/v1/sessions?scope_id=%s", pWithSessions.GetPublicId()), nil)
|
|
requestInfo := authpb.RequestInfo{
|
|
Path: req.URL.Path,
|
|
Method: req.Method,
|
|
TokenFormat: uint32(auth.AuthTokenTypeBearer),
|
|
PublicId: tc.requester.GetPublicId(),
|
|
Token: tc.requester.GetToken(),
|
|
}
|
|
|
|
ctx := auth.NewVerifierContext(context.Background(), iamRepoFn, tokenRepoFn, serversRepoFn, kms, &requestInfo)
|
|
got, err := s.ListSessions(ctx, &pbs.ListSessionsRequest{ScopeId: pWithSessions.GetPublicId()})
|
|
require.NoError(t, err)
|
|
assert.Equal(t, tc.count, len(got.GetItems()), got.GetItems())
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestList(t *testing.T) {
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
wrap := db.TestWrapper(t)
|
|
kms := kms.TestKms(t, conn, wrap)
|
|
|
|
iamRepo := iam.TestRepo(t, conn, wrap)
|
|
|
|
rw := db.New(conn)
|
|
sessRepo, err := session.NewRepository(rw, rw, kms)
|
|
require.NoError(t, err)
|
|
|
|
iamRepoFn := func() (*iam.Repository, error) {
|
|
return iamRepo, nil
|
|
}
|
|
sessRepoFn := func() (*session.Repository, error) {
|
|
return sessRepo, nil
|
|
}
|
|
|
|
_, pNoSessions := iam.TestScopes(t, iamRepo)
|
|
o, pWithSessions := iam.TestScopes(t, iamRepo)
|
|
oOther, pWithOtherSessions := iam.TestScopes(t, iamRepo)
|
|
|
|
at := authtoken.TestAuthToken(t, conn, kms, o.GetPublicId())
|
|
uId := at.GetIamUserId()
|
|
|
|
atOther := authtoken.TestAuthToken(t, conn, kms, oOther.GetPublicId())
|
|
uIdOther := atOther.GetIamUserId()
|
|
|
|
hc := static.TestCatalogs(t, conn, pWithSessions.GetPublicId(), 1)[0]
|
|
hs := static.TestSets(t, conn, hc.GetPublicId(), 1)[0]
|
|
h := static.TestHosts(t, conn, hc.GetPublicId(), 1)[0]
|
|
static.TestSetMembers(t, conn, hs.GetPublicId(), []*static.Host{h})
|
|
tar := tcp.TestTarget(t, conn, pWithSessions.GetPublicId(), "test", target.WithHostSources([]string{hs.GetPublicId()}))
|
|
|
|
hcOther := static.TestCatalogs(t, conn, pWithOtherSessions.GetPublicId(), 1)[0]
|
|
hsOther := static.TestSets(t, conn, hcOther.GetPublicId(), 1)[0]
|
|
hOther := static.TestHosts(t, conn, hcOther.GetPublicId(), 1)[0]
|
|
static.TestSetMembers(t, conn, hsOther.GetPublicId(), []*static.Host{hOther})
|
|
tarOther := tcp.TestTarget(t, conn, pWithOtherSessions.GetPublicId(), "test", target.WithHostSources([]string{hsOther.GetPublicId()}))
|
|
|
|
var wantSession []*pb.Session
|
|
var totalSession []*pb.Session
|
|
for i := 0; i < 10; i++ {
|
|
sess := session.TestSession(t, conn, wrap, session.ComposedOf{
|
|
UserId: uId,
|
|
HostId: h.GetPublicId(),
|
|
TargetId: tar.GetPublicId(),
|
|
HostSetId: hs.GetPublicId(),
|
|
AuthTokenId: at.GetPublicId(),
|
|
ScopeId: pWithSessions.GetPublicId(),
|
|
Endpoint: "tcp://127.0.0.1:22",
|
|
})
|
|
|
|
status, states := convertStates(sess.States)
|
|
|
|
wantSession = append(wantSession, &pb.Session{
|
|
Id: sess.GetPublicId(),
|
|
ScopeId: pWithSessions.GetPublicId(),
|
|
AuthTokenId: at.GetPublicId(),
|
|
UserId: at.GetIamUserId(),
|
|
TargetId: sess.TargetId,
|
|
Endpoint: sess.Endpoint,
|
|
HostSetId: sess.HostSetId,
|
|
HostId: sess.HostId,
|
|
Version: sess.Version,
|
|
UpdatedTime: sess.UpdateTime.GetTimestamp(),
|
|
CreatedTime: sess.CreateTime.GetTimestamp(),
|
|
ExpirationTime: sess.ExpirationTime.GetTimestamp(),
|
|
Scope: &scopes.ScopeInfo{Id: pWithSessions.GetPublicId(), Type: scope.Project.String(), ParentScopeId: o.GetPublicId()},
|
|
Status: status,
|
|
States: states,
|
|
Certificate: sess.Certificate,
|
|
Type: tcp.Subtype.String(),
|
|
AuthorizedActions: testAuthorizedActions,
|
|
})
|
|
|
|
totalSession = append(totalSession, wantSession[i])
|
|
|
|
sess = session.TestSession(t, conn, wrap, session.ComposedOf{
|
|
UserId: uIdOther,
|
|
HostId: hOther.GetPublicId(),
|
|
TargetId: tarOther.GetPublicId(),
|
|
HostSetId: hsOther.GetPublicId(),
|
|
AuthTokenId: atOther.GetPublicId(),
|
|
ScopeId: pWithOtherSessions.GetPublicId(),
|
|
Endpoint: "tcp://127.0.0.1:22",
|
|
})
|
|
|
|
status, states = convertStates(sess.States)
|
|
|
|
totalSession = append(totalSession, &pb.Session{
|
|
Id: sess.GetPublicId(),
|
|
ScopeId: pWithOtherSessions.GetPublicId(),
|
|
AuthTokenId: atOther.GetPublicId(),
|
|
UserId: atOther.GetIamUserId(),
|
|
TargetId: sess.TargetId,
|
|
Endpoint: sess.Endpoint,
|
|
HostSetId: sess.HostSetId,
|
|
HostId: sess.HostId,
|
|
Version: sess.Version,
|
|
UpdatedTime: sess.UpdateTime.GetTimestamp(),
|
|
CreatedTime: sess.CreateTime.GetTimestamp(),
|
|
ExpirationTime: sess.ExpirationTime.GetTimestamp(),
|
|
Scope: &scopes.ScopeInfo{Id: pWithOtherSessions.GetPublicId(), Type: scope.Project.String(), ParentScopeId: oOther.GetPublicId()},
|
|
Status: status,
|
|
States: states,
|
|
Certificate: sess.Certificate,
|
|
Type: tcp.Subtype.String(),
|
|
AuthorizedActions: testAuthorizedActions,
|
|
})
|
|
}
|
|
|
|
cases := []struct {
|
|
name string
|
|
req *pbs.ListSessionsRequest
|
|
res *pbs.ListSessionsResponse
|
|
err error
|
|
}{
|
|
{
|
|
name: "List Many Sessions",
|
|
req: &pbs.ListSessionsRequest{ScopeId: pWithSessions.GetPublicId()},
|
|
res: &pbs.ListSessionsResponse{Items: wantSession},
|
|
},
|
|
{
|
|
name: "List No Sessions",
|
|
req: &pbs.ListSessionsRequest{ScopeId: pNoSessions.GetPublicId()},
|
|
res: &pbs.ListSessionsResponse{},
|
|
},
|
|
{
|
|
name: "List Sessions Recursively",
|
|
req: &pbs.ListSessionsRequest{ScopeId: scope.Global.String(), Recursive: true},
|
|
res: &pbs.ListSessionsResponse{Items: totalSession},
|
|
},
|
|
{
|
|
name: "Filter To Single Sessions",
|
|
req: &pbs.ListSessionsRequest{ScopeId: pWithSessions.GetPublicId(), Filter: fmt.Sprintf(`"/item/id"==%q`, totalSession[4].Id)},
|
|
res: &pbs.ListSessionsResponse{Items: totalSession[4:5]},
|
|
},
|
|
{
|
|
name: "Filter To Many Sessions",
|
|
req: &pbs.ListSessionsRequest{
|
|
ScopeId: scope.Global.String(), Recursive: true,
|
|
Filter: fmt.Sprintf(`"/item/scope/id" matches "^%s"`, pWithSessions.GetPublicId()[:8]),
|
|
},
|
|
res: &pbs.ListSessionsResponse{Items: wantSession},
|
|
},
|
|
{
|
|
name: "Filter To Nothing",
|
|
req: &pbs.ListSessionsRequest{ScopeId: pWithSessions.GetPublicId(), Filter: `"/item/id" == ""`},
|
|
res: &pbs.ListSessionsResponse{},
|
|
},
|
|
{
|
|
name: "Filter Bad Format",
|
|
req: &pbs.ListSessionsRequest{ScopeId: pWithSessions.GetPublicId(), Filter: `//badformat/`},
|
|
err: handlers.InvalidArgumentErrorf("bad format", nil),
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
require, assert := require.New(t), assert.New(t)
|
|
s, err := sessions.NewService(sessRepoFn, iamRepoFn)
|
|
require.NoError(err, "Couldn't create new session service.")
|
|
|
|
// Test without anon user
|
|
got, gErr := s.ListSessions(auth.DisabledAuthTestContext(iamRepoFn, tc.req.GetScopeId()), tc.req)
|
|
if tc.err != nil {
|
|
require.Error(gErr)
|
|
assert.True(errors.Is(gErr, tc.err), "ListSessions(%+v) got error %v, wanted %v", tc.req, gErr, tc.err)
|
|
return
|
|
}
|
|
require.NoError(gErr)
|
|
if tc.res != nil {
|
|
require.Equal(len(tc.res.GetItems()), len(got.GetItems()), "Didn't get expected number of sessions: %v", got.GetItems())
|
|
for i, wantSess := range tc.res.GetItems() {
|
|
assert.True(got.GetItems()[i].GetExpirationTime().AsTime().Sub(wantSess.GetExpirationTime().AsTime()) < 10*time.Millisecond)
|
|
wantSess.ExpirationTime = got.GetItems()[i].GetExpirationTime()
|
|
}
|
|
}
|
|
assert.Empty(cmp.Diff(got, tc.res, protocmp.Transform()), "ListSessions(%q) got response %q, wanted %q", tc.req, got, tc.res)
|
|
|
|
// Test with anon user
|
|
got, gErr = s.ListSessions(auth.DisabledAuthTestContext(iamRepoFn, tc.req.GetScopeId(), auth.WithUserId(auth.AnonymousUserId)), tc.req)
|
|
require.NoError(gErr)
|
|
assert.Len(got.Items, len(tc.res.Items))
|
|
for _, item := range got.GetItems() {
|
|
require.Empty(item.Version)
|
|
require.Empty(item.UserId)
|
|
require.Empty(item.HostId)
|
|
require.Empty(item.HostSetId)
|
|
require.Empty(item.AuthTokenId)
|
|
require.Empty(item.Endpoint)
|
|
require.Nil(item.CreatedTime)
|
|
require.Nil(item.ExpirationTime)
|
|
require.Nil(item.UpdatedTime)
|
|
require.Empty(item.Certificate)
|
|
require.Empty(item.TerminationReason)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func convertStates(in []*session.State) (string, []*pb.SessionState) {
|
|
out := make([]*pb.SessionState, 0, len(in))
|
|
for _, s := range in {
|
|
sessState := &pb.SessionState{
|
|
Status: s.Status.String(),
|
|
}
|
|
if s.StartTime != nil {
|
|
sessState.StartTime = s.StartTime.GetTimestamp()
|
|
}
|
|
if s.EndTime != nil {
|
|
sessState.EndTime = s.EndTime.GetTimestamp()
|
|
}
|
|
out = append(out, sessState)
|
|
}
|
|
return out[0].Status, out
|
|
}
|
|
|
|
func TestCancel(t *testing.T) {
|
|
conn, _ := db.TestSetup(t, "postgres")
|
|
wrap := db.TestWrapper(t)
|
|
kms := kms.TestKms(t, conn, wrap)
|
|
|
|
iamRepo := iam.TestRepo(t, conn, wrap)
|
|
|
|
rw := db.New(conn)
|
|
sessRepo, err := session.NewRepository(rw, rw, kms)
|
|
require.NoError(t, err)
|
|
|
|
iamRepoFn := func() (*iam.Repository, error) {
|
|
return iamRepo, nil
|
|
}
|
|
sessRepoFn := func() (*session.Repository, error) {
|
|
return sessRepo, nil
|
|
}
|
|
|
|
o, p := iam.TestScopes(t, iamRepo)
|
|
at := authtoken.TestAuthToken(t, conn, kms, o.GetPublicId())
|
|
uId := at.GetIamUserId()
|
|
hc := static.TestCatalogs(t, conn, p.GetPublicId(), 1)[0]
|
|
hs := static.TestSets(t, conn, hc.GetPublicId(), 1)[0]
|
|
h := static.TestHosts(t, conn, hc.GetPublicId(), 1)[0]
|
|
static.TestSetMembers(t, conn, hs.GetPublicId(), []*static.Host{h})
|
|
tar := tcp.TestTarget(t, conn, p.GetPublicId(), "test", target.WithHostSources([]string{hs.GetPublicId()}))
|
|
|
|
sess := session.TestSession(t, conn, wrap, session.ComposedOf{
|
|
UserId: uId,
|
|
HostId: h.GetPublicId(),
|
|
TargetId: tar.GetPublicId(),
|
|
HostSetId: hs.GetPublicId(),
|
|
AuthTokenId: at.GetPublicId(),
|
|
ScopeId: p.GetPublicId(),
|
|
Endpoint: "tcp://127.0.0.1:22",
|
|
})
|
|
|
|
wireSess := &pb.Session{
|
|
Id: sess.GetPublicId(),
|
|
ScopeId: p.GetPublicId(),
|
|
AuthTokenId: at.GetPublicId(),
|
|
UserId: at.GetIamUserId(),
|
|
TargetId: sess.TargetId,
|
|
HostSetId: sess.HostSetId,
|
|
HostId: sess.HostId,
|
|
Version: sess.Version,
|
|
Endpoint: sess.Endpoint,
|
|
CreatedTime: sess.CreateTime.GetTimestamp(),
|
|
ExpirationTime: sess.ExpirationTime.GetTimestamp(),
|
|
Scope: &scopes.ScopeInfo{Id: p.GetPublicId(), Type: scope.Project.String(), ParentScopeId: o.GetPublicId()},
|
|
Status: session.StatusCanceling.String(),
|
|
Certificate: sess.Certificate,
|
|
Type: tcp.Subtype.String(),
|
|
AuthorizedActions: testAuthorizedActions,
|
|
}
|
|
|
|
version := wireSess.GetVersion()
|
|
|
|
cases := []struct {
|
|
name string
|
|
scopeId string
|
|
req *pbs.CancelSessionRequest
|
|
res *pbs.CancelSessionResponse
|
|
err error
|
|
}{
|
|
{
|
|
name: "Cancel a session",
|
|
scopeId: sess.ScopeId,
|
|
req: &pbs.CancelSessionRequest{Id: sess.GetPublicId()},
|
|
res: &pbs.CancelSessionResponse{Item: wireSess},
|
|
},
|
|
{
|
|
name: "Already canceled",
|
|
scopeId: sess.ScopeId,
|
|
req: &pbs.CancelSessionRequest{Id: sess.GetPublicId()},
|
|
res: &pbs.CancelSessionResponse{Item: wireSess},
|
|
},
|
|
{
|
|
name: "Cancel a non existing Session",
|
|
req: &pbs.CancelSessionRequest{Id: session.SessionPrefix + "_DoesntExis"},
|
|
res: nil,
|
|
err: handlers.ApiErrorWithCode(codes.NotFound),
|
|
},
|
|
{
|
|
name: "Wrong id prefix",
|
|
req: &pbs.CancelSessionRequest{Id: "j_1234567890"},
|
|
res: nil,
|
|
err: handlers.ApiErrorWithCode(codes.InvalidArgument),
|
|
},
|
|
{
|
|
name: "space in id",
|
|
req: &pbs.CancelSessionRequest{Id: session.SessionPrefix + "_1 23456789"},
|
|
res: nil,
|
|
err: handlers.ApiErrorWithCode(codes.InvalidArgument),
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
|
|
s, err := sessions.NewService(sessRepoFn, iamRepoFn)
|
|
require.NoError(err, "Couldn't create new session service.")
|
|
|
|
tc.req.Version = version
|
|
|
|
got, gErr := s.CancelSession(auth.DisabledAuthTestContext(iamRepoFn, tc.scopeId), tc.req)
|
|
if tc.err != nil {
|
|
require.Error(gErr)
|
|
// It's hard to mix and match api/error package errors right now
|
|
// so use old/new behavior depending on the type. If validate
|
|
// gets updated this can be standardized.
|
|
if errors.Match(errors.T(errors.InvalidSessionState), gErr) {
|
|
assert.True(errors.Match(errors.T(tc.err), gErr), "GetSession(%+v) got error %#v, wanted %#v", tc.req, gErr, tc.err)
|
|
} else {
|
|
assert.True(errors.Is(gErr, tc.err), "GetSession(%+v) got error %v, wanted %v", tc.req, gErr, tc.err)
|
|
}
|
|
}
|
|
|
|
if tc.res == nil {
|
|
require.Nil(got)
|
|
return
|
|
}
|
|
tc.res.GetItem().Version = got.GetItem().Version
|
|
|
|
// Compare the new canceling state and then remove it for the rest of the proto comparison
|
|
assert.True(got.GetItem().GetUpdatedTime().AsTime().After(got.GetItem().GetCreatedTime().AsTime()))
|
|
assert.Len(got.GetItem().GetStates(), 2)
|
|
|
|
wantState := []*pb.SessionState{
|
|
{
|
|
Status: session.StatusCanceling.String(),
|
|
StartTime: got.GetItem().GetUpdatedTime(),
|
|
},
|
|
{
|
|
Status: session.StatusPending.String(),
|
|
StartTime: got.GetItem().GetCreatedTime(),
|
|
EndTime: got.GetItem().GetUpdatedTime(),
|
|
},
|
|
}
|
|
assert.Empty(cmp.Diff(got.GetItem().GetStates(), wantState, protocmp.Transform()), "GetSession(%q) states")
|
|
got.GetItem().States = nil
|
|
got.GetItem().UpdatedTime = nil
|
|
|
|
if tc.res != nil {
|
|
assert.True(got.GetItem().GetExpirationTime().AsTime().Sub(tc.res.GetItem().GetExpirationTime().AsTime()) < 10*time.Millisecond)
|
|
tc.res.GetItem().ExpirationTime = got.GetItem().GetExpirationTime()
|
|
}
|
|
|
|
assert.Empty(cmp.Diff(got, tc.res, protocmp.Transform()), "GetSession(%q) got response\n%q, wanted\n%q", tc.req, got, tc.res)
|
|
|
|
if tc.req != nil {
|
|
require.NotNil(got)
|
|
version = got.GetItem().GetVersion()
|
|
}
|
|
})
|
|
}
|
|
}
|