Timothy Messier
8caaf3e076
This refactors the schema package and subpackages to support editions.
An Edition is a collection of sql migrations. A given boundary binary
can have multiple migration editions. The `schema.Manager` is updated to
apply the necessary migrations in the correct order, leveraging an
Edition's priority to determine the order in which the separate Editions
are applied.
The sql migration files are now nested under a directory for the
edition.
This also switches from the generated code to using embed, which
eliminates the need for the `make migrations` target and the generated
code. As such this commit removes the target and generated code.
See:
https://pkg.go.dev/embed
127 lines
4.1 KiB
Go
127 lines
4.1 KiB
Go
package oss_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/boundary/internal/auth/password"
|
|
"github.com/hashicorp/boundary/internal/db"
|
|
"github.com/hashicorp/boundary/internal/db/common"
|
|
"github.com/hashicorp/boundary/internal/db/schema"
|
|
"github.com/hashicorp/boundary/internal/iam"
|
|
"github.com/hashicorp/boundary/testing/dbtest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// Tests migration:
|
|
// migrations/oss/2/07_iam.up.sql
|
|
func Test_PrimaryAuthMethodChanges(t *testing.T) {
|
|
t.Parallel()
|
|
const priorMigration = 2006
|
|
const primaryAuthMethodMigration = 2007
|
|
t.Run("migrate-store", func(t *testing.T) {
|
|
// this is a sequential test which relies on:
|
|
// 1) initializing the db using a migration up to the "priorMigration"
|
|
//
|
|
// 2) seeding the database with some test scopes and auth methods
|
|
//
|
|
// 3) running the migrations that sets the primary auth methods for
|
|
// existing scopes which only have one auth method.
|
|
//
|
|
// 4) asserting some bits about the state of the db.
|
|
assert, require := assert.New(t), require.New(t)
|
|
dialect := dbtest.Postgres
|
|
ctx := context.Background()
|
|
|
|
c, u, _, err := dbtest.StartUsingTemplate(dialect, dbtest.WithTemplate(dbtest.Template1))
|
|
require.NoError(err)
|
|
t.Cleanup(func() {
|
|
require.NoError(c())
|
|
})
|
|
d, err := common.SqlOpen(dialect, u)
|
|
require.NoError(err)
|
|
|
|
// migration to the prior migration (before the one we want to test)
|
|
m, err := schema.NewManager(ctx, schema.Dialect(dialect), d, schema.WithEditions(
|
|
schema.TestCreatePartialEditions(schema.Dialect(dialect), schema.PartialEditions{"oss": priorMigration}),
|
|
))
|
|
require.NoError(err)
|
|
|
|
assert.NoError(m.ApplyMigrations(ctx))
|
|
state, err := m.CurrentState(ctx)
|
|
require.NoError(err)
|
|
want := &schema.State{
|
|
Initialized: true,
|
|
Editions: []schema.EditionState{
|
|
{
|
|
Name: "oss",
|
|
BinarySchemaVersion: priorMigration,
|
|
DatabaseSchemaVersion: priorMigration,
|
|
DatabaseSchemaState: schema.Equal,
|
|
},
|
|
},
|
|
}
|
|
assert.Equal(want, state)
|
|
|
|
// okay, now we can seed the database with test data
|
|
dbType, err := db.StringToDbType(dialect)
|
|
require.NoError(err)
|
|
conn, err := db.Open(dbType, u)
|
|
require.NoError(err)
|
|
rootWrapper := db.TestWrapper(t)
|
|
iamRepo := iam.TestRepo(t, conn, rootWrapper)
|
|
org, _ := iam.TestScopes(t, iamRepo)
|
|
_ = password.TestAuthMethods(t, conn, org.PublicId, 3)
|
|
org2, _ := iam.TestScopes(t, iamRepo)
|
|
_ = password.TestAuthMethods(t, conn, org2.PublicId, 2)
|
|
|
|
org3, _ := iam.TestScopes(t, iamRepo)
|
|
org3AuthMethods := password.TestAuthMethods(t, conn, org3.PublicId, 1)
|
|
org4, _ := iam.TestScopes(t, iamRepo)
|
|
org4AuthMethods := password.TestAuthMethods(t, conn, org4.PublicId, 1)
|
|
|
|
// now we're ready for the migration we want to test.
|
|
m, err = schema.NewManager(ctx, schema.Dialect(dialect), d, schema.WithEditions(
|
|
schema.TestCreatePartialEditions(schema.Dialect(dialect), schema.PartialEditions{"oss": primaryAuthMethodMigration}),
|
|
))
|
|
require.NoError(err)
|
|
|
|
assert.NoError(m.ApplyMigrations(ctx))
|
|
state, err = m.CurrentState(ctx)
|
|
require.NoError(err)
|
|
want = &schema.State{
|
|
Initialized: true,
|
|
Editions: []schema.EditionState{
|
|
{
|
|
Name: "oss",
|
|
BinarySchemaVersion: primaryAuthMethodMigration,
|
|
DatabaseSchemaVersion: primaryAuthMethodMigration,
|
|
DatabaseSchemaState: schema.Equal,
|
|
},
|
|
},
|
|
}
|
|
assert.Equal(want, state)
|
|
|
|
entries, err := m.GetMigrationLog(ctx)
|
|
require.NoError(err)
|
|
assert.Equalf(2, len(entries), "expected 2 scopes without a primary auth method and got: %d", len(entries))
|
|
|
|
scope1, err := iamRepo.LookupScope(ctx, org.PublicId)
|
|
require.NoError(err)
|
|
assert.Empty(scope1.PrimaryAuthMethodId)
|
|
scope2, err := iamRepo.LookupScope(ctx, org2.PublicId)
|
|
require.NoError(err)
|
|
assert.Empty(scope2.PrimaryAuthMethodId)
|
|
|
|
scope3, err := iamRepo.LookupScope(ctx, org3.PublicId)
|
|
require.NoError(err)
|
|
assert.Equal(org3AuthMethods[0].PublicId, scope3.PrimaryAuthMethodId)
|
|
|
|
scope4, err := iamRepo.LookupScope(ctx, org4.PublicId)
|
|
require.NoError(err)
|
|
assert.Equal(org4AuthMethods[0].PublicId, scope4.PrimaryAuthMethodId)
|
|
})
|
|
}
|