hashicorp-copywrite[bot]andJohan Brandhorst-Satzkorn
29da0bcb92
* Adding explicit MPL license for sub-package. This directory and its subdirectories (packages) contain files licensed with the MPLv2 `LICENSE` file in this directory and are intentionally licensed separately from the BSL `LICENSE` file at the root of this repository. * Adding explicit MPL license for sub-package This directory and its subdirectories (packages) contain files licensed with the MPLv2 `LICENSE` file in this directory and are intentionally licensed separately from the BSL `LICENSE` file at the root of this repository. * Updating the license from MPL to Business Source License Going forward, this project will be licensed under the Business Source License v1.1. Please see our blog post for more details at https://hashi.co/bsl-blog, FAQ at www.hashicorp.com/licensing-faq, and details of the license at www.hashicorp.com/bsl. * Update copyright file headers to BUS-1.1 * Rerun make gen This will pick up the last of the license changes * Revert "Rerun make gen" This reverts commit dbe0968bffd92745d8663c6940debae098395a6b. * Remove copywrite from generation script The current version of copywrite is not sophisticated enough to only apply the copywrite changes to certain subdirectories, so to avoid accidentally relicensing our api and sdk modules, we will stop running the copywrite script until such time that it can do the right thing. * License protobuf API as MPL The protobuf API files are used to generate the SDK, since we want the SDK to be MPL, the protobuf files must also be MPL. This extends to all protobuf files whose sources end up in the SDK directory, including: - internal/proto/controller/api - internal/proto/controller/custom_options - internal/proto/plugin It also includes the generated service directory in internal/gen/controller/api/services, since they are generated from the protobuf sources used for the SDK. * Change website license file name This makes the naming scheme consistent with the rest of the repository. * Add note on licensing to README * Set copywrite license to BUSL * Revert "Add note on licensing to README" This reverts commit 4d865a91a7a4f11605f0dc4609355d7e3c3cfffe. --------- Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com> Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
983 lines
28 KiB
Go
983 lines
28 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package perms
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/boundary/globals"
|
|
"github.com/hashicorp/boundary/internal/types/action"
|
|
"github.com/hashicorp/boundary/internal/types/resource"
|
|
"github.com/hashicorp/boundary/internal/types/scope"
|
|
"github.com/hashicorp/boundary/sdk/pbs/controller/api/resources/scopes"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type scopeGrant struct {
|
|
scope string
|
|
grants []string
|
|
}
|
|
|
|
func Test_ACLAllowed(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx := context.Background()
|
|
|
|
type actionAuthorized struct {
|
|
action action.Type
|
|
authorized bool
|
|
outputFields []string
|
|
}
|
|
type input struct {
|
|
name string
|
|
scopeGrants []scopeGrant
|
|
resource Resource
|
|
actionsAuthorized []actionAuthorized
|
|
userId string
|
|
accountId string
|
|
}
|
|
|
|
// A set of common grants to use in the following tests
|
|
commonGrants := []scopeGrant{
|
|
{
|
|
scope: "o_a",
|
|
grants: []string{
|
|
"ids=ampw_bar,ampw_baz;actions=read,update",
|
|
"id=ampw_bop;actions=read:self,update",
|
|
"type=host-catalog;actions=create",
|
|
"type=target;actions=list",
|
|
"id=*;type=host-set;actions=list,create",
|
|
},
|
|
},
|
|
{
|
|
scope: "o_b",
|
|
grants: []string{
|
|
"id=*;type=host-set;actions=list,create",
|
|
"ids=hcst_mypin;type=host;actions=*;output_fields=name,description",
|
|
"id=*;type=*;actions=authenticate",
|
|
"id=*;type=*;output_fields=id",
|
|
},
|
|
},
|
|
{
|
|
scope: "o_d",
|
|
grants: []string{
|
|
"id=*;type=*;actions=create,update",
|
|
"id=*;type=session;actions=*",
|
|
"id=*;type=account;actions=update;output_fields=id,version",
|
|
},
|
|
},
|
|
}
|
|
templateGrants := []scopeGrant{
|
|
{
|
|
scope: "o_c",
|
|
grants: []string{
|
|
"id={{user.id }};actions=read,update",
|
|
"id={{ account.id}};actions=change-password",
|
|
},
|
|
},
|
|
}
|
|
|
|
// See acl.go for expected allowed formats. The goal here is to basically
|
|
// test those, but also test a whole bunch of nonconforming values.
|
|
tests := []input{
|
|
{
|
|
name: "no grants",
|
|
resource: Resource{ScopeId: "foo", Id: "bar", Type: resource.HostCatalog},
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Create},
|
|
{action: action.Read},
|
|
},
|
|
},
|
|
{
|
|
name: "no overlap",
|
|
resource: Resource{ScopeId: "foo", Id: "bar", Type: resource.HostCatalog},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Create},
|
|
{action: action.Read},
|
|
},
|
|
},
|
|
{
|
|
name: "top level create with type only",
|
|
resource: Resource{ScopeId: "o_a", Type: resource.HostCatalog},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Create, authorized: true},
|
|
{action: action.Delete},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope and id no matching action",
|
|
resource: Resource{ScopeId: "o_a", Id: "a_foo", Type: resource.Role},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Update},
|
|
{action: action.Delete},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope and id and matching action first id",
|
|
resource: Resource{ScopeId: "o_a", Id: "ampw_bar"},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Read, authorized: true},
|
|
{action: action.Update, authorized: true},
|
|
{action: action.Delete},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope and id and matching action second id",
|
|
resource: Resource{ScopeId: "o_a", Id: "ampw_baz"},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Read, authorized: true},
|
|
{action: action.Update, authorized: true},
|
|
{action: action.Delete},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope and type and all action with valid pin",
|
|
resource: Resource{ScopeId: "o_b", Pin: "hcst_mypin", Type: resource.Host},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Read, authorized: true, outputFields: []string{"description", "id", "name"}},
|
|
{action: action.Update, authorized: true, outputFields: []string{"description", "id", "name"}},
|
|
{action: action.Delete, authorized: true, outputFields: []string{"description", "id", "name"}},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope and type and all action but bad pin",
|
|
resource: Resource{ScopeId: "o_b", Pin: "notmypin", Type: resource.Host},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Read, outputFields: []string{"id"}},
|
|
{action: action.Update, outputFields: []string{"id"}},
|
|
{action: action.Delete, outputFields: []string{"id"}},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope and id and some action",
|
|
resource: Resource{ScopeId: "o_b", Id: "myhost", Type: resource.HostSet},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.List, authorized: true, outputFields: []string{"id"}},
|
|
{action: action.Create, authorized: true, outputFields: []string{"id"}},
|
|
{action: action.AddHosts, outputFields: []string{"id"}},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope and id and all action but bad specifier",
|
|
resource: Resource{ScopeId: "o_b", Id: "id_g"},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Read, outputFields: []string{"id"}},
|
|
{action: action.Update, outputFields: []string{"id"}},
|
|
{action: action.Delete, outputFields: []string{"id"}},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope and not matching type",
|
|
resource: Resource{ScopeId: "o_a", Type: resource.HostCatalog},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Update},
|
|
{action: action.Delete},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope and matching type",
|
|
resource: Resource{ScopeId: "o_a", Type: resource.HostSet},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.List, authorized: true},
|
|
{action: action.Create, authorized: true},
|
|
{action: action.Delete},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope, type, action, random id and bad pin first id",
|
|
resource: Resource{ScopeId: "o_a", Id: "anything", Type: resource.HostCatalog, Pin: "ampw_bar"},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Update},
|
|
{action: action.Delete},
|
|
{action: action.Read},
|
|
},
|
|
},
|
|
{
|
|
name: "matching scope, type, action, random id and bad pin second id",
|
|
resource: Resource{ScopeId: "o_a", Id: "anything", Type: resource.HostCatalog, Pin: "ampw_baz"},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Update},
|
|
{action: action.Delete},
|
|
{action: action.Read},
|
|
},
|
|
},
|
|
{
|
|
name: "wrong scope and matching type",
|
|
resource: Resource{ScopeId: "o_bad", Type: resource.HostSet},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.List},
|
|
{action: action.Create},
|
|
{action: action.Delete},
|
|
},
|
|
},
|
|
{
|
|
name: "any id",
|
|
resource: Resource{ScopeId: "o_b", Type: resource.AuthMethod},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.List, outputFields: []string{"id"}},
|
|
{action: action.Authenticate, authorized: true, outputFields: []string{"id"}},
|
|
{action: action.Delete, outputFields: []string{"id"}},
|
|
},
|
|
},
|
|
{
|
|
name: "bad templated user id",
|
|
resource: Resource{ScopeId: "o_c"},
|
|
scopeGrants: append(commonGrants, templateGrants...),
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.List},
|
|
{action: action.Authenticate},
|
|
{action: action.Delete},
|
|
},
|
|
userId: "u_abcd1234",
|
|
},
|
|
{
|
|
name: "good templated user id",
|
|
resource: Resource{ScopeId: "o_c", Id: "u_abcd1234"},
|
|
scopeGrants: append(commonGrants, templateGrants...),
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Read, authorized: true},
|
|
{action: action.Update, authorized: true},
|
|
},
|
|
userId: "u_abcd1234",
|
|
},
|
|
{
|
|
name: "bad templated old account id",
|
|
resource: Resource{ScopeId: "o_c"},
|
|
scopeGrants: append(commonGrants, templateGrants...),
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.List},
|
|
{action: action.Authenticate},
|
|
{action: action.Delete},
|
|
},
|
|
accountId: fmt.Sprintf("%s_1234567890", globals.PasswordAccountPreviousPrefix),
|
|
},
|
|
{
|
|
name: "good templated old account id",
|
|
resource: Resource{ScopeId: "o_c", Id: fmt.Sprintf("%s_1234567890", globals.PasswordAccountPreviousPrefix)},
|
|
scopeGrants: append(commonGrants, templateGrants...),
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.ChangePassword, authorized: true},
|
|
{action: action.Update},
|
|
},
|
|
accountId: fmt.Sprintf("%s_1234567890", globals.PasswordAccountPreviousPrefix),
|
|
},
|
|
{
|
|
name: "bad templated new account id",
|
|
resource: Resource{ScopeId: "o_c"},
|
|
scopeGrants: append(commonGrants, templateGrants...),
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.List},
|
|
{action: action.Authenticate},
|
|
{action: action.Delete},
|
|
},
|
|
accountId: fmt.Sprintf("%s_1234567890", globals.PasswordAccountPrefix),
|
|
},
|
|
{
|
|
name: "good templated new account id",
|
|
resource: Resource{ScopeId: "o_c", Id: fmt.Sprintf("%s_1234567890", globals.PasswordAccountPrefix)},
|
|
scopeGrants: append(commonGrants, templateGrants...),
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.ChangePassword, authorized: true},
|
|
{action: action.Update},
|
|
},
|
|
accountId: fmt.Sprintf("%s_1234567890", globals.PasswordAccountPrefix),
|
|
},
|
|
{
|
|
name: "all type",
|
|
resource: Resource{ScopeId: "o_d", Type: resource.Account},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Create, authorized: true},
|
|
{action: action.Update, authorized: true, outputFields: []string{"id", "version"}},
|
|
},
|
|
userId: "u_abcd1234",
|
|
},
|
|
{
|
|
name: "list with top level list",
|
|
resource: Resource{ScopeId: "o_a", Type: resource.Target},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.List, authorized: true},
|
|
},
|
|
},
|
|
{
|
|
name: "list sessions with wildcard actions",
|
|
resource: Resource{ScopeId: "o_d", Type: resource.Session},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.List, authorized: true},
|
|
},
|
|
},
|
|
{
|
|
name: "read self with top level read first id",
|
|
resource: Resource{ScopeId: "o_a", Id: "ampw_bar"},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Read, authorized: true},
|
|
{action: action.ReadSelf, authorized: true},
|
|
},
|
|
},
|
|
{
|
|
name: "read self with top level read second id",
|
|
resource: Resource{ScopeId: "o_a", Id: "ampw_baz"},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Read, authorized: true},
|
|
{action: action.ReadSelf, authorized: true},
|
|
},
|
|
},
|
|
{
|
|
name: "read self only",
|
|
resource: Resource{ScopeId: "o_a", Id: "ampw_bop"},
|
|
scopeGrants: commonGrants,
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.Read},
|
|
{action: action.ReadSelf, authorized: true},
|
|
},
|
|
},
|
|
{
|
|
name: "create worker with create",
|
|
resource: Resource{ScopeId: scope.Global.String(), Type: resource.Worker},
|
|
scopeGrants: []scopeGrant{
|
|
{
|
|
scope: scope.Global.String(),
|
|
grants: []string{
|
|
"type=worker;actions=create",
|
|
},
|
|
},
|
|
},
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.CreateWorkerLed, authorized: true},
|
|
},
|
|
},
|
|
{
|
|
name: "create worker with request only",
|
|
resource: Resource{ScopeId: scope.Global.String(), Type: resource.Worker},
|
|
scopeGrants: []scopeGrant{
|
|
{
|
|
scope: scope.Global.String(),
|
|
grants: []string{
|
|
"type=worker;actions=create:worker-led",
|
|
},
|
|
},
|
|
},
|
|
actionsAuthorized: []actionAuthorized{
|
|
{action: action.CreateWorkerLed, authorized: true},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
var grants []Grant
|
|
for _, sg := range test.scopeGrants {
|
|
for _, g := range sg.grants {
|
|
grant, err := Parse(ctx, sg.scope, g, WithAccountId(test.accountId), WithUserId(test.userId))
|
|
require.NoError(t, err)
|
|
grants = append(grants, grant)
|
|
}
|
|
}
|
|
acl := NewACL(grants...)
|
|
for _, aa := range test.actionsAuthorized {
|
|
userId := test.userId
|
|
if userId == "" {
|
|
userId = "u_1234567890"
|
|
}
|
|
result := acl.Allowed(test.resource, aa.action, userId)
|
|
assert.True(t, result.Authorized == aa.authorized, "action: %s, acl authorized: %t, test action authorized: %t", aa.action, result.Authorized, aa.authorized)
|
|
fields, _ := result.OutputFields.Fields()
|
|
assert.ElementsMatch(t, fields, aa.outputFields)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestACL_ListPermissions(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx := context.Background()
|
|
|
|
tests := []struct {
|
|
name string
|
|
userId string
|
|
aclGrants []scopeGrant
|
|
scopes map[string]*scopes.ScopeInfo // *scopes.ScopeInfo isn't used at the moment.
|
|
resourceType resource.Type
|
|
actionSet action.ActionSet
|
|
expPermissions []Permission
|
|
skipGrantValidationChecking bool
|
|
}{
|
|
{
|
|
name: "Requested scope(s) not present in ACL scope map",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=session;actions=list,read"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{
|
|
"o_non_existent_scope": nil,
|
|
"o_this_one_too": nil,
|
|
},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.Read},
|
|
expPermissions: []Permission{},
|
|
},
|
|
{
|
|
name: "Requested resource mismatch",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=target;actions=list,read"}, // List & Read for all Targets
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session, // We're requesting sessions.
|
|
actionSet: action.ActionSet{action.Read},
|
|
expPermissions: []Permission{},
|
|
},
|
|
{
|
|
name: "Requested actions not available for the requested scope id",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=session;actions=delete"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.Read},
|
|
expPermissions: []Permission{},
|
|
},
|
|
{
|
|
name: "No specific id or wildcard provided for `id` field",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"type=*;actions=list,read"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.Read},
|
|
expPermissions: []Permission{},
|
|
skipGrantValidationChecking: true,
|
|
},
|
|
{
|
|
name: "Allow all ids",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=session;actions=list,read"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.Read},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: false,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Allow all ids, :self actions",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=session;actions=list,read:self"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.ReadSelf},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: true,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Allow specific IDs",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{
|
|
"id=s_1;type=session;actions=list,read",
|
|
"ids=s_2,s_3;type=session;actions=list,read",
|
|
},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.Read},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: []string{"s_1", "s_2", "s_3"},
|
|
OnlySelf: false,
|
|
All: false,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "No specific type 1",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=*;actions=list,read:self"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.ReadSelf},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: true,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "List + No-op action with id wildcard",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=session;actions=list,no-op"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.NoOp},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: false,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "List + No-op action with id wildcard, read present",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=session;actions=list,no-op"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.Read},
|
|
expPermissions: []Permission{},
|
|
},
|
|
{
|
|
name: "List + No-op action with specific ids",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{
|
|
"id=s_1;type=session;actions=list,no-op",
|
|
"ids=s_2,s_3;type=session;actions=list,no-op",
|
|
},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.NoOp},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: []string{"s_1", "s_2", "s_3"},
|
|
OnlySelf: false,
|
|
All: false,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "No specific type 2",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=*;actions=list,read:self"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Host,
|
|
actionSet: action.ActionSet{action.ReadSelf},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Host,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: true,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Grant hierarchy is respected",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{
|
|
"id=*;type=*;actions=*",
|
|
"id=*;type=session;actions=cancel:self,list,read:self",
|
|
},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.NoOp, action.Read, action.ReadSelf, action.Cancel, action.CancelSelf},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: false,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Full access 1",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=*;actions=*"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.Read, action.Create, action.Delete},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: false,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Full access 2",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{"id=*;type=*;actions=*"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil},
|
|
resourceType: resource.Host,
|
|
actionSet: action.ActionSet{action.Read, action.Create, action.Delete},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Host,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: false,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Multiple scopes",
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "o_1",
|
|
grants: []string{
|
|
"id=s_1;type=session;actions=list,read",
|
|
"ids=s_2,s_3;type=session;actions=list,read",
|
|
},
|
|
},
|
|
{
|
|
scope: "o_2",
|
|
grants: []string{"id=*;type=session;actions=list,read:self"},
|
|
},
|
|
},
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil, "o_2": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.Read, action.ReadSelf},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: []string{"s_1", "s_2", "s_3"},
|
|
OnlySelf: false,
|
|
All: false,
|
|
},
|
|
{
|
|
ScopeId: "o_2",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: true,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Allow recovery user full access to sessions",
|
|
userId: globals.RecoveryUserId,
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil, "o_2": nil},
|
|
resourceType: resource.Session,
|
|
actionSet: action.ActionSet{action.Read, action.Create, action.Delete},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: false,
|
|
All: true,
|
|
},
|
|
{
|
|
ScopeId: "o_2",
|
|
Resource: resource.Session,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: false,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Allow recovery user full access to targets",
|
|
userId: globals.RecoveryUserId,
|
|
scopes: map[string]*scopes.ScopeInfo{"o_1": nil, "o_2": nil},
|
|
resourceType: resource.Target,
|
|
actionSet: action.ActionSet{action.Read, action.Create, action.Delete},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "o_1",
|
|
Resource: resource.Target,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: false,
|
|
All: true,
|
|
},
|
|
{
|
|
ScopeId: "o_2",
|
|
Resource: resource.Target,
|
|
Action: action.List,
|
|
ResourceIds: nil,
|
|
OnlySelf: false,
|
|
All: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "separate_type_id_resource_grants",
|
|
scopes: map[string]*scopes.ScopeInfo{"p_1": nil},
|
|
resourceType: resource.Target,
|
|
actionSet: action.ActionSet{action.Read, action.Cancel},
|
|
aclGrants: []scopeGrant{
|
|
{
|
|
scope: "p_1",
|
|
grants: []string{
|
|
"type=target;actions=list",
|
|
"id=ttcp_1234567890;actions=read",
|
|
},
|
|
},
|
|
},
|
|
expPermissions: []Permission{
|
|
{
|
|
ScopeId: "p_1",
|
|
Resource: resource.Target,
|
|
Action: action.List,
|
|
ResourceIds: []string{"ttcp_1234567890"},
|
|
All: false,
|
|
OnlySelf: false,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
userId := tt.userId
|
|
if userId == "" {
|
|
userId = "u_1234567890"
|
|
}
|
|
var grants []Grant
|
|
for _, sg := range tt.aclGrants {
|
|
for _, g := range sg.grants {
|
|
grant, err := Parse(ctx, sg.scope, g, WithSkipFinalValidation(tt.skipGrantValidationChecking))
|
|
require.NoError(t, err)
|
|
grants = append(grants, grant)
|
|
}
|
|
}
|
|
|
|
acl := NewACL(grants...)
|
|
perms := acl.ListPermissions(tt.scopes, tt.resourceType, tt.actionSet, userId)
|
|
require.ElementsMatch(t, tt.expPermissions, perms)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestJsonMarshal(t *testing.T) {
|
|
res := &Resource{
|
|
ScopeId: "scope",
|
|
Id: "id",
|
|
Type: resource.Controller,
|
|
Pin: "",
|
|
}
|
|
|
|
out, err := json.Marshal(res)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, `{"scope_id":"scope","id":"id","type":"controller"}`, string(out))
|
|
}
|
|
|
|
// Test_AnonRestrictions loops through every resource and action and ensures
|
|
// that it always fails for the anonymous user, regardless of what is granted,
|
|
// except for the specific things allowed.
|
|
func Test_AnonRestrictions(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx := context.Background()
|
|
|
|
type input struct {
|
|
name string
|
|
grant string
|
|
templatedType bool
|
|
shouldHaveSuccess bool
|
|
}
|
|
tests := []input{
|
|
{
|
|
name: "id-specific",
|
|
grant: "id=foobar;actions=%s",
|
|
},
|
|
{
|
|
name: "ids-specific",
|
|
grant: "ids=foobar;actions=%s",
|
|
},
|
|
{
|
|
name: "wildcard-id",
|
|
grant: "id=*;type=%s;actions=%s",
|
|
templatedType: true,
|
|
shouldHaveSuccess: true,
|
|
},
|
|
{
|
|
name: "wildcard-ids",
|
|
grant: "ids=*;type=%s;actions=%s",
|
|
templatedType: true,
|
|
shouldHaveSuccess: true,
|
|
},
|
|
{
|
|
name: "wildcard-id-and-type",
|
|
grant: "id=*;type=*;actions=%s",
|
|
},
|
|
{
|
|
name: "wildcard-ids-and-type",
|
|
grant: "ids=*;type=*;actions=%s",
|
|
},
|
|
{
|
|
name: "no-id",
|
|
grant: "type=%s;actions=%s",
|
|
templatedType: true,
|
|
shouldHaveSuccess: true,
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
require, assert := require.New(t), assert.New(t)
|
|
for i := resource.Type(1); i <= resource.StorageBucket; i++ {
|
|
if i == resource.Controller || i == resource.Worker {
|
|
continue
|
|
}
|
|
for j := action.Type(1); j <= action.Download; j++ {
|
|
id := "foobar"
|
|
prefixes := globals.ResourcePrefixesFromType(resource.Type(i))
|
|
if len(prefixes) > 0 {
|
|
id = fmt.Sprintf("%s_%s", prefixes[0], id)
|
|
// If it's global scope, correct it
|
|
if id == "global_foobar" {
|
|
id = "global"
|
|
}
|
|
}
|
|
res := Resource{
|
|
ScopeId: scope.Global.String(),
|
|
Id: id,
|
|
Type: resource.Type(i),
|
|
}
|
|
grant := test.grant
|
|
if test.templatedType {
|
|
grant = fmt.Sprintf(grant, resource.Type(i).String(), action.Type(j).String())
|
|
} else {
|
|
grant = fmt.Sprintf(grant, action.Type(j).String())
|
|
}
|
|
|
|
parsedGrant, err := Parse(ctx, scope.Global.String(), grant, WithSkipFinalValidation(true))
|
|
require.NoError(err)
|
|
|
|
acl := NewACL(parsedGrant)
|
|
results := acl.Allowed(res, action.Type(j), globals.AnonymousUserId)
|
|
|
|
switch test.shouldHaveSuccess {
|
|
case true:
|
|
// Ensure it's one of the specific cases and fail otherwise
|
|
switch {
|
|
case i == resource.Scope && (j == action.List || j == action.NoOp):
|
|
assert.True(results.Authorized, fmt.Sprintf("i: %v, j: %v", i, j))
|
|
case i == resource.AuthMethod && (j == action.List || j == action.NoOp || j == action.Authenticate):
|
|
assert.True(results.Authorized, fmt.Sprintf("i: %v, j: %v", i, j))
|
|
default:
|
|
assert.False(results.Authorized, fmt.Sprintf("i: %v, j: %v", i, j))
|
|
}
|
|
default:
|
|
// Should always fail
|
|
assert.False(results.Authorized)
|
|
}
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|