On a SIGHUP, if the worker's `initial_upstreams` config option has
changed, it will use the new values as the address to send its status.
Any previously discovered upstream addresses from previous status
requests are dropped. Once a successful status request is made to the
new addresses, the worker will resume its normal behavior of using the
addresses from the response to the status request.
This allows a worker to be deployed in a more stable way in a dynamic
environment where controller IPs could change. In particular this helps
with a case where all controllers are replaced with new controllers
running on new IPs.
To illustrate with an example, suppose there is an instance group of
controllers instances. And there are worker instances that have their
config rendered from consul-template that sets `initial_upstreams` to
the IPs of the controller instances. If all controller instances are
restarted or replaced at the same time and assigned new IPs, a new
config will be rendered for the worker. Previously the only way for the
worker to use the new value would be for the worker process to be
restarted. Otherwise the worker would only know about the previous IPs
and would fail to connect to the new controllers. However, a restart
would mean any active sessions and session connections on the worker
instance would be terminated. With this update, consul-template can send
a SIGHUP to the worker, the worker will connect to the new controllers
and resume normal status reporting, allowing the sessions and session
connections to remain.
The same principles would apply for other examples of dynamic
environments such as nomad and kubernetes.
See:
https://github.com/hashicorp/consul-template
https://www.nomadproject.io/docs/job-specification/template
392 lines
14 KiB
Go
392 lines
14 KiB
Go
package worker
|
||
|
||
import (
|
||
"context"
|
||
"errors"
|
||
"fmt"
|
||
"math/rand"
|
||
"time"
|
||
|
||
"github.com/hashicorp/boundary/internal/daemon/worker/common"
|
||
"github.com/hashicorp/boundary/internal/daemon/worker/session"
|
||
pb "github.com/hashicorp/boundary/internal/gen/controller/servers"
|
||
pbs "github.com/hashicorp/boundary/internal/gen/controller/servers/services"
|
||
"github.com/hashicorp/boundary/internal/observability/event"
|
||
"github.com/hashicorp/go-secure-stdlib/strutil"
|
||
)
|
||
|
||
var firstStatusCheckPostHooks []func(context.Context, *Worker) error
|
||
|
||
var downstreamWorkersFactory func(ctx context.Context, workerId string) (downstreamers, error)
|
||
|
||
type LastStatusInformation struct {
|
||
*pbs.StatusResponse
|
||
StatusTime time.Time
|
||
LastCalculatedUpstreams []string
|
||
}
|
||
|
||
func (w *Worker) startStatusTicking(cancelCtx context.Context, sessionManager session.Manager, addrReceivers *[]addressReceiver) {
|
||
const op = "worker.(Worker).startStatusTicking"
|
||
r := rand.New(rand.NewSource(time.Now().UnixNano()))
|
||
// This function exists to desynchronize calls to controllers from
|
||
// workers, so we aren't always getting status updates at the exact same
|
||
// intervals, to ease the load on the DB.
|
||
getRandomInterval := func() time.Duration {
|
||
// 0 to 0.5 adjustment to the base
|
||
f := r.Float64() / 2
|
||
// Half a chance to be faster, not slower
|
||
if r.Float32() > 0.5 {
|
||
f = -1 * f
|
||
}
|
||
return common.StatusInterval + time.Duration(f*float64(time.Second))
|
||
}
|
||
|
||
timer := time.NewTimer(0)
|
||
for {
|
||
select {
|
||
case <-cancelCtx.Done():
|
||
event.WriteSysEvent(w.baseContext, op, "status ticking shutting down")
|
||
return
|
||
|
||
case <-timer.C:
|
||
// If we've never managed to successfully authenticate then we won't have
|
||
// any session information anyways and this will produce a ton of noise in
|
||
// observability, so skip calling the function and retry in a short duration
|
||
if w.everAuthenticated.Load() == authenticationStatusNeverAuthenticated {
|
||
timer.Reset(10 * time.Millisecond)
|
||
continue
|
||
}
|
||
|
||
w.sendWorkerStatus(cancelCtx, sessionManager, addrReceivers)
|
||
timer.Reset(getRandomInterval())
|
||
}
|
||
}
|
||
}
|
||
|
||
// LastStatusSuccess reports the last time we sent a successful
|
||
// status request.
|
||
func (w *Worker) LastStatusSuccess() *LastStatusInformation {
|
||
s, ok := w.lastStatusSuccess.Load().(*LastStatusInformation)
|
||
if !ok {
|
||
return nil
|
||
}
|
||
return s
|
||
}
|
||
|
||
// WaitForNextSuccessfulStatusUpdate waits for the next successful status. It's
|
||
// used by testing (and in the future, shutdown) in place of a more opaque and
|
||
// possibly unnecessarily long sleep for things like initial controller
|
||
// check-in, etc.
|
||
//
|
||
// The timeout is aligned with the worker's status grace period. A nil error
|
||
// means the status was sent successfully.
|
||
func (w *Worker) WaitForNextSuccessfulStatusUpdate() error {
|
||
const op = "worker.(Worker).WaitForNextSuccessfulStatusUpdate"
|
||
waitStatusStart := time.Now()
|
||
ctx, cancel := context.WithTimeout(w.baseContext, w.conf.StatusGracePeriodDuration)
|
||
defer cancel()
|
||
event.WriteSysEvent(ctx, op, "waiting for next status report to controller")
|
||
for {
|
||
select {
|
||
case <-time.After(time.Second):
|
||
// pass
|
||
|
||
case <-ctx.Done():
|
||
event.WriteError(ctx, op, ctx.Err(), event.WithInfoMsg("error waiting for next status report to controller"))
|
||
return ctx.Err()
|
||
}
|
||
|
||
if w.lastSuccessfulStatusTime().Sub(waitStatusStart) > 0 {
|
||
break
|
||
}
|
||
}
|
||
|
||
event.WriteSysEvent(ctx, op, "next worker status update sent successfully")
|
||
return nil
|
||
}
|
||
|
||
func (w *Worker) sendWorkerStatus(cancelCtx context.Context, sessionManager session.Manager, addressReceivers *[]addressReceiver) {
|
||
const op = "worker.(Worker).sendWorkerStatus"
|
||
w.statusLock.Lock()
|
||
defer w.statusLock.Unlock()
|
||
|
||
// First send info as-is. We'll perform cleanup duties after we
|
||
// get cancel/job change info back.
|
||
var activeJobs []*pbs.JobStatus
|
||
|
||
// Range over known sessions and collect info
|
||
sessionManager.ForEachLocalSession(func(s session.Session) bool {
|
||
var jobInfo pbs.SessionJobInfo
|
||
status := s.GetStatus()
|
||
sessionId := s.GetId()
|
||
connections := make([]*pbs.Connection, 0, len(s.GetLocalConnections()))
|
||
for k, v := range s.GetLocalConnections() {
|
||
connections = append(connections, &pbs.Connection{
|
||
ConnectionId: k,
|
||
Status: v.Status,
|
||
})
|
||
}
|
||
jobInfo.SessionId = sessionId
|
||
activeJobs = append(activeJobs, &pbs.JobStatus{
|
||
Job: &pbs.Job{
|
||
Type: pbs.JOBTYPE_JOBTYPE_SESSION,
|
||
JobInfo: &pbs.Job_SessionInfo{
|
||
SessionInfo: &pbs.SessionJobInfo{
|
||
SessionId: sessionId,
|
||
Status: status,
|
||
Connections: connections,
|
||
},
|
||
},
|
||
},
|
||
})
|
||
return true
|
||
})
|
||
|
||
// Send status information
|
||
client := w.controllerStatusConn.Load().(pbs.ServerCoordinationServiceClient)
|
||
var tags []*pb.TagPair
|
||
// If we're not going to request a tag update, no reason to have these
|
||
// marshaled on every status call.
|
||
if w.updateTags.Load() {
|
||
tags = w.tags.Load().([]*pb.TagPair)
|
||
}
|
||
statusCtx, statusCancel := context.WithTimeout(cancelCtx, common.StatusTimeout)
|
||
defer statusCancel()
|
||
|
||
keyId := w.WorkerAuthCurrentKeyId.Load()
|
||
|
||
if w.conf.RawConfig.Worker.Name == "" && keyId == "" {
|
||
event.WriteError(statusCtx, op, errors.New("worker name and keyId are both empty; one is needed to identify a worker"),
|
||
event.WithInfoMsg("error making status request to controller"))
|
||
}
|
||
|
||
result, err := client.Status(statusCtx, &pbs.StatusRequest{
|
||
Jobs: activeJobs,
|
||
WorkerStatus: &pb.ServerWorkerStatus{
|
||
Name: w.conf.RawConfig.Worker.Name,
|
||
Description: w.conf.RawConfig.Worker.Description,
|
||
Address: w.conf.RawConfig.Worker.PublicAddr,
|
||
Tags: tags,
|
||
KeyId: keyId,
|
||
},
|
||
UpdateTags: w.updateTags.Load(),
|
||
})
|
||
if err != nil {
|
||
event.WriteError(statusCtx, op, err, event.WithInfoMsg("error making status request to controller"))
|
||
// Check for last successful status. Ignore nil last status, this probably
|
||
// means that we've never connected to a controller, and as such probably
|
||
// don't have any sessions to worry about anyway.
|
||
//
|
||
// If a length of time has passed since we've been able to communicate, we
|
||
// want to start terminating all connections as a "break glass" kind of
|
||
// scenario, as there will be no way we can really tell if these
|
||
// connections should continue to exist.
|
||
if isPastGrace, lastStatusTime, gracePeriod := w.isPastGrace(); isPastGrace {
|
||
event.WriteError(statusCtx, op,
|
||
errors.New("status error grace period has expired, canceling all sessions on worker"),
|
||
event.WithInfo("last_status_time", lastStatusTime.String(), "grace_period", gracePeriod),
|
||
)
|
||
|
||
// Cancel connections if grace period has expired. These Connections will be closed in the
|
||
// database on the next successful status report, or via the Controller’s dead Worker cleanup connections job.
|
||
sessionManager.ForEachLocalSession(func(s session.Session) bool {
|
||
for _, connId := range s.CancelAllLocalConnections() {
|
||
event.WriteSysEvent(cancelCtx, op, "terminated connection due to status grace period expiration", "session_id", s.GetId(), "connection_id", connId)
|
||
}
|
||
return true
|
||
})
|
||
|
||
// Exit out of status function; our work here is done and we don't need to create closeConnection requests
|
||
return
|
||
}
|
||
|
||
// Standard cleanup: Run through current jobs. Cancel connections
|
||
// for any canceling session or any session that is expired.
|
||
w.cleanupConnections(cancelCtx, false, sessionManager)
|
||
return
|
||
}
|
||
|
||
w.updateTags.Store(false)
|
||
var addrs []string
|
||
// This may be empty if we are in a multiple hop scenario
|
||
if len(result.CalculatedUpstreams) > 0 {
|
||
addrs = make([]string, 0, len(result.CalculatedUpstreams))
|
||
for _, v := range result.CalculatedUpstreams {
|
||
addrs = append(addrs, v.Address)
|
||
}
|
||
} else if w.conf.RawConfig.HcpbClusterId != "" && len(w.conf.RawConfig.Worker.InitialUpstreams) == 0 {
|
||
// This is a worker that is one hop away from managed workers, so attempt to get that list
|
||
hcpbWorkersCtx, hcpbWorkersCancel := context.WithTimeout(cancelCtx, common.StatusTimeout)
|
||
defer hcpbWorkersCancel()
|
||
workersResp, err := client.ListHcpbWorkers(hcpbWorkersCtx, &pbs.ListHcpbWorkersRequest{})
|
||
if err != nil {
|
||
event.WriteError(hcpbWorkersCtx, op, err, event.WithInfoMsg("error fetching managed worker information"))
|
||
} else {
|
||
addrs = make([]string, 0, len(workersResp.Workers))
|
||
for _, v := range workersResp.Workers {
|
||
addrs = append(addrs, v.Address)
|
||
}
|
||
}
|
||
}
|
||
|
||
if len(addrs) > 0 {
|
||
lastStatus := w.lastStatusSuccess.Load().(*LastStatusInformation)
|
||
// Compare upstreams; update resolver if there is a difference, and emit an event with old and new addresses
|
||
if lastStatus != nil && !strutil.EquivalentSlices(lastStatus.LastCalculatedUpstreams, addrs) {
|
||
upstreamsMessage := fmt.Sprintf("Upstreams has changed; old upstreams were: %s, new upstreams are: %s", lastStatus.LastCalculatedUpstreams, addrs)
|
||
event.WriteSysEvent(cancelCtx, op, upstreamsMessage)
|
||
for _, as := range *addressReceivers {
|
||
as.SetAddresses(addrs)
|
||
}
|
||
} else if lastStatus == nil {
|
||
for _, as := range *addressReceivers {
|
||
as.SetAddresses(addrs)
|
||
}
|
||
event.WriteSysEvent(cancelCtx, op, fmt.Sprintf("Upstreams after first status set to: %s", addrs))
|
||
}
|
||
}
|
||
|
||
// regardless of whether or not it's a new address, we need to set
|
||
// them for dialingListeners
|
||
for _, as := range *addressReceivers {
|
||
switch {
|
||
case as.Type() == dialingListenerReceiverType:
|
||
tmpAddrs := make([]string, len(addrs))
|
||
copy(tmpAddrs, addrs)
|
||
if len(tmpAddrs) == 0 {
|
||
tmpAddrs = append(tmpAddrs, w.conf.RawConfig.Worker.InitialUpstreams...)
|
||
}
|
||
as.SetAddresses(tmpAddrs)
|
||
}
|
||
}
|
||
|
||
w.lastStatusSuccess.Store(&LastStatusInformation{StatusResponse: result, StatusTime: time.Now(), LastCalculatedUpstreams: addrs})
|
||
|
||
for _, request := range result.GetJobsRequests() {
|
||
switch request.GetRequestType() {
|
||
case pbs.CHANGETYPE_CHANGETYPE_UPDATE_STATE:
|
||
switch request.GetJob().GetType() {
|
||
case pbs.JOBTYPE_JOBTYPE_SESSION:
|
||
sessInfo := request.GetJob().GetSessionInfo()
|
||
sessionId := sessInfo.GetSessionId()
|
||
si := sessionManager.Get(sessionId)
|
||
if si == nil {
|
||
event.WriteError(statusCtx, op, errors.New("session change requested but could not find local information for it"), event.WithInfo("session_id", sessionId))
|
||
continue
|
||
}
|
||
si.ApplyLocalStatus(sessInfo.GetStatus())
|
||
|
||
// Update connection state if there are any connections in
|
||
// the request.
|
||
for _, conn := range sessInfo.GetConnections() {
|
||
if err := si.ApplyLocalConnectionStatus(conn.GetConnectionId(), conn.GetStatus()); err != nil {
|
||
event.WriteError(statusCtx, op, err, event.WithInfo("connection_id", conn.GetConnectionId()))
|
||
}
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
// Standard cleanup: Run through current jobs. Cancel connections
|
||
// for any canceling session or any session that is expired.
|
||
w.cleanupConnections(cancelCtx, false, sessionManager)
|
||
|
||
// If we have post hooks for after the first status check, run them now
|
||
if w.everAuthenticated.CAS(authenticationStatusFirstAuthentication, authenticationStatusFirstStatusRpcSuccessful) {
|
||
if downstreamWorkersFactory != nil {
|
||
w.downstreamWorkers, err = downstreamWorkersFactory(cancelCtx, w.LastStatusSuccess().WorkerId)
|
||
if err != nil {
|
||
event.WriteError(cancelCtx, op, err)
|
||
w.conf.ServerSideShutdownCh <- struct{}{}
|
||
return
|
||
}
|
||
}
|
||
for _, fn := range firstStatusCheckPostHooks {
|
||
if err := fn(cancelCtx, w); err != nil {
|
||
// If we can't verify status we can't be expected to behave
|
||
// properly so error and trigger shutdown
|
||
event.WriteError(cancelCtx, op, fmt.Errorf("error running first status check post hook: %w", err))
|
||
// We don't use a non-blocking select here to ensure that it
|
||
// happens; we should catch blocks in tests but we want to
|
||
// ensure the signal is being listened to
|
||
w.conf.ServerSideShutdownCh <- struct{}{}
|
||
return
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
// cleanupConnections walks all sessions and shuts down all proxy connections.
|
||
// After the local connections are terminated, they are requested to be marked
|
||
// close on the controller.
|
||
// Additionally, sessions without connections are cleaned up from the
|
||
// local worker's state.
|
||
//
|
||
// Use ignoreSessionState to ignore the state checks, this closes all
|
||
// connections, regardless of whether or not the session is still active.
|
||
func (w *Worker) cleanupConnections(cancelCtx context.Context, ignoreSessionState bool, sessionManager session.Manager) {
|
||
const op = "worker.(Worker).cleanupConnections"
|
||
closeInfo := make(map[string]string)
|
||
cleanSessionIds := make([]string, 0)
|
||
sessionManager.ForEachLocalSession(func(s session.Session) bool {
|
||
switch {
|
||
case ignoreSessionState,
|
||
s.GetStatus() == pbs.SESSIONSTATUS_SESSIONSTATUS_CANCELING,
|
||
s.GetStatus() == pbs.SESSIONSTATUS_SESSIONSTATUS_TERMINATED,
|
||
time.Until(s.GetExpiration()) < 0:
|
||
// Cancel connections without regard to individual connection
|
||
// state.
|
||
closedIds := s.CancelAllLocalConnections()
|
||
for _, connId := range closedIds {
|
||
closeInfo[connId] = s.GetId()
|
||
event.WriteSysEvent(cancelCtx, op, "terminated connection due to cancellation or expiration", "session_id", s.GetId(), "connection_id", connId)
|
||
}
|
||
|
||
// If the session is no longer valid and all connections
|
||
// are marked closed, clean up the session.
|
||
if len(closedIds) == 0 {
|
||
cleanSessionIds = append(cleanSessionIds, s.GetId())
|
||
}
|
||
|
||
default:
|
||
// Cancel connections *with* regard to individual connection
|
||
// state (ie: only ones that the controller has requested be
|
||
// terminated).
|
||
for _, connId := range s.CancelOpenLocalConnections() {
|
||
closeInfo[connId] = s.GetId()
|
||
event.WriteSysEvent(cancelCtx, op, "terminated connection due to cancellation or expiration", "session_id", s.GetId(), "connection_id", connId)
|
||
}
|
||
}
|
||
|
||
return true
|
||
})
|
||
|
||
// Note that we won't clean these from the info map until the
|
||
// next time we run this function
|
||
if len(closeInfo) > 0 {
|
||
// Call out to a helper to send the connection close requests to the
|
||
// controller, and set the close time. This functionality is shared with
|
||
// post-close functionality in the proxy handler.
|
||
_ = sessionManager.RequestCloseConnections(cancelCtx, closeInfo)
|
||
}
|
||
// Forget sessions where the session is expired/canceled and all
|
||
// connections are canceled and marked closed
|
||
sessionManager.DeleteLocalSession(cleanSessionIds)
|
||
}
|
||
|
||
func (w *Worker) lastSuccessfulStatusTime() time.Time {
|
||
lastStatus := w.LastStatusSuccess()
|
||
if lastStatus == nil {
|
||
return w.workerStartTime
|
||
}
|
||
|
||
return lastStatus.StatusTime
|
||
}
|
||
|
||
func (w *Worker) isPastGrace() (bool, time.Time, time.Duration) {
|
||
t := w.lastSuccessfulStatusTime()
|
||
u := w.conf.StatusGracePeriodDuration
|
||
v := time.Since(t)
|
||
return v > u, t, u
|
||
}
|