Todd Knight
d374ac6d4c
* Created host catalog service.
* Fixing uri generation for create.
* Use newly submitted static host catalog.
* Copying over tests from projects.
* Fix UpdateHostCatalogRequest merging proto.
* Properly use static host catalog prefixes in tests.
* Correct test to verify the expected uri and id prefix is set.
* Add test for unsetting descriptions.
* Correct bad spelling in comment.
* Tweaking variable names.
* Adding Stringer to the catalog type and setting the type on the response.
* Setting up the catalogType to contain more info regarding its type.
* Validate the type field in requests.
* Remove unused method.
* Comment describing invariants around types.
* Wiring in the repo into the static catalog handler.
* feature: Add CRUD operations for host catalogs to the go api library.
* Updated comments to the exported methods.
* fix: return the result of handlers.NotFoundError instead of just calling it.
* Fixing typos referencing just hosts instead of host catlogs.
* Update NewService returns an error and a non pointer type.
* Pull "org_id" and "project_id" into constants and the validation of them into the ValidateAncestors.
* Check errors for all Register*HandlerServer calls.
* fix: Remove left over reference that could cause a panic.
* fix: Changing "x := []string{}" to "var x []string"
* fix: Log errors in test cleanup.
* Changing the code to use google.golang.org/protobuf instead of the older github based protobuf library.
* Changing all t.Fatal checks to require.NoError calls.
* Changing unrecognized prefixes to Invalid Argument instead of Not Found.
* fix: toDbUpdateMask now returns error if it was unable to find any valid paths.
* Define CreatedTime, UpdatedTime, and Type at initialization time in toProto.
* Adding sdk test for unsetting a value.
* Require that project is created correctly before testing the catalog.
* Remove unused host catalog from test.
* Change a t.Fatal to a require.NoError that I missed earlier.
* Change shutdown error logging to t.Errorfs.
* Shorten validateX function names.
* Inline API responses.
* Add todo to make a new repo per request.
* Inline regex check for invalid id.
* Change stored repos into repo creating functions which satisfies ICU-223.
* Wrap proto comments to be under 80 characters long.
* Remove the exception on the read only fields that can be set in an Update request.
* Removing out of date comment.
* Use iam.TestScopes instead of making the project myself.
* Renaming files to be consistant with go test standards and resource naming standards.
* Remove TODO related to a task completed in an earlier commit.
* Fix the previous commit which removed the wrong TODO.
86 lines
2.5 KiB
Go
86 lines
2.5 KiB
Go
package scopes_test
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/watchtower/api"
|
|
"github.com/hashicorp/watchtower/api/scopes"
|
|
"github.com/hashicorp/watchtower/internal/servers/controller"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestProjects_Crud(t *testing.T) {
|
|
tc := controller.NewTestController(t, nil)
|
|
defer tc.Shutdown()
|
|
|
|
client := tc.Client()
|
|
org := &scopes.Organization{
|
|
Client: client,
|
|
}
|
|
|
|
checkProject := func(step string, p *scopes.Project, apiErr *api.Error, err error, wantedName string) {
|
|
assert := assert.New(t)
|
|
assert.NoError(err, step)
|
|
assert.Nil(apiErr, step)
|
|
assert.NotNil(p, "returned project", step)
|
|
gotName := ""
|
|
if p.Name != nil {
|
|
gotName = *p.Name
|
|
}
|
|
assert.Equal(wantedName, gotName, step)
|
|
}
|
|
|
|
p, apiErr, err := org.CreateProject(tc.Context(), &scopes.Project{Name: api.String("foo")})
|
|
checkProject("create", p, apiErr, err, "foo")
|
|
|
|
p, apiErr, err = org.ReadProject(tc.Context(), &scopes.Project{Id: p.Id})
|
|
checkProject("read", p, apiErr, err, "foo")
|
|
|
|
p = &scopes.Project{Id: p.Id}
|
|
p.Name = api.String("bar")
|
|
p, apiErr, err = org.UpdateProject(tc.Context(), p)
|
|
checkProject("update", p, apiErr, err, "bar")
|
|
|
|
p = &scopes.Project{Id: p.Id}
|
|
p.SetDefault("name")
|
|
p, apiErr, err = org.UpdateProject(tc.Context(), p)
|
|
checkProject("update, unset name", p, apiErr, err, "")
|
|
|
|
existed, apiErr, err := org.DeleteProject(tc.Context(), p)
|
|
assert.NoError(t, err)
|
|
assert.True(t, existed, "Expected existing project when deleted, but it wasn't.")
|
|
|
|
existed, apiErr, err = org.DeleteProject(tc.Context(), p)
|
|
assert.NoError(t, err)
|
|
assert.False(t, existed, "Expected project to not exist when deleted, but it did.")
|
|
}
|
|
|
|
// TODO: Get better coverage for expected errors and error formats.
|
|
func TestProject_Errors(t *testing.T) {
|
|
assert := assert.New(t)
|
|
tc := controller.NewTestController(t, nil)
|
|
defer tc.Shutdown()
|
|
ctx := tc.Context()
|
|
|
|
client := tc.Client()
|
|
org := &scopes.Organization{
|
|
Client: client,
|
|
}
|
|
createdProj, apiErr, err := org.CreateProject(ctx, &scopes.Project{})
|
|
assert.NoError(err)
|
|
assert.NotNil(createdProj)
|
|
assert.Nil(apiErr)
|
|
|
|
_, apiErr, err = org.ReadProject(ctx, &scopes.Project{Id: "p_doesntexis"})
|
|
assert.NoError(err)
|
|
// TODO: Should this be nil instead of just a Project that has no values set
|
|
assert.NotNil(apiErr)
|
|
assert.EqualValues(*apiErr.Status, http.StatusNotFound)
|
|
|
|
_, apiErr, err = org.ReadProject(ctx, &scopes.Project{Id: "invalid id"})
|
|
assert.NoError(err)
|
|
assert.NotNil(apiErr)
|
|
assert.EqualValues(*apiErr.Status, http.StatusBadRequest)
|
|
}
|