Hugo
0bee55aa19
If an update call was made to a target that removed an address, for a target that already did not have an address, the incorrect number of rows updated was being reported. During the update the target's version was correctly being updated, resulting in one row being updated. However then the delete call would result in zero rows being deleted, since there was no address associated with the target, and this would replace the value for the returned rowsUpdated. This resulted in the target service thinking that no update happened, and it would report an error.
696 lines
26 KiB
Go
696 lines
26 KiB
Go
package targets_test
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/boundary/api"
|
|
"github.com/hashicorp/boundary/api/credentiallibraries"
|
|
"github.com/hashicorp/boundary/api/credentials"
|
|
"github.com/hashicorp/boundary/api/credentialstores"
|
|
"github.com/hashicorp/boundary/api/hostcatalogs"
|
|
"github.com/hashicorp/boundary/api/hosts"
|
|
"github.com/hashicorp/boundary/api/hostsets"
|
|
"github.com/hashicorp/boundary/api/roles"
|
|
"github.com/hashicorp/boundary/api/targets"
|
|
"github.com/hashicorp/boundary/internal/credential/vault"
|
|
"github.com/hashicorp/boundary/internal/daemon/controller"
|
|
"github.com/hashicorp/boundary/internal/iam"
|
|
"github.com/hashicorp/boundary/internal/target/tcp"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
_ "github.com/hashicorp/boundary/internal/daemon/controller/handlers/targets/tcp"
|
|
)
|
|
|
|
func TestHostSetASD(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
tc := controller.NewTestController(t, nil)
|
|
defer tc.Shutdown()
|
|
|
|
token := tc.Token()
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(token.UserId))
|
|
client := tc.Client().Clone()
|
|
client.SetToken(token.Token)
|
|
|
|
hc, err := hostcatalogs.NewClient(client).Create(tc.Context(), "static", proj.GetPublicId())
|
|
require.NoError(err)
|
|
|
|
hSetClient := hostsets.NewClient(client)
|
|
hSet, err := hSetClient.Create(tc.Context(), hc.Item.Id)
|
|
require.NoError(err)
|
|
require.NotNil(hSet)
|
|
hSet2, err := hSetClient.Create(tc.Context(), hc.Item.Id)
|
|
require.NoError(err)
|
|
require.NotNil(hSet2)
|
|
|
|
tarClient := targets.NewClient(client)
|
|
tar, err := tarClient.Create(tc.Context(), "tcp", proj.GetPublicId(), targets.WithName("foo"), targets.WithTcpTargetDefaultPort(2))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.Empty(tar.Item.HostSourceIds)
|
|
|
|
tar, err = tarClient.AddHostSources(tc.Context(), tar.Item.Id, tar.Item.Version, []string{hSet.Item.Id})
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.ElementsMatch(tar.Item.HostSourceIds, []string{hSet.Item.Id})
|
|
|
|
tar, err = tarClient.SetHostSources(tc.Context(), tar.Item.Id, tar.Item.Version, []string{hSet2.Item.Id})
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.ElementsMatch(tar.Item.HostSourceIds, []string{hSet2.Item.Id})
|
|
|
|
tar, err = tarClient.RemoveHostSources(tc.Context(), tar.Item.Id, tar.Item.Version, []string{hSet2.Item.Id})
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.Empty(tar.Item.HostSourceIds)
|
|
}
|
|
|
|
func TestCredentialSourcesASD(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
tc := controller.NewTestController(t, nil)
|
|
defer tc.Shutdown()
|
|
vaultServ := vault.NewTestVaultServer(t, vault.WithTestVaultTLS(vault.TestNoTLS))
|
|
_, vaultTok := vaultServ.CreateToken(t)
|
|
|
|
token := tc.Token()
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(token.UserId))
|
|
client := tc.Client().Clone()
|
|
client.SetToken(token.Token)
|
|
|
|
csVault, err := credentialstores.NewClient(client).Create(tc.Context(), "vault", proj.GetPublicId(),
|
|
credentialstores.WithVaultCredentialStoreAddress(vaultServ.Addr), credentialstores.WithVaultCredentialStoreToken(vaultTok))
|
|
require.NoError(err)
|
|
require.NotNil(csVault)
|
|
|
|
lClient := credentiallibraries.NewClient(client)
|
|
lib1, err := lClient.Create(tc.Context(), csVault.Item.Id, credentiallibraries.WithVaultCredentialLibraryPath("something1"))
|
|
require.NoError(err)
|
|
require.NotNil(lib1)
|
|
|
|
lib2, err := lClient.Create(tc.Context(), csVault.Item.Id, credentiallibraries.WithVaultCredentialLibraryPath("something2"))
|
|
require.NoError(err)
|
|
require.NotNil(lib2)
|
|
|
|
csStatic, err := credentialstores.NewClient(client).Create(tc.Context(), "static", proj.GetPublicId())
|
|
require.NoError(err)
|
|
require.NotNil(csStatic)
|
|
|
|
cClient := credentials.NewClient(client)
|
|
cOpts := []credentials.Option{credentials.WithUsernamePasswordCredentialUsername("user"), credentials.WithUsernamePasswordCredentialPassword("pass")}
|
|
cred, err := cClient.Create(tc.Context(), "username_password", csStatic.Item.Id, cOpts...)
|
|
require.NoError(err)
|
|
require.NotNil(cred)
|
|
|
|
tarClient := targets.NewClient(client)
|
|
tar, err := tarClient.Create(tc.Context(), "tcp", proj.GetPublicId(), targets.WithName("foo"), targets.WithTcpTargetDefaultPort(2))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.Empty(tar.Item.BrokeredCredentialSourceIds)
|
|
|
|
// Add first Vault library
|
|
tar, err = tarClient.AddCredentialSources(tc.Context(), tar.Item.Id, tar.Item.Version,
|
|
targets.WithBrokeredCredentialSourceIds([]string{lib1.Item.Id}))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSourceIds, []string{lib1.Item.Id})
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: lib1.Item.Id,
|
|
CredentialStoreId: csVault.Item.Id,
|
|
},
|
|
})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSourceIds, []string{lib1.Item.Id})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: lib1.Item.Id,
|
|
CredentialStoreId: csVault.Item.Id,
|
|
},
|
|
})
|
|
|
|
// Set second Vault library and a static credential
|
|
tar, err = tarClient.SetCredentialSources(tc.Context(), tar.Item.Id, tar.Item.Version,
|
|
targets.WithBrokeredCredentialSourceIds([]string{lib2.Item.Id, cred.Item.Id}))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSourceIds, []string{lib2.Item.Id, cred.Item.Id})
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: lib2.Item.Id,
|
|
CredentialStoreId: csVault.Item.Id,
|
|
},
|
|
{
|
|
Id: cred.Item.Id,
|
|
CredentialStoreId: csStatic.Item.Id,
|
|
},
|
|
})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSourceIds, []string{lib2.Item.Id, cred.Item.Id})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: lib2.Item.Id,
|
|
CredentialStoreId: csVault.Item.Id,
|
|
},
|
|
{
|
|
Id: cred.Item.Id,
|
|
CredentialStoreId: csStatic.Item.Id,
|
|
},
|
|
})
|
|
// Remove second Vault library
|
|
tar, err = tarClient.RemoveCredentialSources(tc.Context(), tar.Item.Id, tar.Item.Version,
|
|
targets.WithBrokeredCredentialSourceIds([]string{lib2.Item.Id}))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSourceIds, []string{cred.Item.Id})
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: cred.Item.Id,
|
|
CredentialStoreId: csStatic.Item.Id,
|
|
},
|
|
})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSourceIds, []string{cred.Item.Id})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: cred.Item.Id,
|
|
CredentialStoreId: csStatic.Item.Id,
|
|
},
|
|
})
|
|
|
|
// Set empty credential sources
|
|
tar, err = tarClient.SetCredentialSources(tc.Context(), tar.Item.Id, tar.Item.Version,
|
|
targets.WithBrokeredCredentialSourceIds([]string{}))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.Empty(tar.Item.BrokeredCredentialSourceIds)
|
|
assert.Empty(tar.Item.ApplicationCredentialSourceIds)
|
|
}
|
|
|
|
func TestDeprecatedCredentialSourcesASD(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
tc := controller.NewTestController(t, nil)
|
|
defer tc.Shutdown()
|
|
vaultServ := vault.NewTestVaultServer(t, vault.WithTestVaultTLS(vault.TestNoTLS))
|
|
_, vaultTok := vaultServ.CreateToken(t)
|
|
|
|
token := tc.Token()
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(token.UserId))
|
|
client := tc.Client().Clone()
|
|
client.SetToken(token.Token)
|
|
|
|
csVault, err := credentialstores.NewClient(client).Create(tc.Context(), "vault", proj.GetPublicId(),
|
|
credentialstores.WithVaultCredentialStoreAddress(vaultServ.Addr), credentialstores.WithVaultCredentialStoreToken(vaultTok))
|
|
require.NoError(err)
|
|
require.NotNil(csVault)
|
|
|
|
lClient := credentiallibraries.NewClient(client)
|
|
lib1, err := lClient.Create(tc.Context(), csVault.Item.Id, credentiallibraries.WithVaultCredentialLibraryPath("something1"))
|
|
require.NoError(err)
|
|
require.NotNil(lib1)
|
|
|
|
lib2, err := lClient.Create(tc.Context(), csVault.Item.Id, credentiallibraries.WithVaultCredentialLibraryPath("something2"))
|
|
require.NoError(err)
|
|
require.NotNil(lib2)
|
|
|
|
csStatic, err := credentialstores.NewClient(client).Create(tc.Context(), "static", proj.GetPublicId())
|
|
require.NoError(err)
|
|
require.NotNil(csStatic)
|
|
|
|
cClient := credentials.NewClient(client)
|
|
cOpts := []credentials.Option{credentials.WithUsernamePasswordCredentialUsername("user"), credentials.WithUsernamePasswordCredentialPassword("pass")}
|
|
cred, err := cClient.Create(tc.Context(), "username_password", csStatic.Item.Id, cOpts...)
|
|
require.NoError(err)
|
|
require.NotNil(cred)
|
|
|
|
tarClient := targets.NewClient(client)
|
|
tar, err := tarClient.Create(tc.Context(), "tcp", proj.GetPublicId(), targets.WithName("foo"), targets.WithTcpTargetDefaultPort(2))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.Empty(tar.Item.BrokeredCredentialSourceIds)
|
|
|
|
// Add first Vault library
|
|
tar, err = tarClient.AddCredentialSources(tc.Context(), tar.Item.Id, tar.Item.Version,
|
|
targets.WithApplicationCredentialSourceIds([]string{lib1.Item.Id}))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSourceIds, []string{lib1.Item.Id})
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: lib1.Item.Id,
|
|
CredentialStoreId: csVault.Item.Id,
|
|
},
|
|
})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSourceIds, []string{lib1.Item.Id})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: lib1.Item.Id,
|
|
CredentialStoreId: csVault.Item.Id,
|
|
},
|
|
})
|
|
|
|
// Set second Vault library and a static credential
|
|
tar, err = tarClient.SetCredentialSources(tc.Context(), tar.Item.Id, tar.Item.Version,
|
|
targets.WithApplicationCredentialSourceIds([]string{lib2.Item.Id, cred.Item.Id}))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSourceIds, []string{lib2.Item.Id, cred.Item.Id})
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: lib2.Item.Id,
|
|
CredentialStoreId: csVault.Item.Id,
|
|
},
|
|
{
|
|
Id: cred.Item.Id,
|
|
CredentialStoreId: csStatic.Item.Id,
|
|
},
|
|
})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSourceIds, []string{lib2.Item.Id, cred.Item.Id})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: lib2.Item.Id,
|
|
CredentialStoreId: csVault.Item.Id,
|
|
},
|
|
{
|
|
Id: cred.Item.Id,
|
|
CredentialStoreId: csStatic.Item.Id,
|
|
},
|
|
})
|
|
// Remove second Vault library
|
|
tar, err = tarClient.RemoveCredentialSources(tc.Context(), tar.Item.Id, tar.Item.Version,
|
|
targets.WithApplicationCredentialSourceIds([]string{lib2.Item.Id}))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSourceIds, []string{cred.Item.Id})
|
|
assert.ElementsMatch(tar.Item.BrokeredCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: cred.Item.Id,
|
|
CredentialStoreId: csStatic.Item.Id,
|
|
},
|
|
})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSourceIds, []string{cred.Item.Id})
|
|
assert.ElementsMatch(tar.Item.ApplicationCredentialSources, []*targets.CredentialSource{
|
|
{
|
|
Id: cred.Item.Id,
|
|
CredentialStoreId: csStatic.Item.Id,
|
|
},
|
|
})
|
|
|
|
// Set empty credential sources
|
|
tar, err = tarClient.SetCredentialSources(tc.Context(), tar.Item.Id, tar.Item.Version,
|
|
targets.WithApplicationCredentialSourceIds([]string{}))
|
|
require.NoError(err)
|
|
require.NotNil(tar)
|
|
assert.Empty(tar.Item.BrokeredCredentialSourceIds)
|
|
assert.Empty(tar.Item.ApplicationCredentialSourceIds)
|
|
}
|
|
|
|
func TestList(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
tc := controller.NewTestController(t, nil)
|
|
defer tc.Shutdown()
|
|
|
|
client := tc.Client()
|
|
token := tc.Token()
|
|
client.SetToken(token.Token)
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(token.UserId))
|
|
|
|
// Add unpriv user to default role in new project. Also add create grant as
|
|
// it will be needed later in the test and no-op for listing visibility.
|
|
rls, err := roles.NewClient(client).List(tc.Context(), proj.GetPublicId())
|
|
require.NoError(err)
|
|
var defaultRoleId string
|
|
for _, rl := range rls.Items {
|
|
if strings.Contains(rl.Name, "Default") {
|
|
defaultRoleId = rl.Id
|
|
break
|
|
}
|
|
}
|
|
require.NotEmpty(defaultRoleId)
|
|
unprivToken := tc.UnprivilegedToken()
|
|
iam.TestUserRole(t, tc.DbConn(), defaultRoleId, unprivToken.UserId)
|
|
iam.TestRoleGrant(t, tc.DbConn(), defaultRoleId, "type=target;actions=create")
|
|
iam.TestRoleGrant(t, tc.DbConn(), defaultRoleId, "id=*;type=target;actions=no-op")
|
|
|
|
client.SetToken(unprivToken.Token)
|
|
tarClient := targets.NewClient(client)
|
|
ul, err := tarClient.List(tc.Context(), proj.GetPublicId())
|
|
require.NoError(err)
|
|
assert.Empty(ul.Items)
|
|
|
|
var expected []*targets.Target
|
|
for i := 0; i < 10; i++ {
|
|
expected = append(expected, &targets.Target{Name: fmt.Sprint(i)})
|
|
}
|
|
|
|
tcr, err := tarClient.Create(tc.Context(), "tcp", proj.GetPublicId(), targets.WithName(expected[0].Name), targets.WithTcpTargetDefaultPort(2))
|
|
require.NoError(err)
|
|
expected[0] = tcr.Item
|
|
|
|
ul, err = tarClient.List(tc.Context(), proj.GetPublicId())
|
|
require.NoError(err)
|
|
assert.ElementsMatch(comparableSlice(expected[:1]), comparableSlice(ul.Items))
|
|
|
|
for i := 1; i < 10; i++ {
|
|
tcr, err = tarClient.Create(
|
|
tc.Context(),
|
|
"tcp",
|
|
proj.GetPublicId(),
|
|
targets.WithName(expected[i].Name),
|
|
targets.WithTcpTargetDefaultPort(uint32(i)),
|
|
)
|
|
require.NoError(err)
|
|
expected[i] = tcr.Item
|
|
}
|
|
filterItem := expected[3]
|
|
ul, err = tarClient.List(tc.Context(), proj.GetPublicId())
|
|
require.NoError(err)
|
|
assert.ElementsMatch(comparableSlice(expected), comparableSlice(ul.Items))
|
|
|
|
ul, err = tarClient.List(tc.Context(), proj.GetPublicId(),
|
|
targets.WithFilter(fmt.Sprintf(`"/item/id"==%q`, filterItem.Id)))
|
|
require.NoError(err)
|
|
assert.Len(ul.Items, 1)
|
|
assert.Equal(filterItem.Id, ul.Items[0].Id)
|
|
|
|
filterstr := fmt.Sprintf(`"/item/attributes/default_port"==%d`, uint32(filterItem.Attributes["default_port"].(float64)))
|
|
ul, err = tarClient.List(tc.Context(), proj.GetPublicId(),
|
|
targets.WithFilter(filterstr))
|
|
require.NoError(err)
|
|
assert.Len(ul.Items, 1)
|
|
assert.Equal(filterItem.Id, ul.Items[0].Id)
|
|
}
|
|
|
|
func TestTarget_AddressMutualExclusiveRelationship(t *testing.T) {
|
|
tc := controller.NewTestController(t, nil)
|
|
t.Cleanup(tc.Shutdown)
|
|
|
|
client := tc.Client()
|
|
at := tc.Token()
|
|
client.SetToken(at.Token)
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(at.UserId))
|
|
tClient := targets.NewClient(client)
|
|
|
|
// Create target with a network address association
|
|
targetResp, err := tClient.Create(tc.Context(), "tcp", proj.GetPublicId(),
|
|
targets.WithName("test-address"), targets.WithAddress("localhost"), targets.WithTcpTargetDefaultPort(22))
|
|
require.NoError(t, err)
|
|
require.NotNil(t, targetResp)
|
|
require.Equal(t, "localhost", targetResp.GetItem().Address)
|
|
|
|
// Setup host catalog, host set, & host resources
|
|
hc, err := hostcatalogs.NewClient(client).Create(tc.Context(), "static", proj.GetPublicId())
|
|
require.NoError(t, err)
|
|
require.NotNil(t, hc)
|
|
hs, err := hostsets.NewClient(client).Create(tc.Context(), hc.Item.Id)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, hs)
|
|
h, err := hosts.NewClient(client).Create(tc.Context(), hc.Item.Id, hosts.WithStaticHostAddress("localhost"))
|
|
require.NoError(t, err)
|
|
require.NotNil(t, h)
|
|
hUpdate, err := hostsets.NewClient(client).AddHosts(tc.Context(), hs.Item.Id, hs.Item.Version, []string{h.GetItem().Id})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, hUpdate)
|
|
|
|
// Expect error when associating a host source to the target with a direct network address association
|
|
targetId := targetResp.GetItem().Id
|
|
version := targetResp.GetItem().Version
|
|
updateResp, err := tClient.AddHostSources(tc.Context(), targetId, version, []string{hs.Item.Id})
|
|
require.Error(t, err)
|
|
require.Nil(t, updateResp)
|
|
apiErr := api.AsServerError(err)
|
|
require.NotNil(t, apiErr)
|
|
require.Equal(t, http.StatusBadRequest, apiErr.Response().StatusCode())
|
|
|
|
// Remove direct network address association. Successfully add a host source to target.
|
|
targetResp, err = tClient.Update(tc.Context(), targetId, version, targets.DefaultAddress())
|
|
require.NoError(t, err)
|
|
require.NotNil(t, targetResp)
|
|
require.Empty(t, targetResp.GetItem().Address)
|
|
version = targetResp.GetItem().Version
|
|
updateResp, err = tClient.AddHostSources(tc.Context(), targetId, version, []string{hs.Item.Id})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, updateResp)
|
|
require.Empty(t, updateResp.GetItem().Address)
|
|
require.Equal(t, []string{hs.Item.Id}, updateResp.GetItem().HostSourceIds)
|
|
}
|
|
|
|
func TestTarget_HostSourceMutualExclusiveRelationship(t *testing.T) {
|
|
tc := controller.NewTestController(t, nil)
|
|
t.Cleanup(tc.Shutdown)
|
|
|
|
client := tc.Client()
|
|
at := tc.Token()
|
|
client.SetToken(at.Token)
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(at.UserId))
|
|
tClient := targets.NewClient(client)
|
|
|
|
// Setup host catalog, host set, & host resources
|
|
hc, err := hostcatalogs.NewClient(client).Create(tc.Context(), "static", proj.GetPublicId())
|
|
require.NoError(t, err)
|
|
require.NotNil(t, hc)
|
|
hs, err := hostsets.NewClient(client).Create(tc.Context(), hc.Item.Id)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, hs)
|
|
h, err := hosts.NewClient(client).Create(tc.Context(), hc.Item.Id, hosts.WithStaticHostAddress("localhost"))
|
|
require.NoError(t, err)
|
|
require.NotNil(t, h)
|
|
hUpdate, err := hostsets.NewClient(client).AddHosts(tc.Context(), hs.Item.Id, hs.Item.Version, []string{h.GetItem().Id})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, hUpdate)
|
|
|
|
// Create target without a network address association
|
|
targetResp, err := tClient.Create(tc.Context(), "tcp", proj.GetPublicId(),
|
|
targets.WithName("test-host-source"), targets.WithTcpTargetDefaultPort(22))
|
|
require.NoError(t, err)
|
|
require.NotNil(t, targetResp)
|
|
require.Empty(t, targetResp.GetItem().Address)
|
|
|
|
// Expect error when associating a address to the target with a host source association
|
|
targetId := targetResp.GetItem().Id
|
|
version := targetResp.GetItem().Version
|
|
updateResp, err := tClient.AddHostSources(tc.Context(), targetId, version, []string{hs.Item.Id})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, updateResp)
|
|
require.Empty(t, updateResp.GetItem().Address)
|
|
require.Equal(t, []string{hs.Item.Id}, updateResp.GetItem().HostSourceIds)
|
|
version = updateResp.GetItem().Version
|
|
updateResp, err = tClient.Update(tc.Context(), targetId, version, targets.WithAddress("localhost"))
|
|
require.Error(t, err)
|
|
require.Nil(t, updateResp)
|
|
apiErr := api.AsServerError(err)
|
|
require.NotNil(t, apiErr)
|
|
require.Equal(t, http.StatusBadRequest, apiErr.Response().StatusCode())
|
|
|
|
// Remove host source association. Successfully assign a network address to the target.
|
|
updateResp, err = tClient.RemoveHostSources(tc.Context(), targetId, version, []string{hs.Item.Id})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, updateResp)
|
|
require.Empty(t, updateResp.GetItem().HostSourceIds)
|
|
version = updateResp.GetItem().Version
|
|
updateResp, err = tClient.Update(tc.Context(), targetId, version, targets.WithAddress("localhost"))
|
|
require.NoError(t, err)
|
|
require.NotNil(t, updateResp)
|
|
require.Equal(t, "localhost", updateResp.GetItem().Address)
|
|
require.Empty(t, updateResp.GetItem().HostSourceIds)
|
|
}
|
|
|
|
func TestCreateTarget_DirectlyAttachedAddress(t *testing.T) {
|
|
tc := controller.NewTestController(t, nil)
|
|
t.Cleanup(tc.Shutdown)
|
|
|
|
client := tc.Client()
|
|
at := tc.Token()
|
|
client.SetToken(at.Token)
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(at.UserId))
|
|
tClient := targets.NewClient(client)
|
|
|
|
tests := []struct {
|
|
name string
|
|
address string
|
|
}{
|
|
{
|
|
name: "target-ipv4-address",
|
|
address: "127.0.0.1",
|
|
},
|
|
{
|
|
name: "target-dns-address",
|
|
address: "null",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
createResp, err := tClient.Create(tc.Context(), "tcp", proj.PublicId,
|
|
targets.WithName(tt.name), targets.WithAddress(tt.address), targets.WithTcpTargetDefaultPort(22))
|
|
require.NoError(err)
|
|
require.NotNil(createResp)
|
|
assert.Equal(tt.address, createResp.GetItem().Address)
|
|
|
|
targetId := createResp.GetItem().Id
|
|
version := createResp.GetItem().Version
|
|
readResp, err := tClient.Read(tc.Context(), targetId)
|
|
require.NoError(err)
|
|
require.NotNil(readResp)
|
|
assert.Equal(tt.address, readResp.GetItem().Address)
|
|
|
|
updateResp, err := tClient.Update(tc.Context(), targetId, version, targets.DefaultAddress())
|
|
require.NoError(err)
|
|
require.NotNil(updateResp)
|
|
assert.Empty(updateResp.GetItem().Address)
|
|
|
|
readResp, err = tClient.Read(tc.Context(), targetId)
|
|
require.NoError(err)
|
|
require.NotNil(readResp)
|
|
assert.Empty(readResp.GetItem().Address)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestUpdateTarget_DeleteAddress(t *testing.T) {
|
|
tc := controller.NewTestController(t, nil)
|
|
t.Cleanup(tc.Shutdown)
|
|
|
|
client := tc.Client()
|
|
at := tc.Token()
|
|
client.SetToken(at.Token)
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(at.UserId))
|
|
tClient := targets.NewClient(client)
|
|
|
|
assert, require := assert.New(t), require.New(t)
|
|
|
|
// Create Target with address
|
|
addr := "127.0.0.1"
|
|
createResp, err := tClient.Create(tc.Context(), "tcp", proj.PublicId,
|
|
targets.WithName("test_target_addr_delete"), targets.WithAddress(addr), targets.WithTcpTargetDefaultPort(22))
|
|
require.NoError(err)
|
|
require.NotNil(createResp)
|
|
assert.Equal(addr, createResp.GetItem().Address)
|
|
|
|
// Update to delete address (set to null)
|
|
updateResp, err := tClient.Update(tc.Context(), createResp.Item.Id, createResp.Item.Version, targets.DefaultAddress())
|
|
require.NoError(err)
|
|
require.NotNil(updateResp)
|
|
assert.Empty(updateResp.GetItem().Address)
|
|
|
|
// Do it again with same version, should error
|
|
_, err = tClient.Update(tc.Context(), createResp.Item.Id, createResp.Item.Version, targets.DefaultAddress())
|
|
require.Error(err)
|
|
|
|
// Do it again with the correct version, ensure this is not an error.
|
|
secondUpdateResp, err := tClient.Update(tc.Context(), createResp.Item.Id, updateResp.Item.Version, targets.DefaultAddress())
|
|
require.NoError(err)
|
|
require.NotNil(secondUpdateResp)
|
|
assert.Empty(secondUpdateResp.GetItem().Address)
|
|
|
|
assert.NotEqual(updateResp.Item.Version, secondUpdateResp.Item.Version)
|
|
}
|
|
|
|
func comparableSlice(in []*targets.Target) []targets.Target {
|
|
var filtered []targets.Target
|
|
for _, i := range in {
|
|
p := targets.Target{
|
|
Id: i.Id,
|
|
Name: i.Name,
|
|
Description: i.Description,
|
|
CreatedTime: i.CreatedTime,
|
|
UpdatedTime: i.UpdatedTime,
|
|
}
|
|
filtered = append(filtered, p)
|
|
}
|
|
return filtered
|
|
}
|
|
|
|
func TestCrud(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
tc := controller.NewTestController(t, nil)
|
|
defer tc.Shutdown()
|
|
|
|
client := tc.Client()
|
|
token := tc.Token()
|
|
client.SetToken(token.Token)
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(token.UserId))
|
|
|
|
checkResource := func(t *testing.T, step string, h *targets.Target, err error, wantedName string, wantVersion uint32) {
|
|
t.Helper()
|
|
require.NoError(err, step)
|
|
assert.NotNil(h, "returned no resource", step)
|
|
gotName := ""
|
|
if h.Name != "" {
|
|
gotName = h.Name
|
|
}
|
|
assert.Equal(wantedName, gotName, step)
|
|
assert.Equal(wantVersion, h.Version)
|
|
}
|
|
|
|
tarClient := targets.NewClient(client)
|
|
|
|
tar, err := tarClient.Create(tc.Context(), "tcp", proj.GetPublicId(), targets.WithName("foo"), targets.WithTcpTargetDefaultPort(2))
|
|
checkResource(t, "create", tar.Item, err, "foo", 1)
|
|
|
|
tar, err = tarClient.Read(tc.Context(), tar.Item.Id)
|
|
checkResource(t, "read", tar.Item, err, "foo", 1)
|
|
|
|
tar, err = tarClient.Update(tc.Context(), tar.Item.Id, tar.Item.Version, targets.WithName("bar"))
|
|
checkResource(t, "update", tar.Item, err, "bar", 2)
|
|
|
|
_, err = tarClient.Delete(tc.Context(), tar.Item.Id)
|
|
assert.NoError(err)
|
|
|
|
_, err = tarClient.Delete(tc.Context(), tar.Item.Id)
|
|
assert.Error(err)
|
|
apiErr := api.AsServerError(err)
|
|
assert.NotNil(apiErr)
|
|
assert.EqualValues(http.StatusNotFound, apiErr.Response().StatusCode())
|
|
}
|
|
|
|
func TestSet_Errors(t *testing.T) {
|
|
assert, require := assert.New(t), require.New(t)
|
|
tc := controller.NewTestController(t, nil)
|
|
defer tc.Shutdown()
|
|
|
|
client := tc.Client()
|
|
token := tc.Token()
|
|
client.SetToken(token.Token)
|
|
_, proj := iam.TestScopes(t, tc.IamRepo(), iam.WithUserId(token.UserId))
|
|
|
|
tarClient := targets.NewClient(client)
|
|
|
|
tar, err := tarClient.Create(tc.Context(), "tcp", proj.GetPublicId(), targets.WithName("foo"), targets.WithTcpTargetDefaultPort(2))
|
|
require.NoError(err)
|
|
assert.NotNil(tar)
|
|
|
|
// A malformed id is processed as the id and not a different path to the api.
|
|
_, err = tarClient.Read(tc.Context(), fmt.Sprintf("%s/../", tar.Item.Id))
|
|
require.Error(err)
|
|
apiErr := api.AsServerError(err)
|
|
require.NotNil(apiErr)
|
|
assert.EqualValues(http.StatusBadRequest, apiErr.Response().StatusCode())
|
|
require.Len(apiErr.Details.RequestFields, 1)
|
|
assert.Equal(apiErr.Details.RequestFields[0].Name, "id")
|
|
|
|
// Updating the wrong version should fail.
|
|
_, err = tarClient.Update(tc.Context(), tar.Item.Id, 73, targets.WithName("anything"))
|
|
require.Error(err)
|
|
apiErr = api.AsServerError(err)
|
|
assert.NotNil(apiErr)
|
|
assert.EqualValues(http.StatusNotFound, apiErr.Response().StatusCode())
|
|
|
|
tar, err = tarClient.Create(tc.Context(), "tcp", proj.GetPublicId(), targets.WithName("foo"))
|
|
require.Error(err)
|
|
apiErr = api.AsServerError(err)
|
|
assert.NotNil(apiErr)
|
|
assert.Nil(tar)
|
|
|
|
_, err = tarClient.Read(tc.Context(), tcp.TargetPrefix+"_doesntexis")
|
|
require.Error(err)
|
|
apiErr = api.AsServerError(err)
|
|
assert.NotNil(apiErr)
|
|
assert.EqualValues(http.StatusNotFound, apiErr.Response().StatusCode())
|
|
|
|
_, err = tarClient.Read(tc.Context(), "invalid id")
|
|
require.Error(err)
|
|
apiErr = api.AsServerError(err)
|
|
assert.NotNil(apiErr)
|
|
assert.EqualValues(http.StatusBadRequest, apiErr.Response().StatusCode())
|
|
}
|