Files
threshold/internal/db/schema/manager_example_test.go
T
Timothy Messier 79866a287f feat(schema): Add support for migration hooks
This adds the ability to define hooks that will run prior to a schema
migration. The hooks should only be used when a migration would fail due
to data being in an invalid state, likely due to a bug in the previous
schema definition. For example if a column was missing a constraint, and
a new migration is attempting to add the constraint, there might already
be values that violate the new constraint. In such cases, we would want
the user to make a decision to address the data, and need to provide
them with details about what data is problematic in case they want to
manually address the problem. To help the user, if there is a sane way
to address the data, we should provide an option to automatically
"repair" the data, allowing the migration to continue. However, this
still should be an explicit opt-in from the user, and we need to clearly
describe what the repair option would do to the user so they understand
the consequences of opting in.

To accomplish this each migration can be provided a hook that contains a
CheckFunc, RepairFunc, and RepairDescription. These functions must
operate at the point-in-time of the migration immediately preceding the
current migration, as as such they should not use and domain packages or
repositories, instead they should use direct sql with the sql library.
The description is used to explain what the RepairFunc will do.

Hooks should be defined in `internal/db/schema/migrations/oss/oss.go`
and registered with the schema edition.

See the example in `internal/db/schema/manager_example_test.go` for more
details.
2022-08-22 12:15:20 -07:00

182 lines
4.3 KiB
Go

package schema_test
import (
"context"
"database/sql"
"fmt"
"log"
"strings"
"github.com/hashicorp/boundary/internal/db/common"
"github.com/hashicorp/boundary/internal/db/schema"
"github.com/hashicorp/boundary/internal/db/schema/internal/edition"
"github.com/hashicorp/boundary/internal/db/schema/migration"
"github.com/hashicorp/boundary/testing/dbtest"
)
func ExampleManager_hooks() {
ctx := context.Background()
dialect := dbtest.Postgres
c, u, _, err := dbtest.StartUsingTemplate(dialect, dbtest.WithTemplate(dbtest.Template1))
defer c()
d, err := common.SqlOpen(dialect, u)
if err != nil {
log.Fatalf(err.Error())
}
editions := edition.Editions{
{
Name: "hooks_example",
Dialect: schema.Postgres,
Migrations: migration.Migrations{
1: migration.Migration{
Edition: "hooks_example",
Version: 1,
Statements: []byte(`
create table foo (
id bigint generated always as identity primary key,
public_id text,
name text
);
-- Not a normal thing to have in a migration
-- but this is done to put "invalid" data
-- into a table, that will then have a constraint added
-- in a future migration.
insert into foo
(public_id, name)
values
(null, 'Alice'),
(null, 'Bob'),
('foo_cathy', 'Cathy');
`),
},
2: migration.Migration{
Edition: "hooks_example",
Version: 2,
Statements: []byte(`
-- this would fail if data is not updated first
alter table foo
alter column public_id
set not null;
`),
PreHook: &migration.Hook{
CheckFunc: func(ctx context.Context, tx *sql.Tx) (migration.Problems, error) {
rows, err := tx.QueryContext(
ctx,
`select
id, name
from foo
where
public_id is null`,
)
if err != nil {
return nil, err
}
invalid := make([]string, 0)
for rows.Next() {
var id int
var name string
if err := rows.Scan(&id, &name); err != nil {
return nil, err
}
invalid = append(invalid, fmt.Sprintf("%d:%s", id, name))
}
if len(invalid) > 0 {
return append([]string{"invalid foos:"}, invalid...), nil
}
return nil, nil
},
RepairFunc: func(ctx context.Context, tx *sql.Tx) (migration.Repairs, error) {
rows, err := tx.QueryContext(
ctx,
`delete
from foo
where
public_id is null
returning
id, name;
`,
)
if err != nil {
return nil, err
}
invalid := make([]string, 0)
for rows.Next() {
var id int
var name string
if err := rows.Scan(&id, &name); err != nil {
return nil, err
}
invalid = append(invalid, fmt.Sprintf("%d:%s", id, name))
}
if len(invalid) > 0 {
return append([]string{"deleted foos:"}, invalid...), nil
}
return nil, nil
},
RepairDescription: "will delete any foo that has a null public_id",
},
},
},
Priority: 0,
},
}
// Run manager with marking any migrations for repair.
// The check function in the hook should detect a problem and
// fail the migration.
m, err := schema.NewManager(
ctx,
schema.Dialect(dialect),
d,
schema.WithEditions(editions),
)
if err != nil {
log.Fatalf(err.Error())
}
_, err = m.ApplyMigrations(ctx)
checkErr, _ := err.(schema.MigrationCheckError)
fmt.Println(checkErr.Error())
fmt.Println(strings.Join(checkErr.Problems, "\n"))
fmt.Printf("repair: %s\n", checkErr.RepairDescription)
// Now run with the migration marked for repair.
// The repair function should run, delete data, and the migration
// will succeed.
m, err = schema.NewManager(
ctx,
schema.Dialect(dialect),
d,
schema.WithEditions(editions),
schema.WithRepairMigrations(schema.RepairMigrations{
"hooks_example": map[int]bool{
2: true,
},
}),
)
logs, err := m.ApplyMigrations(ctx)
if err != nil {
log.Fatalf(err.Error())
}
for _, log := range logs {
fmt.Printf("%s:%d:\n", log.Edition, log.Version)
fmt.Println(strings.Join(log.Entry, "\n"))
}
// Output: check failed for hooks_example:2
// invalid foos:
// 1:Alice
// 2:Bob
// repair: will delete any foo that has a null public_id
// hooks_example:2:
// deleted foos:
// 1:Alice
// 2:Bob
}