This adds the ability to define hooks that will run prior to a schema migration. The hooks should only be used when a migration would fail due to data being in an invalid state, likely due to a bug in the previous schema definition. For example if a column was missing a constraint, and a new migration is attempting to add the constraint, there might already be values that violate the new constraint. In such cases, we would want the user to make a decision to address the data, and need to provide them with details about what data is problematic in case they want to manually address the problem. To help the user, if there is a sane way to address the data, we should provide an option to automatically "repair" the data, allowing the migration to continue. However, this still should be an explicit opt-in from the user, and we need to clearly describe what the repair option would do to the user so they understand the consequences of opting in. To accomplish this each migration can be provided a hook that contains a CheckFunc, RepairFunc, and RepairDescription. These functions must operate at the point-in-time of the migration immediately preceding the current migration, as as such they should not use and domain packages or repositories, instead they should use direct sql with the sql library. The description is used to explain what the RepairFunc will do. Hooks should be defined in `internal/db/schema/migrations/oss/oss.go` and registered with the schema edition. See the example in `internal/db/schema/manager_example_test.go` for more details.
156 lines
4.1 KiB
Go
156 lines
4.1 KiB
Go
package oplog
|
|
|
|
import (
|
|
"context"
|
|
"crypto/rand"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/boundary/internal/db/common"
|
|
"github.com/hashicorp/boundary/internal/db/schema"
|
|
"github.com/hashicorp/boundary/internal/oplog/oplog_test"
|
|
"github.com/hashicorp/boundary/testing/dbtest"
|
|
"github.com/hashicorp/go-dbw"
|
|
wrapping "github.com/hashicorp/go-kms-wrapping/v2"
|
|
aead "github.com/hashicorp/go-kms-wrapping/v2/aead"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"gorm.io/driver/postgres"
|
|
)
|
|
|
|
// setup the tests (initialize the database one-time and intialized testDatabaseURL)
|
|
func setup(t testing.TB) *dbw.DB {
|
|
t.Helper()
|
|
require := require.New(t)
|
|
cleanup, url, err := testInitDbInDocker(t)
|
|
require.NoError(err)
|
|
db := testOpen(t, "postgres", url)
|
|
require.NoError(err)
|
|
oplog_test.Init(t, db)
|
|
t.Cleanup(func() {
|
|
assert.NoError(t, db.Close(context.Background()))
|
|
assert.NoError(t, cleanup())
|
|
})
|
|
return db
|
|
}
|
|
|
|
func testOpen(t testing.TB, dbType string, connectionUrl string) *dbw.DB {
|
|
t.Helper()
|
|
require := require.New(t)
|
|
var dialect dbw.Dialector
|
|
switch dbType {
|
|
case "postgres":
|
|
dialect = postgres.New(postgres.Config{
|
|
DSN: connectionUrl,
|
|
},
|
|
)
|
|
default:
|
|
t.Errorf("unable to open %s database type", dbType)
|
|
t.FailNow()
|
|
}
|
|
db, err := dbw.OpenWith(dialect)
|
|
require.NoError(err)
|
|
return db
|
|
}
|
|
|
|
func testUser(t testing.TB, db *dbw.DB, name, phoneNumber, email string) *oplog_test.TestUser {
|
|
t.Helper()
|
|
u := &oplog_test.TestUser{
|
|
Name: name,
|
|
PhoneNumber: phoneNumber,
|
|
Email: email,
|
|
}
|
|
require.NoError(t, dbw.New(db).Create(context.Background(), u))
|
|
return u
|
|
}
|
|
|
|
func testFindUser(t testing.TB, db *dbw.DB, userId uint32) *oplog_test.TestUser {
|
|
t.Helper()
|
|
var foundUser oplog_test.TestUser
|
|
require.NoError(t, dbw.New(db).LookupWhere(context.Background(), &foundUser, "id = ?", []interface{}{userId}))
|
|
return &foundUser
|
|
}
|
|
|
|
func testId(t testing.TB) string {
|
|
t.Helper()
|
|
id, err := dbw.NewId("i")
|
|
require.NoError(t, err)
|
|
return id
|
|
}
|
|
|
|
func testInitDbInDocker(t testing.TB) (cleanup func() error, retURL string, err error) {
|
|
t.Helper()
|
|
require := require.New(t)
|
|
cleanup, retURL, _, err = dbtest.StartUsingTemplate(dbtest.Postgres)
|
|
require.NoError(err)
|
|
testInitStore(t, cleanup, retURL)
|
|
return
|
|
}
|
|
|
|
// testWrapper initializes an AEAD wrapping.Wrapper for testing the oplog
|
|
func testWrapper(t testing.TB) wrapping.Wrapper {
|
|
t.Helper()
|
|
rootKey := make([]byte, 32)
|
|
n, err := rand.Read(rootKey)
|
|
require.NoError(t, err)
|
|
require.Equal(t, n, 32)
|
|
root := aead.NewWrapper()
|
|
err = root.SetAesGcmKeyBytes(rootKey)
|
|
require.NoError(t, err)
|
|
return root
|
|
}
|
|
|
|
// testInitStore will execute the migrations needed to initialize the store for tests
|
|
func testInitStore(t testing.TB, cleanup func() error, url string) {
|
|
t.Helper()
|
|
ctx := context.Background()
|
|
dialect := "postgres"
|
|
|
|
d, err := common.SqlOpen(dialect, url)
|
|
require.NoError(t, err)
|
|
sm, err := schema.NewManager(ctx, schema.Dialect(dialect), d)
|
|
require.NoError(t, err)
|
|
_, err = sm.ApplyMigrations(ctx)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
type constraintResults struct {
|
|
Name string
|
|
TableName string
|
|
}
|
|
|
|
func testListConstraints(t testing.TB, db *dbw.DB, tableName string) []constraintResults {
|
|
t.Helper()
|
|
require := require.New(t)
|
|
require.NotEmpty(tableName)
|
|
testCtx := context.Background()
|
|
const constraintSql = `select pgc.conname as name,
|
|
ccu.table_schema as table_schema,
|
|
ccu.table_name,
|
|
ccu.column_name,
|
|
pgc.consrc as definition
|
|
from pg_constraint pgc
|
|
join pg_namespace nsp on nsp.oid = pgc.connamespace
|
|
join pg_class cls on pgc.conrelid = cls.oid
|
|
left join information_schema.constraint_column_usage ccu
|
|
on pgc.conname = ccu.constraint_name
|
|
and nsp.nspname = ccu.constraint_schema
|
|
-- where contype ='c'
|
|
where ccu.table_name = ?
|
|
order by ccu.table_name,pgc.conname `
|
|
|
|
rw := dbw.New(db)
|
|
rows, err := rw.Query(testCtx, constraintSql, []interface{}{tableName})
|
|
require.NoError(err)
|
|
type result struct {
|
|
Name string
|
|
TableName string
|
|
}
|
|
results := []constraintResults{}
|
|
for rows.Next() {
|
|
var r constraintResults
|
|
rw.ScanRows(rows, &r)
|
|
results = append(results, r)
|
|
}
|
|
return results
|
|
}
|