Hugo
f227020b67
This commit changes the logic around selecting jobs to run. Before this, Boundary used a view "job_jobs_to_run" which was a collation of all jobs that were not running and scheduled to run. When jobs were requested to run, Boundary would look at this view, grab a certain amount of jobs and insert them into the "job_run" table. Importantly, while the amount of jobs to be scheduled at once defaulted to 1 in the scheduler package, this was entirely overriden in the controller package to -1 (no limit, run all jobs that the query would return). With this commit, Boundary now looks at the "job" table directly for jobs to run, regardless of job run status. This was done to improve DB performance as the view (which queried all "job_run" rows) was causing significant DB contention. Additionally, the option to limit job runs is now removed since it was already hardcoded to -1 and not user-configurable anyways. Should the need arise to implement this limit again, this will have to be done in a different way since the new query does not account for running jobs and limiting the rows returned after jobs are already running would yield a no-op (the new query inserts nothing into "job_run" if any given job is already running).
67 lines
1.9 KiB
Go
67 lines
1.9 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package scheduler
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// Test_GetOpts provides unit tests for GetOpts and all the options
|
|
func Test_GetOpts(t *testing.T) {
|
|
t.Parallel()
|
|
t.Run("WithRunJobsInterval", func(t *testing.T) {
|
|
assert := assert.New(t)
|
|
opts := getOpts(WithRunJobsInterval(time.Hour))
|
|
testOpts := getDefaultOptions()
|
|
assert.NotEqual(opts, testOpts)
|
|
testOpts.withRunJobInterval = time.Hour
|
|
assert.Equal(opts, testOpts)
|
|
})
|
|
t.Run("WithZeroRunJobsInterval", func(t *testing.T) {
|
|
assert := assert.New(t)
|
|
opts := getOpts(WithRunJobsInterval(0))
|
|
testOpts := getDefaultOptions()
|
|
assert.Equal(opts, testOpts)
|
|
})
|
|
t.Run("WithMonitorInterval", func(t *testing.T) {
|
|
assert := assert.New(t)
|
|
opts := getOpts(WithMonitorInterval(time.Hour))
|
|
testOpts := getDefaultOptions()
|
|
assert.NotEqual(opts, testOpts)
|
|
testOpts.withMonitorInterval = time.Hour
|
|
assert.Equal(opts, testOpts)
|
|
})
|
|
t.Run("WithZeroMonitorInterval", func(t *testing.T) {
|
|
assert := assert.New(t)
|
|
opts := getOpts(WithMonitorInterval(0))
|
|
testOpts := getDefaultOptions()
|
|
assert.Equal(opts, testOpts)
|
|
})
|
|
t.Run("WithInterruptThreshold", func(t *testing.T) {
|
|
assert := assert.New(t)
|
|
opts := getOpts(WithInterruptThreshold(time.Hour))
|
|
testOpts := getDefaultOptions()
|
|
assert.NotEqual(opts, testOpts)
|
|
testOpts.withInterruptThreshold = time.Hour
|
|
assert.Equal(opts, testOpts)
|
|
})
|
|
t.Run("WithZeroInterruptThreshold", func(t *testing.T) {
|
|
assert := assert.New(t)
|
|
opts := getOpts(WithInterruptThreshold(0))
|
|
testOpts := getDefaultOptions()
|
|
assert.Equal(opts, testOpts)
|
|
})
|
|
t.Run("WithRunNow", func(t *testing.T) {
|
|
assert := assert.New(t)
|
|
opts := getOpts(WithRunNow(true))
|
|
testOpts := getDefaultOptions()
|
|
assert.NotEqual(opts, testOpts)
|
|
testOpts.withRunNow = true
|
|
assert.Equal(opts, testOpts)
|
|
})
|
|
}
|