Files
threshold/internal/auth/ldap/rewrapping_test.go
T
Jim 86192f75eb feature (auth/ldap): add LDAP auth method along with associated accounts and managed groups (#2912)
* feature (auth): required schema changes for auth ldap method (#2669)

chore (auth/ldap): move schema changes to next avail migration number

* feature (auth/ldap): define AuthMethod and all its value objects (#2703)

* feature (auth/ldap): storage protos
* feature (auth/ldap): define AuthMethod and all its value objects

* feature (auth/ldap): add repo and reading an auth method (#2718)

* feature (auth/ldap): add Repository.CreateAuthMethod(...) and Repository.DeleteAuthMethod(...) (#2724)

* feature (auth/ldap): add Repository.UpdateAuthMethod(...) (#2739)

* feature (auth/ldap): add Account

* feature (auth/ldap): add AuthMethod.EnableGroups

* fix (auth/ldap): refactor AuthMethod.oplog to enforce proper constraints

* feature (auth/ldap): add Account repo functions

* refactor (auth/ldap): remove entry attributes from account

Realized the entry attributes could have absolutely anything in them
(including binary data) and since we absolutely don't have to have them
there's just no reason to take on the risk.

* feature (auth/ldap): add AuthMethod.UseTokenGroups

* feature (auth/ldap): add Authenticate(...)

* refactor (auth/ldap): ensure options take a context as the 1st parameter

* feature (auth/ldap): add Account attribute maps

* chore (auth/ldap): make fmt deltas

* feature (auth/ldap): add managed groups (#2760)

* tests (auth/ldap): add missing unit test to Repository.DeleteAccount(...)

Add bits to test the delete operation when you're not able to generate
oplog metadata

* feature (auth/ldap): add managed groups

fixup! feature (auth/ldap): add managed groups (#2760)

* feature (auth/ldap): service proto definition (#2761)

* feature (handlers/authmethods): add handlers for ldap auth method operations (#2794)

* feature (auth/ldap): add Account attribute maps

* chore (auth/ldap): update cap/ldap to latest version

* feature (auth/ldap): add ldap api generation definitions

* feature (authmethods): add ldap repo NewService(...)

* feature (authmethods/ldap): add proper mask_mapping to protobufs

* feature (authmethods): add support to get an ldap auth method

* refactor (auth/ldap): export TestGenerateCA(...)

* feature (authmethods): add support to create an ldap auth method

* feature (authmethods): add support to delete an ldap auth method

* feature (authmethods): add support to list ldap auth methods

* refactor (auth/ldap): make urls optional for NewAuthMethod(...)

* refactor (auth/ldap): export ldap.TestInvalidPem

* chore: make fmt changes

* fix (auth/ldap): properly handle group search config

Add constraints and tests to ensure when an ldap AuthMethod.EnableGroups
is true, and UseTokenGroups is false; that there's a GroupDn configured
for finding a user's associated groups

* feature (authmethods): add support to update an ldap auth methods

* chore (db/ldap): tmp mv migrations so there's no conflict with ongoing work

* feature (verifier): add ldap auth method to verifier bits

* fix (controller): prevent panic when controller stops when there's no listener

* feature (authmethods): add support to authenticate via ldap auth methods

* chore (migrations): fix whitespace in stmt

* chore: fmt fixup

* tests (auth/ldap): invalid err msg

* feature (cli/authmethods): add support for ldap auth-methods CRUD and authenticate (#2810)

* feature (authmethods): add CLI support for ldap auth methods CRUD

* tests (api/auth): ldap auth method classification tests

* feature (authmethods): add CLI support for ldap auth authenticate

* feature (auth/ldap): set request timeouts for ldap server connections

* feature (handlers/authmethods): handle u_anon listing properly.

* feature (account/handers): ldap account and managed group CRUDL APIs (#2852)

* feature (auth/ldap) add repository Listing of ManagedGroupMemberAccount

* feature (controller/handlers): add ldapRepoFn to accounts service

* feature (auth/ldap) register ldap managed group subtype

* feature (account/handlers): ldap account CRUDL APIs

* feature (controller/handlers): add ldapRepo to managed groups service

* feature (account/handlers): ldap managed group CRUDL APIs

* docs (domain): add LDAP accounts, auth-methods and managed groups (#2857)

* feature (ldap/cli) add ldap accounts and managed groups CRUDL commands (#2856)

* fix (handlers/authmethods): fix ldap authorized actions (#2892)

* feature (cli/ldap/authenticate): use primary auth method if none is provided (#2890)

* fix (auth/ldap): support setting the state attribute

* feature (cli/ldap/authenticate): use primary auth method if none is provided

* feature (wh/ldap) add tests for new ldap auth method and accounts (#2919)

* refactor (migrations/ldap): mv to correct directory

* chore: add copyright headers

* fix (api/authmethods/ldap): renumber new LdapAuthMethodAttributes field

* fix (auth/ldap): allow the auth method state to be updated (#2951)

* chore: update sdk and api versions for llb - this is tmp until merging

* tests (managed groups): add required errContains for new test
2023-03-15 11:40:40 -04:00

617 lines
23 KiB
Go

// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0
package ldap
import (
"context"
"crypto/ed25519"
"crypto/rand"
"crypto/x509"
"testing"
"github.com/hashicorp/boundary/internal/db"
"github.com/hashicorp/boundary/internal/errors"
"github.com/hashicorp/boundary/internal/iam"
"github.com/hashicorp/boundary/internal/kms"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestRewrap_bindCredentialRewrapFn(t *testing.T) {
t.Parallel()
testCtx := context.Background()
conn, _ := db.TestSetup(t, "postgres")
testRootWrapper := db.TestWrapper(t)
testKms := kms.TestKms(t, conn, testRootWrapper)
rw := db.New(conn)
org, _ := iam.TestScopes(t, iam.TestRepo(t, conn, testRootWrapper))
orgDBWrapper, err := testKms.GetWrapper(testCtx, org.PublicId, kms.KeyPurposeDatabase)
require.NoError(t, err)
tests := []struct {
name string
ctx context.Context
setup func() (string, string, *BindCredential, *AuthMethod)
reader db.Reader
writer db.Writer
kmsRepo kms.GetWrapperer
wantErr bool
wantErrCode errors.Code
wantErrContains string
}{
{
name: "success",
ctx: testCtx,
setup: func() (string, string, *BindCredential, *AuthMethod) {
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithBindCredential(testCtx, "bind-dn", "bind-password"))
bc := allocBindCredential()
err = rw.LookupWhere(testCtx, &bc, "ldap_method_id = ?", []any{am.PublicId})
require.NoError(t, err)
require.NoError(t, bc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, bc.GetKeyId())
assert.NotEmpty(t, bc.GetPassword())
assert.NotEmpty(t, bc.GetPasswordHmac())
assert.NotEmpty(t, bc.GetCtPassword())
return bc.GetKeyId(), am.GetScopeId(), bc, am
},
reader: rw,
writer: rw,
kmsRepo: testKms,
},
{
name: "missing-key-id",
ctx: testCtx,
setup: func() (string, string, *BindCredential, *AuthMethod) {
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithBindCredential(testCtx, "bind-dn", "bind-password"))
bc := allocBindCredential()
err = rw.LookupWhere(testCtx, &bc, "ldap_method_id = ?", []any{am.PublicId})
require.NoError(t, err)
require.NoError(t, bc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, bc.GetKeyId())
assert.NotEmpty(t, bc.GetPassword())
assert.NotEmpty(t, bc.GetPasswordHmac())
assert.NotEmpty(t, bc.GetCtPassword())
return "", am.GetScopeId(), bc, am
},
reader: rw,
writer: rw,
kmsRepo: testKms,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing data key version id",
},
{
name: "missing-scope-id",
ctx: testCtx,
setup: func() (string, string, *BindCredential, *AuthMethod) {
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithBindCredential(testCtx, "bind-dn", "bind-password"))
bc := allocBindCredential()
err = rw.LookupWhere(testCtx, &bc, "ldap_method_id = ?", []any{am.PublicId})
require.NoError(t, err)
require.NoError(t, bc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, bc.GetKeyId())
assert.NotEmpty(t, bc.GetPassword())
assert.NotEmpty(t, bc.GetPasswordHmac())
assert.NotEmpty(t, bc.GetCtPassword())
return bc.GetKeyId(), "", bc, am
},
reader: rw,
writer: rw,
kmsRepo: testKms,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing scope id",
},
{
name: "missing-reader",
ctx: testCtx,
setup: func() (string, string, *BindCredential, *AuthMethod) {
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithBindCredential(testCtx, "bind-dn", "bind-password"))
bc := allocBindCredential()
err = rw.LookupWhere(testCtx, &bc, "ldap_method_id = ?", []any{am.PublicId})
require.NoError(t, err)
require.NoError(t, bc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, bc.GetKeyId())
assert.NotEmpty(t, bc.GetPassword())
assert.NotEmpty(t, bc.GetPasswordHmac())
assert.NotEmpty(t, bc.GetCtPassword())
return bc.GetKeyId(), am.GetScopeId(), bc, am
},
reader: nil,
writer: rw,
kmsRepo: testKms,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing database reader",
},
{
name: "missing-writer",
ctx: testCtx,
setup: func() (string, string, *BindCredential, *AuthMethod) {
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithBindCredential(testCtx, "bind-dn", "bind-password"))
bc := allocBindCredential()
err = rw.LookupWhere(testCtx, &bc, "ldap_method_id = ?", []any{am.PublicId})
require.NoError(t, err)
require.NoError(t, bc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, bc.GetKeyId())
assert.NotEmpty(t, bc.GetPassword())
assert.NotEmpty(t, bc.GetPasswordHmac())
assert.NotEmpty(t, bc.GetCtPassword())
return bc.GetKeyId(), am.GetScopeId(), bc, am
},
reader: rw,
writer: nil,
kmsRepo: testKms,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing database writer",
},
{
name: "missing-kms",
ctx: testCtx,
setup: func() (string, string, *BindCredential, *AuthMethod) {
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithBindCredential(testCtx, "bind-dn", "bind-password"))
bc := allocBindCredential()
err = rw.LookupWhere(testCtx, &bc, "ldap_method_id = ?", []any{am.PublicId})
require.NoError(t, err)
require.NoError(t, bc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, bc.GetKeyId())
assert.NotEmpty(t, bc.GetPassword())
assert.NotEmpty(t, bc.GetPasswordHmac())
assert.NotEmpty(t, bc.GetCtPassword())
return bc.GetKeyId(), am.GetScopeId(), bc, am
},
reader: rw,
writer: rw,
kmsRepo: nil,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing kms repository",
},
{
name: "GetWrapper-err",
ctx: testCtx,
setup: func() (string, string, *BindCredential, *AuthMethod) {
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithBindCredential(testCtx, "bind-dn", "bind-password"))
bc := allocBindCredential()
err = rw.LookupWhere(testCtx, &bc, "ldap_method_id = ?", []any{am.PublicId})
require.NoError(t, err)
require.NoError(t, bc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, bc.GetKeyId())
assert.NotEmpty(t, bc.GetPassword())
assert.NotEmpty(t, bc.GetPasswordHmac())
assert.NotEmpty(t, bc.GetCtPassword())
return bc.GetKeyId(), am.GetScopeId(), bc, am
},
reader: rw,
writer: rw,
kmsRepo: &kms.MockGetWrapperer{
GetErr: errors.New(testCtx, errors.Internal, "test", "GetWrapper error"),
},
wantErr: true,
wantErrCode: errors.Internal,
wantErrContains: "GetWrapper error",
},
{
name: "encrypt-err",
ctx: testCtx,
setup: func() (string, string, *BindCredential, *AuthMethod) {
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithBindCredential(testCtx, "bind-dn", "bind-password"))
bc := allocBindCredential()
err = rw.LookupWhere(testCtx, &bc, "ldap_method_id = ?", []any{am.PublicId})
require.NoError(t, err)
require.NoError(t, bc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, bc.GetKeyId())
assert.NotEmpty(t, bc.GetPassword())
assert.NotEmpty(t, bc.GetPasswordHmac())
assert.NotEmpty(t, bc.GetCtPassword())
return bc.GetKeyId(), am.GetScopeId(), bc, am
},
reader: rw,
writer: rw,
kmsRepo: &kms.MockGetWrapperer{
ReturnWrapper: &kms.MockWrapper{
EncryptErr: errors.New(testCtx, errors.Encrypt, "test", "encrypt error"),
Wrapper: orgDBWrapper,
},
},
wantErr: true,
wantErrCode: errors.Encrypt,
wantErrContains: "encrypt error",
},
{
name: "decrypt-err",
ctx: testCtx,
setup: func() (string, string, *BindCredential, *AuthMethod) {
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithBindCredential(testCtx, "bind-dn", "bind-password"))
bc := allocBindCredential()
err = rw.LookupWhere(testCtx, &bc, "ldap_method_id = ?", []any{am.PublicId})
require.NoError(t, err)
require.NoError(t, bc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, bc.GetKeyId())
assert.NotEmpty(t, bc.GetPassword())
assert.NotEmpty(t, bc.GetPasswordHmac())
assert.NotEmpty(t, bc.GetCtPassword())
return bc.GetKeyId(), am.GetScopeId(), bc, am
},
reader: rw,
writer: rw,
kmsRepo: &kms.MockGetWrapperer{
ReturnWrapper: &kms.MockWrapper{
DecryptErr: errors.New(testCtx, errors.Encrypt, "test", "decrypt error"),
Wrapper: orgDBWrapper,
},
},
wantErr: true,
wantErrCode: errors.Decrypt,
wantErrContains: "decrypt error",
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
assert, require := assert.New(t), require.New(t)
keyId, scopeId, bc, am := tc.setup()
// now we can rotate and rewrap
assert.NoError(testKms.RotateKeys(testCtx, org.Scope.GetPublicId()))
// let's do this rewrapping!
err := bindCredentialRewrapFn(tc.ctx, keyId, scopeId, tc.reader, tc.writer, tc.kmsRepo)
if tc.wantErr {
require.Error(err)
if tc.wantErrCode != errors.Unknown {
assert.True(errors.Match(errors.T(tc.wantErrCode), err))
}
if tc.wantErrContains != "" {
assert.Contains(err.Error(), tc.wantErrContains)
}
return
}
require.NoError(err)
// fetch the new key version
kmsWrapper, err := testKms.GetWrapper(testCtx, org.Scope.GetPublicId(), kms.KeyPurposeDatabase)
assert.NoError(err)
newKeyVersion, err := kmsWrapper.KeyId(testCtx)
assert.NoError(err)
// get the latest bind cred
latestBindCred := allocBindCredential()
err = rw.LookupWhere(testCtx, &latestBindCred, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(err)
require.NoError(latestBindCred.decrypt(testCtx, kmsWrapper))
// make sure the password and its hmac are correct and that it uses
// the newest key version id
assert.NotEmpty(latestBindCred.KeyId)
assert.Equal(newKeyVersion, latestBindCred.KeyId)
assert.Equal([]byte("bind-password"), latestBindCred.Password)
assert.NotEqual(bc.CtPassword, latestBindCred.CtPassword)
assert.NotEmpty(latestBindCred.PasswordHmac)
assert.Equal(bc.PasswordHmac, latestBindCred.PasswordHmac)
})
}
}
func TestRewrap_clientCertificateRewrapFn(t *testing.T) {
t.Parallel()
testCtx := context.Background()
conn, _ := db.TestSetup(t, "postgres")
testRootWrapper := db.TestWrapper(t)
testKms := kms.TestKms(t, conn, testRootWrapper)
rw := db.New(conn)
org, _ := iam.TestScopes(t, iam.TestRepo(t, conn, testRootWrapper))
orgDBWrapper, err := testKms.GetWrapper(testCtx, org.GetPublicId(), kms.KeyPurposeDatabase)
require.NoError(t, err)
tests := []struct {
name string
ctx context.Context
setup func() (string, string, *ClientCertificate, *AuthMethod)
reader db.Reader
writer db.Writer
kmsRepo kms.GetWrapperer
wantErr bool
wantErrCode errors.Code
wantErrContains string
}{
{
name: "success",
ctx: testCtx,
setup: func() (string, string, *ClientCertificate, *AuthMethod) {
_, privKey, err := ed25519.GenerateKey(rand.Reader)
require.NoError(t, err)
cert, _ := TestGenerateCA(t, "localhost")
derPrivKey, err := x509.MarshalPKCS8PrivateKey(privKey)
require.NoError(t, err)
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithClientCertificate(testCtx, derPrivKey, cert))
cc := allocClientCertificate()
err = rw.LookupWhere(testCtx, &cc, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(t, err)
require.NoError(t, cc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, cc.GetKeyId())
assert.NotEmpty(t, cc.GetCertificateKey())
assert.NotEmpty(t, cc.GetCertificateKeyHmac())
assert.NotEmpty(t, cc.GetCtCertificateKey())
return cc.GetKeyId(), am.GetScopeId(), cc, am
},
reader: rw,
writer: rw,
kmsRepo: testKms,
},
{
name: "missing-key-id",
ctx: testCtx,
setup: func() (string, string, *ClientCertificate, *AuthMethod) {
_, privKey, err := ed25519.GenerateKey(rand.Reader)
require.NoError(t, err)
cert, _ := TestGenerateCA(t, "localhost")
derPrivKey, err := x509.MarshalPKCS8PrivateKey(privKey)
require.NoError(t, err)
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithClientCertificate(testCtx, derPrivKey, cert))
cc := allocClientCertificate()
err = rw.LookupWhere(testCtx, &cc, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(t, err)
require.NoError(t, cc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, cc.GetKeyId())
assert.NotEmpty(t, cc.GetCertificateKey())
assert.NotEmpty(t, cc.GetCertificateKeyHmac())
assert.NotEmpty(t, cc.GetCtCertificateKey())
return "", am.GetScopeId(), cc, am
},
reader: rw,
writer: rw,
kmsRepo: testKms,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing data key version id",
},
{
name: "missing-scope-id",
ctx: testCtx,
setup: func() (string, string, *ClientCertificate, *AuthMethod) {
_, privKey, err := ed25519.GenerateKey(rand.Reader)
require.NoError(t, err)
cert, _ := TestGenerateCA(t, "localhost")
derPrivKey, err := x509.MarshalPKCS8PrivateKey(privKey)
require.NoError(t, err)
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithClientCertificate(testCtx, derPrivKey, cert))
cc := allocClientCertificate()
err = rw.LookupWhere(testCtx, &cc, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(t, err)
require.NoError(t, cc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, cc.GetKeyId())
assert.NotEmpty(t, cc.GetCertificateKey())
assert.NotEmpty(t, cc.GetCertificateKeyHmac())
assert.NotEmpty(t, cc.GetCtCertificateKey())
return cc.GetKeyId(), "", cc, am
},
reader: rw,
writer: rw,
kmsRepo: testKms,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing scope id",
},
{
name: "missing-reader",
ctx: testCtx,
setup: func() (string, string, *ClientCertificate, *AuthMethod) {
_, privKey, err := ed25519.GenerateKey(rand.Reader)
require.NoError(t, err)
cert, _ := TestGenerateCA(t, "localhost")
derPrivKey, err := x509.MarshalPKCS8PrivateKey(privKey)
require.NoError(t, err)
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithClientCertificate(testCtx, derPrivKey, cert))
cc := allocClientCertificate()
err = rw.LookupWhere(testCtx, &cc, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(t, err)
require.NoError(t, cc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, cc.GetKeyId())
assert.NotEmpty(t, cc.GetCertificateKey())
assert.NotEmpty(t, cc.GetCertificateKeyHmac())
assert.NotEmpty(t, cc.GetCtCertificateKey())
return cc.GetKeyId(), am.GetScopeId(), cc, am
},
reader: nil,
writer: rw,
kmsRepo: testKms,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing database reader",
},
{
name: "missing-writer",
ctx: testCtx,
setup: func() (string, string, *ClientCertificate, *AuthMethod) {
_, privKey, err := ed25519.GenerateKey(rand.Reader)
require.NoError(t, err)
cert, _ := TestGenerateCA(t, "localhost")
derPrivKey, err := x509.MarshalPKCS8PrivateKey(privKey)
require.NoError(t, err)
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithClientCertificate(testCtx, derPrivKey, cert))
cc := allocClientCertificate()
err = rw.LookupWhere(testCtx, &cc, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(t, err)
require.NoError(t, cc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, cc.GetKeyId())
assert.NotEmpty(t, cc.GetCertificateKey())
assert.NotEmpty(t, cc.GetCertificateKeyHmac())
assert.NotEmpty(t, cc.GetCtCertificateKey())
return cc.GetKeyId(), am.GetScopeId(), cc, am
},
reader: rw,
writer: nil,
kmsRepo: testKms,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing database writer",
},
{
name: "missing-kms",
ctx: testCtx,
setup: func() (string, string, *ClientCertificate, *AuthMethod) {
_, privKey, err := ed25519.GenerateKey(rand.Reader)
require.NoError(t, err)
cert, _ := TestGenerateCA(t, "localhost")
derPrivKey, err := x509.MarshalPKCS8PrivateKey(privKey)
require.NoError(t, err)
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithClientCertificate(testCtx, derPrivKey, cert))
cc := allocClientCertificate()
err = rw.LookupWhere(testCtx, &cc, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(t, err)
require.NoError(t, cc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, cc.GetKeyId())
assert.NotEmpty(t, cc.GetCertificateKey())
assert.NotEmpty(t, cc.GetCertificateKeyHmac())
assert.NotEmpty(t, cc.GetCtCertificateKey())
return cc.GetKeyId(), am.GetScopeId(), cc, am
},
reader: rw,
writer: rw,
kmsRepo: nil,
wantErr: true,
wantErrCode: errors.InvalidParameter,
wantErrContains: "missing kms repository",
},
{
name: "GetWrapper-err",
ctx: testCtx,
setup: func() (string, string, *ClientCertificate, *AuthMethod) {
_, privKey, err := ed25519.GenerateKey(rand.Reader)
require.NoError(t, err)
cert, _ := TestGenerateCA(t, "localhost")
derPrivKey, err := x509.MarshalPKCS8PrivateKey(privKey)
require.NoError(t, err)
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithClientCertificate(testCtx, derPrivKey, cert))
cc := allocClientCertificate()
err = rw.LookupWhere(testCtx, &cc, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(t, err)
require.NoError(t, cc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, cc.GetKeyId())
assert.NotEmpty(t, cc.GetCertificateKey())
assert.NotEmpty(t, cc.GetCertificateKeyHmac())
assert.NotEmpty(t, cc.GetCtCertificateKey())
return cc.GetKeyId(), am.GetScopeId(), cc, am
},
reader: rw,
writer: rw,
kmsRepo: &kms.MockGetWrapperer{
GetErr: errors.New(testCtx, errors.Internal, "test", "GetWrapper error"),
},
wantErr: true,
wantErrCode: errors.Internal,
wantErrContains: "GetWrapper error",
},
{
name: "encrypt-err",
ctx: testCtx,
setup: func() (string, string, *ClientCertificate, *AuthMethod) {
_, privKey, err := ed25519.GenerateKey(rand.Reader)
require.NoError(t, err)
cert, _ := TestGenerateCA(t, "localhost")
derPrivKey, err := x509.MarshalPKCS8PrivateKey(privKey)
require.NoError(t, err)
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithClientCertificate(testCtx, derPrivKey, cert))
cc := allocClientCertificate()
err = rw.LookupWhere(testCtx, &cc, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(t, err)
require.NoError(t, cc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, cc.GetKeyId())
assert.NotEmpty(t, cc.GetCertificateKey())
assert.NotEmpty(t, cc.GetCertificateKeyHmac())
assert.NotEmpty(t, cc.GetCtCertificateKey())
return cc.GetKeyId(), am.GetScopeId(), cc, am
},
reader: rw,
writer: rw,
kmsRepo: &kms.MockGetWrapperer{
ReturnWrapper: &kms.MockWrapper{
EncryptErr: errors.New(testCtx, errors.Encrypt, "test", "encrypt error"),
Wrapper: orgDBWrapper,
},
},
wantErr: true,
wantErrCode: errors.Encrypt,
wantErrContains: "encrypt error",
},
{
name: "decrypt-err",
ctx: testCtx,
setup: func() (string, string, *ClientCertificate, *AuthMethod) {
_, privKey, err := ed25519.GenerateKey(rand.Reader)
require.NoError(t, err)
cert, _ := TestGenerateCA(t, "localhost")
derPrivKey, err := x509.MarshalPKCS8PrivateKey(privKey)
require.NoError(t, err)
am := TestAuthMethod(t, conn, orgDBWrapper, org.PublicId, []string{"ldaps://alice.com"}, WithClientCertificate(testCtx, derPrivKey, cert))
cc := allocClientCertificate()
err = rw.LookupWhere(testCtx, &cc, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(t, err)
require.NoError(t, cc.decrypt(testCtx, orgDBWrapper))
assert.NotEmpty(t, cc.GetKeyId())
assert.NotEmpty(t, cc.GetCertificateKey())
assert.NotEmpty(t, cc.GetCertificateKeyHmac())
assert.NotEmpty(t, cc.GetCtCertificateKey())
return cc.GetKeyId(), am.GetScopeId(), cc, am
},
reader: rw,
writer: rw,
kmsRepo: &kms.MockGetWrapperer{
ReturnWrapper: &kms.MockWrapper{
DecryptErr: errors.New(testCtx, errors.Encrypt, "test", "decrypt error"),
Wrapper: orgDBWrapper,
},
},
wantErr: true,
wantErrCode: errors.Decrypt,
wantErrContains: "decrypt error",
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
assert, require := assert.New(t), require.New(t)
keyId, scopeId, cc, am := tc.setup()
// now we can rotate and rewrap
assert.NoError(testKms.RotateKeys(testCtx, org.Scope.GetPublicId()))
// let's do this rewrapping!
err := clientCertificateRewrapFn(tc.ctx, keyId, scopeId, tc.reader, tc.writer, tc.kmsRepo)
if tc.wantErr {
require.Error(err)
if tc.wantErrCode != errors.Unknown {
assert.True(errors.Match(errors.T(tc.wantErrCode), err))
}
if tc.wantErrContains != "" {
assert.Contains(err.Error(), tc.wantErrContains)
}
return
}
require.NoError(err)
// fetch the new key version
kmsWrapper, err := testKms.GetWrapper(testCtx, org.Scope.GetPublicId(), kms.KeyPurposeDatabase)
assert.NoError(err)
newKeyVersion, err := kmsWrapper.KeyId(testCtx)
assert.NoError(err)
// get the latest bind cred
latest := allocClientCertificate()
err = rw.LookupWhere(testCtx, &latest, "ldap_method_id = ?", []any{am.GetPublicId()})
require.NoError(err)
require.NoError(latest.decrypt(testCtx, kmsWrapper))
// make sure the password and its hmac are correct and that it uses
// the newest key version id
assert.NotEmpty(latest.KeyId)
assert.Equal(newKeyVersion, latest.KeyId)
assert.Equal(cc.GetCertificateKey(), latest.CertificateKey)
assert.NotEqual(cc.GetCtCertificateKey(), latest.GetCtCertificateKey())
assert.NotEmpty(latest.GetCertificateKeyHmac())
assert.Equal(cc.GetCertificateKeyHmac(), latest.CertificateKeyHmac)
})
}
}