HPR/hpr_generator
5
0
Fork 0
Code Issues 33 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix guard for unitialized variable

Browse Source 
The original guard was preventing an id with value of
zero from being processed correctly.
This commit is contained in:
Roan Horning 2024-10-08 17:37:48 -04:00
parent 39d2ef86ad
commit 8b277607cf
Signed by: rho_n
GPG Key ID: 234AEF20B72D5769
1 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
site-generator
View File

@ -290,26 +290,23 @@ sub parse_page_arg {
# Split page name from page ids if available. # Split page name from page ids if available.
my ($page, $ids) = split(/=/, $page_arg); my ($page, $ids) = split(/=/, $page_arg);
my @ids; my @ids;
$ids = "" unless defined $ids;
if(!$ids) { # Parse the page ids and push them onto @ids array
$ids = ""; my @ids_by_comma = split(/\,/, $ids);
} foreach my $id_by_comma (@ids_by_comma) {
else { my @ids_for_range = split(/\.\./, $id_by_comma);
# Parse the page ids and push them onto @ids array if ((scalar @ids_for_range) == 2) {
my @ids_by_comma = split(/\,/, $ids); push @ids, $ids_for_range[0]..$ids_for_range[1];
foreach my $id_by_comma (@ids_by_comma) { }
my @ids_for_range = split(/\.\./, $id_by_comma); elsif ((scalar @ids_for_range) == 1) {
if ((scalar @ids_for_range) == 2) { push @ids, $ids_for_range[0];
push @ids, $ids_for_range[0]..$ids_for_range[1]; }
} else {
elsif ((scalar @ids_for_range) == 1) { verbose (1, "\nWarning: Page $page id range $id_by_comma could not be parsed.");
push @ids, $ids_for_range[0];
}
else {
verbose (1, "\nWarning: Page $page id range $id_by_comma could not be parsed.");
}
} }
} }
return ('page' => $page, 'ids' => [@ids]); return ('page' => $page, 'ids' => [@ids]);
} }