I145 Various bug fixes #146

davmo · 2023-07-23T16:41:02Z

davmo commented

2023-07-23 16:41:02 +00:00

site-generator: fixed an error in the POD documentation and added an
example. Reformatted 'GetOptions' arguments. Fixed 'parse_page_arg'
which started its returned array with an empty arrayref. Fixed code
using this array which skipped this unwanted extra value. Fixed
'get_ids_from_db' which turns a CSV list of shows into an array, but
includes a blank element. Removed a few trailing spaces.

templates/content-correspondents.tpl.html: Capitalised "License". Added
'order by h.host' to the internal query to get hosts sorted
alphabetically.

templates/content-episode.tpl.html: Added a call to macro
'zero_pad_left' to add leading zeroes to show number in the title.
Added a call to 'FILTER html_para' when displaying comments (which
are plain text). Added a test for whether the show being displayed
is in the 20-show window before the current one to determine whether
the short or long comment form is required. Added the code to
generate the two form types depending on the earlier test.

templates/content-sitemap.tpl.html: Corrected the entry for "Show
Comments" which contained an invalid URL.

templates/page.tpl.html: Grammar corrections in the '<head>' section.

templates/queries-episode-mysql.tpl.html: Adjusted the date tests in the
CTE's which compare the episode date with today's date plus one day.
Why add a day when the test is whether the episode date is less than
or equal to the current one? Also, it seemed that MySQL/MariaDB
might need to work with the UTC date rather than the local dat
implied by 'NOW()'.

templates/queries-episode-sqlite.tpl.html: Similar adjustment to date
tests in CTE's to the MySQL version. SQLite defaults to UTC however.

templates/queries-episodes-mysql.tpl.html: See above for notes about
date tests and MySQL UTC dates. Same arguments here.

templates/queries-episodes-sqlite.tpl.html: Date test adjustment
described above.

templates/queries-ids-episode-mysql.tpl.html: Removed the date test from
the query so all episode numbers are returned. Added an 'order by'
since the table can (could in the past) return numbers out of
numerical sequence.

templates/queries-ids-episode-sqlite.tpl.html: Same change as for the
MySQL version.

templates/queries-index-mysql.tpl.html: There are three queries here,
returned as TT² variables. The one called 'query_latest_episodes'
has been adjusted to use UTC and to avoid adding a day to the
current date. The query called 'query_last_5_weeks_episodes' has
been similarly adjusted.

templates/queries-index-sqlite.tpl.html: Changes for the same two
queries, but just for the tests requiring today's date plus one day.

templates/rss-comments.tpl.xml: Grammar corrections in the
'' section.

templates/rss.tpl.xml: Grammar corrections in various subsections of the
'' section.

templates/shared-call_for_shows.tpl.html: Removed the "FTP server"
message. Slight tidying.

site-generator: fixed an error in the POD documentation and added an example. Reformatted 'GetOptions' arguments. Fixed 'parse_page_arg' which started its returned array with an empty arrayref. Fixed code using this array which skipped this unwanted extra value. Fixed 'get_ids_from_db' which turns a CSV list of shows into an array, but includes a blank element. Removed a few trailing spaces. templates/content-correspondents.tpl.html: Capitalised "License". Added 'order by h.host' to the internal query to get hosts sorted alphabetically. templates/content-episode.tpl.html: Added a call to macro 'zero_pad_left' to add leading zeroes to show number in the title. Added a call to 'FILTER html_para' when displaying comments (which are plain text). Added a test for whether the show being displayed is in the 20-show window before the current one to determine whether the short or long comment form is required. Added the code to generate the two form types depending on the earlier test. templates/content-sitemap.tpl.html: Corrected the entry for "Show Comments" which contained an invalid URL. templates/page.tpl.html: Grammar corrections in the '<head>' section. templates/queries-episode-mysql.tpl.html: Adjusted the date tests in the CTE's which compare the episode date with today's date plus one day. Why add a day when the test is whether the episode date is less than or equal to the current one? Also, it seemed that MySQL/MariaDB might need to work with the UTC date rather than the local dat implied by 'NOW()'. templates/queries-episode-sqlite.tpl.html: Similar adjustment to date tests in CTE's to the MySQL version. SQLite defaults to UTC however. templates/queries-episodes-mysql.tpl.html: See above for notes about date tests and MySQL UTC dates. Same arguments here. templates/queries-episodes-sqlite.tpl.html: Date test adjustment described above. templates/queries-ids-episode-mysql.tpl.html: Removed the date test from the query so all episode numbers are returned. Added an 'order by' since the table can (could in the past) return numbers out of numerical sequence. templates/queries-ids-episode-sqlite.tpl.html: Same change as for the MySQL version. templates/queries-index-mysql.tpl.html: There are three queries here, returned as TT² variables. The one called 'query_latest_episodes' has been adjusted to use UTC and to avoid adding a day to the current date. The query called 'query_last_5_weeks_episodes' has been similarly adjusted. templates/queries-index-sqlite.tpl.html: Changes for the same two queries, but just for the tests requiring today's date plus one day. templates/rss-comments.tpl.xml: Grammar corrections in the '<channel><description>' section. templates/rss.tpl.xml: Grammar corrections in various subsections of the '<channel>' section. templates/shared-call_for_shows.tpl.html: Removed the "FTP server" message. Slight tidying.

Sign in to join this conversation.

No reviewers