The ./site-generator should fail to run if all the perl modules needed are not installed #164

New Issue

2023-08-31T16:57:58Z

ken_fallon commented

2023-08-31 16:57:58 +00:00

Currently the perl script fails to run at different points when run.

Some modules only give errors when their template is called.

The script should not run at all if all the perl modules are not installed.

Currently the perl script fails to run at different points when run. Some modules only give errors when their template is called. The script should not run at all if all the perl modules are not installed.

davmo commented

2024-03-20 19:08:34 +00:00

This is not simple as far as I can tell. I have looked at collecting the module names by scanning the site-generator script itself, then feeding it to a mini-script that performs module checks. My tests used Module::Runtime which gives a fairly clean interface to the module check process, but what if Module::Runtime is not installed?!

Also, it seems that there are modules that are referred to only in the templates (though they may be sub-modules of those that are defined in site-generator). This needs investigation.

I think it would be easiest to write a script in utils that can be run to perform the check, and that's what I'm working on at present.

This is not simple as far as I can tell. I have looked at collecting the module names by scanning the `site-generator` script itself, then feeding it to a mini-script that performs module checks. My tests used ` Module::Runtime` which gives a fairly clean interface to the module check process, but what if ` Module::Runtime` is not installed?! Also, it seems that there are modules that are referred to only in the templates (though they may be sub-modules of those that are defined in `site-generator`). This needs investigation. I think it would be easiest to write a script in `utils` that can be run to perform the check, and that's what I'm working on at present.

kdmurrayhpr commented

2024-05-21 06:04:45 +00:00

Would it be possible to create a "scanner" module that does nothing but try to reference all of the modules we use? Run that as a check up front and allow it to halt the rest of the script if anything is amiss?

davmo commented

2024-05-21 08:54:37 +00:00

Would it be possible to create a "scanner" module that does nothing but try to reference all of the modules we use? Run that as a check up front and allow it to halt the rest of the script if anything is amiss?

Yes, that was what I was proposing. I think I had started writing something or had made some notes about how it might be done.

> Would it be possible to create a "scanner" module that does nothing but try to reference all of the modules we use? Run that as a check up front and allow it to halt the rest of the script if anything is amiss? Yes, that was what I was proposing. I think I had started writing something or had made some notes about how it might be done.

rho_n commented

2024-09-28 16:38:10 +00:00

A check dependencies bash script is merged into main

A [check dependencies bash script](https://repo.anhonesthost.net/HPR/hpr_generator/pulls/203) is [merged into main](https://repo.anhonesthost.net/HPR/hpr_generator/commit/1853715a19ee747d2873816814a221e42ffcb5ac)

rho_n closed this issue

2024-09-28 16:38:10 +00:00

Sign in to join this conversation.

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: HPR/hpr_generator#164