HPR/hpr_generator
8
1
Fork 5
Code Issues 34 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

[I132] tags page generation issues #205

Merged
rho_n merged 5 commits from I132_tags_index_issues into main 2024-09-28 15:49:44 +00:00
Conversation 3 Commits 5 Files Changed 3
+23 -13
rho_n commented 2024-09-18 03:12:56 +00:00
Owner
Copy Link
Copy Source

Replace white-space in html tag ID attribute with an under-score character.

Fix the issue where tags that start with the letter "k" are not included in the index. The tag "keys" caused issues when using it as a key to a hash in the tags content template.

Replace white-space in html tag ID attribute with an under-score character. Fix the issue where tags that start with the letter "k" are not included in the index. The tag "keys" caused issues when using it as a key to a hash in the tags content template.
davmo reviewed 2024-09-18 03:13:06 +00:00
ken_fallon commented 2024-09-24 07:33:34 +00:00
Owner
Copy Link
Copy Source

Looks good to me.

@davmo if you agree can you commit.

Looks good to me. @davmo if you agree can you commit.
davmo commented 2024-09-28 15:39:03 +00:00
Owner
Copy Link
Copy Source

Not sure if the original Perl implementation had this bug - quite likely it did.

It's a nice solution. Looks fine to me.

Not sure if the original Perl implementation had this bug - quite likely it did. It's a nice solution. Looks fine to me.
rho_n added 1 commit 2024-09-28 15:49:28 +00:00
Merge branch 'main' into I132_tags_index_issues 06601c5d20
rho_n merged commit 73dd71f2f0 into main 2024-09-28 15:49:44 +00:00
rho_n deleted branch I132_tags_index_issues 2024-09-28 15:49:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
davmo
Labels
Clear labels
Bug Found
For issues related to the code or the content of the created HTML files
 Feature Request
General Discussion
For discussing HPR site generation in general
 Help Request
For issues running or installing the site-generator
HPR
Bug found
2
For issues related to the code or the content of files
HPR
Feature Request
Used when requesting a new Feature.
HPR
General discussion
1
For discussing issues or ideas for HPR content or features
HPR
Help Request
4
No labels Bug Found
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
archer72 davmo (Dave Morriss) jknapp ken_fallon (Ken Fallon) norrist paulj (Paul Jewell ) rho_n (Roan Horning) sgoti
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HPR/hpr_generator#205