HPR/hpr_generator
5
0
Fork 0
Code Issues 30 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

[I132] tags page generation issues #205

Merged
rho_n merged 5 commits from I132_tags_index_issues into main 2024-09-28 15:49:44 +00:00
Conversation 2 Commits 5 Files Changed 3 +23 -13
rho_n commented 2024-09-18 03:12:56 +00:00
Owner
Copy Link

Replace white-space in html tag ID attribute with an under-score character.

Fix the issue where tags that start with the letter "k" are not included in the index. The tag "keys" caused issues when using it as a key to a hash in the tags content template.

Replace white-space in html tag ID attribute with an under-score character. Fix the issue where tags that start with the letter "k" are not included in the index. The tag "keys" caused issues when using it as a key to a hash in the tags content template.
davmo reviewed 2024-09-18 03:13:06 +00:00
ken_fallon commented 2024-09-24 07:33:34 +00:00
Owner
Copy Link

Looks good to me.

@davmo if you agree can you commit.

Looks good to me. @davmo if you agree can you commit.
davmo commented 2024-09-28 15:39:03 +00:00
Owner
Copy Link

Not sure if the original Perl implementation had this bug - quite likely it did.

It's a nice solution. Looks fine to me.

Not sure if the original Perl implementation had this bug - quite likely it did. It's a nice solution. Looks fine to me.
rho_n added 1 commit 2024-09-28 15:49:28 +00:00
rho_n merged commit 73dd71f2f0 into main 2024-09-28 15:49:44 +00:00
rho_n deleted branch I132_tags_index_issues 2024-09-28 15:49:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
davmo
Labels
Clear labels   
Bug Found

For issues related to the code or the content of the created HTML files

  
Feature Request

   
General Discussion

For discussing HPR site generation in general

  
Help Request

For issues running or installing the site-generator

No Label
Bug Found
Feature Request
General Discussion
Help Request
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: HPR/hpr_generator#205
No description provided.
Delete Branch "I132_tags_index_issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?