HPR/hpr_generator
5
0
Fork 0
Code Issues 33 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Improvements to comment formatting #206

New Issue
Open
opened 2024-09-29 20:44:54 +00:00 by davmo · 1 comment
davmo commented 2024-09-29 20:44:54 +00:00
Owner
Copy Link

Inconsistencies and similarities:

  • Comments on the episode page (templates/content-episode.tpl.html) don't have any formatting. Blocks of text are just enclosed with <p> tags using FILTER html_para.
  • Comments in the viewer (templates/content-comments_viewer.tpl.html) are displayed with FILTER html_line_break, which replaces newlines with <br /> tags.
  • Similarly with the RSS (templates/rss-comments.tpl.xml), it also uses FILTER html_line_break.

For the moment, using html_line_break seems preferable since it retains the original layout better.

It might be appropriate to review the displaying of comments including making URLs clickable.

Inconsistencies and similarities: - Comments on the episode page (`templates/content-episode.tpl.html`) don't have any formatting. Blocks of text are just enclosed with `<p>` tags using `FILTER html_para`. - Comments in the viewer (`templates/content-comments_viewer.tpl.html`) are displayed with `FILTER html_line_break`, which replaces newlines with `<br />` tags. - Similarly with the RSS (`templates/rss-comments.tpl.xml`), it also uses `FILTER html_line_break`. For the moment, using `html_line_break` seems preferable since it retains the original layout better. It might be appropriate to review the displaying of comments including making URLs clickable.
rho_n commented 2024-09-30 16:27:22 +00:00
Owner
Copy Link

Updated episode template to match comment view when converting comments to HTML in PR 207 and merged to main.

Updated episode template to match comment view when converting comments to HTML in [PR 207](https://repo.anhonesthost.net/HPR/hpr_generator/pulls/207) and [merged to main](https://repo.anhonesthost.net/HPR/hpr_generator/commit/24e1177c456e3cb80134abad1cc2d5ee467a8314).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Bug Found

For issues related to the code or the content of the created HTML files

  
Feature Request

   
General Discussion

For discussing HPR site generation in general

  
Help Request

For issues running or installing the site-generator

No Label
Bug Found
Feature Request
General Discussion
Help Request
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: HPR/hpr_generator#206
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?