HPR/hpr_generator
8
1
Fork 5
Code Issues 34 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Improvements to comment formatting #206

New Issue
Closed
opened 2024-09-29 20:44:54 +00:00 by davmo · 2 comments
davmo commented 2024-09-29 20:44:54 +00:00
Owner
Copy Link
Copy Source

Inconsistencies and similarities:

  • Comments on the episode page (templates/content-episode.tpl.html) don't have any formatting. Blocks of text are just enclosed with <p> tags using FILTER html_para.
  • Comments in the viewer (templates/content-comments_viewer.tpl.html) are displayed with FILTER html_line_break, which replaces newlines with <br /> tags.
  • Similarly with the RSS (templates/rss-comments.tpl.xml), it also uses FILTER html_line_break.

For the moment, using html_line_break seems preferable since it retains the original layout better.

It might be appropriate to review the displaying of comments including making URLs clickable.

Inconsistencies and similarities: - Comments on the episode page (`templates/content-episode.tpl.html`) don't have any formatting. Blocks of text are just enclosed with `<p>` tags using `FILTER html_para`. - Comments in the viewer (`templates/content-comments_viewer.tpl.html`) are displayed with `FILTER html_line_break`, which replaces newlines with `<br />` tags. - Similarly with the RSS (`templates/rss-comments.tpl.xml`), it also uses `FILTER html_line_break`. For the moment, using `html_line_break` seems preferable since it retains the original layout better. It might be appropriate to review the displaying of comments including making URLs clickable.
rho_n commented 2024-09-30 16:27:22 +00:00
Owner
Copy Link
Copy Source

Updated episode template to match comment view when converting comments to HTML in PR 207 and merged to main.

Updated episode template to match comment view when converting comments to HTML in [PR 207](https://repo.anhonesthost.net/HPR/hpr_generator/pulls/207) and [merged to main](https://repo.anhonesthost.net/HPR/hpr_generator/commit/24e1177c456e3cb80134abad1cc2d5ee467a8314).
rho_n commented 2026-02-19 00:50:21 +00:00
Owner
Copy Link
Copy Source

This has been superseded by new website design

This has been superseded by new website design
rho_n closed this issue 2026-02-19 00:50:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Bug Found
For issues related to the code or the content of the created HTML files
 Feature Request
General Discussion
For discussing HPR site generation in general
 Help Request
For issues running or installing the site-generator
HPR
Bug found
2
For issues related to the code or the content of files
HPR
Feature Request
Used when requesting a new Feature.
HPR
General discussion
1
For discussing issues or ideas for HPR content or features
HPR
Help Request
4
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
archer72 davmo (Dave Morriss) jknapp ken_fallon (Ken Fallon) norrist paulj (Paul Jewell ) rho_n (Roan Horning) sgoti
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HPR/hpr_generator#206