apply a crafty style to the lane buttons #273

Merged
rho_n merged 4 commits from lee/hpr_generator:newsite into newsite 2025-09-04 19:56:18 +00:00
Contributor

Apply a crafty style to lane buttons

Apply a crafty style to lane buttons
lee added 1 commit 2025-08-22 11:23:38 +00:00
lee added 1 commit 2025-08-28 22:41:50 +00:00
lee added 1 commit 2025-09-04 10:25:51 +00:00
Author
Contributor

Merged in changes

Merged in changes
Owner

The buttons are looking good. My only concern is from an accessibility point of view.
image.png

On my screen, the contrast between the text and the background feels too low. I think part of this is due to the combination of that particular font and the pixelation effect being applied.

Slightly nit picky and along the same issue as above, the record icon looks like it has more contrast. Probably because there is more black overall. Is there a way to give the other icons the same "weight" as the record icon?

The buttons are looking good. My only concern is from an accessibility point of view. ![image.png](/attachments/c0fadc94-a10f-4091-a4c7-305b60714a0b) On my screen, the contrast between the text and the background feels too low. I think part of this is due to the combination of that particular font and the pixelation effect being applied. Slightly nit picky and along the same issue as above, the record icon looks like it has more contrast. Probably because there is more black overall. Is there a way to give the other icons the same "weight" as the record icon?
220 KiB
Author
Contributor

Hmm, something is up with the font rendering on the screenshot, it should be using a specific google font, it looks like it is using the fallback generic cursive font, better maybe to fallback to sans. The record icon is deliberately more pronounced - as Ken keeps saying, more than anything else the purpose of the website is to encourage people to record. But if that level of contrast works better. then the others, can be made similar. Again the backgrounds are deliberately trying to show some pixels and are mixed up a bit as to which part of the background image each one shows, both for variation and to try to give a rough work in progress feel. Maybe best just to standardise and reduce that complexity as it adds a lot of css with little payback.

I'll aim to revise and re-submit based on the feedback.

Hmm, something is up with the font rendering on the screenshot, it should be using a specific google font, it looks like it is using the fallback generic cursive font, better maybe to fallback to sans. The record icon is deliberately more pronounced - as Ken keeps saying, more than anything else the purpose of the website is to encourage people to record. But if that level of contrast works better. then the others, can be made similar. Again the backgrounds are deliberately trying to show some pixels and are mixed up a bit as to which part of the background image each one shows, both for variation and to try to give a rough work in progress feel. Maybe best just to standardise and reduce that complexity as it adds a lot of css with little payback. I'll aim to revise and re-submit based on the feedback.
Owner

Also keep in mind the license of any font we need to have that listed on the page. Also all fonts need to be hosted on the deployed site, and not from 3rd party services like Google.

Also keep in mind the license of any font we need to have that listed on the page. Also all fonts need to be hosted on the deployed site, and not from 3rd party services like Google.
Owner

Hmm, something is up with the font rendering on the screenshot, it should be using a specific google font, it looks like it is using the fallback generic cursive font, better maybe to fallback to sans.

Ahh, didn't realize the font wasn't correct. I just cloned your repository and then generated the index page. Should have looked closer at your snip above.

The record icon is deliberately more pronounced - as Ken keeps saying, more than anything else the purpose of the website is to encourage people to record. But if that level of contrast works better. then the others, can be made similar. Again the backgrounds are deliberately trying to show some pixels and are mixed up a bit as to which part of the background image each one shows, both for variation and to try to give a rough work in progress feel. Maybe best just to standardise and reduce that complexity as it adds a lot of css with little payback.

Ok, Fair point on highlighting that record icon. Maybe make the others a little closer to it, and then make the border for the record icon the --background-secondary color--so that it is emphasized by the border.

lol, or we could add a blink tag or the modern CSS equivalent to that icon. Really draw attention to it 😛

> Hmm, something is up with the font rendering on the screenshot, it should be using a specific google font, it looks like it is using the fallback generic cursive font, better maybe to fallback to sans. Ahh, didn't realize the font wasn't correct. I just cloned your repository and then generated the index page. Should have looked closer at your snip above. > The record icon is deliberately more pronounced - as Ken keeps saying, more than anything else the purpose of the website is to encourage people to record. But if that level of contrast works better. then the others, can be made similar. Again the backgrounds are deliberately trying to show some pixels and are mixed up a bit as to which part of the background image each one shows, both for variation and to try to give a rough work in progress feel. Maybe best just to standardise and reduce that complexity as it adds a lot of css with little payback. Ok, Fair point on highlighting that record icon. Maybe make the others a little closer to it, and then make the border for the record icon the --background-secondary color--so that it is emphasized by the border. lol, or we could add a blink tag or the modern CSS equivalent to that icon. Really draw attention to it 😛
lee added 1 commit 2025-09-04 17:20:09 +00:00
Author
Contributor

Amended now, that font licence along with the font is at /public_html/css/patrickhand/OFL.txt

Amended now, that font licence along with the font is at /public_html/css/patrickhand/OFL.txt
Author
Contributor

Not sure where the underline under the link has gone, though I'm on a Mac now was on Linux earlier

Not sure where the underline under the link has gone, though I'm on a Mac now was on Linux earlier
Author
Contributor

Noir on the Mac is not kind to this though, but that's maybe a wider issue to do with dark mode, etc.

Noir on the Mac is not kind to this though, but that's maybe a wider issue to do with dark mode, etc.
Author
Contributor

I love the blink tag idea, how 1990s would that be 🙂

I love the blink tag idea, how 1990s would that be 🙂
Author
Contributor

Wait I'm going to redo that commit because the diff looks to have reverted other changes, which would explain a few things

Wait I'm going to redo that commit because the diff looks to have reverted other changes, which would explain a few things
lee force-pushed newsite from f55f24957a to 4654adaa42 2025-09-04 17:55:53 +00:00 Compare
Author
Contributor

Okay, re-committed now

Okay, re-committed now
rho_n merged commit dcfd801b9a into newsite 2025-09-04 19:56:18 +00:00
Owner

Thanks for this Lee. I have merged into the hpr/newsite branch.

Thanks for this Lee. I have merged into the hpr/newsite branch.
Sign in to join this conversation.
No description provided.