From d82ee259161f6d89120ad1b995856d7b34d613e0 Mon Sep 17 00:00:00 2001
From: MarcoPad Dev <jknapp85@gmail.com>
Date: Fri, 17 Jul 2026 20:33:54 -0700
Subject: [PATCH] ci: use Windows PowerShell, add preflight job, harden for
 self-hosted
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- The runner has Windows PowerShell 5.1, not pwsh/PowerShell 7 — switch all
  steps from `shell: pwsh` to `shell: powershell`.
- Make the scripts 5.1-safe: force TLS 1.2 for HTTPS, -UseBasicParsing on
  Invoke-WebRequest, and write GITHUB_ENV as ascii (no BOM).
- Add a fast `preflight` job that validates the runner (OS, PowerShell, Python
  availability) in seconds; build-windows now `needs: [preflight]`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .gitea/workflows/build-windows.yml | 43 ++++++++++++++++++++++--------
 1 file changed, 32 insertions(+), 11 deletions(-)

diff --git a/.gitea/workflows/build-windows.yml b/.gitea/workflows/build-windows.yml
index 88d87b1..2ec2589 100644
--- a/.gitea/workflows/build-windows.yml
+++ b/.gitea/workflows/build-windows.yml
@@ -4,10 +4,12 @@ name: Build Windows
 # Produces dist/macropad.exe as a build artifact, and on a version tag (v*)
 # creates/updates a Gitea release and attaches the exe.
 #
-# Note: actions/setup-python is intentionally NOT used — its Windows
-# tool-cache install script hangs on self-hosted runners. Instead we use an
-# existing Python 3.11 if the VM has one, otherwise silently install it
-# per-user (no elevation, no prompts).
+# Notes for self-hosted Windows runners:
+#  - Uses `shell: powershell` (Windows PowerShell 5.1); `pwsh`/PowerShell 7 is
+#    not assumed to be installed.
+#  - actions/setup-python is avoided (its Windows tool-cache install hangs on
+#    self-hosted runners); Python 3.11 is used if present, else silently
+#    installed per-user.
 
 on:
   workflow_dispatch:
@@ -16,7 +18,22 @@ on:
       - 'v*'
 
 jobs:
+  # Fast smoke test so a broken runner fails in seconds, not minutes.
+  preflight:
+    runs-on: windows-latest
+    timeout-minutes: 5
+    steps:
+      - name: Runner check
+        shell: powershell
+        run: |
+          Write-Host "Runner OK on $env:COMPUTERNAME"
+          Write-Host "OS: $([System.Environment]::OSVersion.VersionString)"
+          Write-Host "PowerShell: $($PSVersionTable.PSVersion)"
+          $py = Get-Command py -ErrorAction SilentlyContinue
+          if ($py) { & py -3.11 --version } else { Write-Host "No py launcher; build will self-install Python 3.11." }
+
   build-windows:
+    needs: [preflight]
     runs-on: windows-latest
     timeout-minutes: 30
     steps:
@@ -24,9 +41,10 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Ensure Python 3.11
-        shell: pwsh
+        shell: powershell
         run: |
           $ErrorActionPreference = 'Stop'
+          [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
           $python = $null
 
           # 1) Existing "py -3.11" launcher
@@ -50,7 +68,7 @@ jobs:
             Write-Host "Python 3.11 not found - installing per-user..."
             $tmp = if ($env:RUNNER_TEMP) { $env:RUNNER_TEMP } else { $env:TEMP }
             $installer = Join-Path $tmp "python-3.11.9-amd64.exe"
-            Invoke-WebRequest -Uri "https://www.python.org/ftp/python/3.11.9/python-3.11.9-amd64.exe" -OutFile $installer
+            Invoke-WebRequest -UseBasicParsing -Uri "https://www.python.org/ftp/python/3.11.9/python-3.11.9-amd64.exe" -OutFile $installer
             $dir = Join-Path $tmp "Python311"
             $proc = Start-Process -FilePath $installer -Wait -PassThru -NoNewWindow -ArgumentList @(
               "/quiet","InstallAllUsers=0","PrependPath=0","Include_launcher=0","Include_test=0","TargetDir=$dir"
@@ -61,24 +79,26 @@ jobs:
 
           if (-not (Test-Path $python)) { throw "Python not found at '$python'" }
           & $python --version
-          "PYTHON=$python" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
+          # Write to GITHUB_ENV without a BOM (ascii) so the value parses cleanly.
+          Add-Content -Path $env:GITHUB_ENV -Value "PYTHON=$python" -Encoding ascii
 
       - name: Install dependencies
-        shell: pwsh
+        shell: powershell
         run: |
           $ErrorActionPreference = 'Stop'
+          [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
           & $env:PYTHON -m pip install --upgrade pip
           & $env:PYTHON -m pip install -e .
           & $env:PYTHON -m pip install pyinstaller
 
       - name: Build Windows executable
-        shell: pwsh
+        shell: powershell
         run: |
           $ErrorActionPreference = 'Stop'
           & $env:PYTHON -m PyInstaller --noconfirm macropad.spec
 
       - name: Verify build output
-        shell: pwsh
+        shell: powershell
         run: |
           if (-not (Test-Path dist/macropad.exe)) {
             throw "Build failed: dist/macropad.exe not found"
@@ -94,11 +114,12 @@ jobs:
 
       - name: Publish release asset (tags only)
         if: startsWith(github.ref, 'refs/tags/')
-        shell: pwsh
+        shell: powershell
         env:
           GITEA_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           $ErrorActionPreference = 'Stop'
+          [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
           $api  = $env:GITHUB_API_URL
           $repo = $env:GITHUB_REPOSITORY
           $tag  = $env:GITHUB_REF_NAME