MacroPad/MP-Server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

fix: app-launch macros on Windows + bump to 1.1.1 #10

Merged
jknapp merged 1 commits from fix/app-launch-windows into main 2026-07-18 05:59:36 +00:00
Conversation 0 Commits 1 Files Changed 3
+16 -8
jknapp commented 2026-07-18 05:59:34 +00:00
Owner
Copy Link
Copy Source

App macros silently did nothing on Windows: shlex.split(posix=False) kept quotes in the exe path. Fix passes the command string to Popen on Windows (CreateProcess handles quoting, still no shell); POSIX keeps shlex.split. Bumps to 1.1.1.

App macros silently did nothing on Windows: shlex.split(posix=False) kept quotes in the exe path. Fix passes the command string to Popen on Windows (CreateProcess handles quoting, still no shell); POSIX keeps shlex.split. Bumps to 1.1.1.
jknapp added 1 commit 2026-07-18 05:59:34 +00:00
fix: app-launch macros on Windows (shlex quote handling), bump to 1.1.1 e0df32f42b 
When shell=True was removed for security, the command was parsed with
shlex.split(posix=False) on Windows, which keeps the quote characters inside
the tokens — so a quoted path like "C:\Program Files\app.exe" became an argv[0]
containing literal quotes and CreateProcess couldn't find it, so app macros
silently did nothing.

Fix: on Windows pass the command string to Popen (shell=False) and let
CreateProcess parse it (handles quoted paths, still no shell/metacharacter
chaining); on POSIX keep shlex.split. Verified a real launch works and shell
redirection stays blocked.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jknapp merged commit 62559a59c9 into main 2026-07-18 05:59:36 +00:00
jknapp deleted branch fix/app-launch-windows 2026-07-18 05:59:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jknapp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MacroPad/MP-Server#10
Delete Branch "fix/app-launch-windows"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?