Fix sidecar not found on Windows/macOS/Linux: switch from externalBin to resources
Tauri's externalBin only bundled the single sidecar executable, but PyInstaller's onedir output requires companion DLLs and _internal/. The binary was also renamed with a target triple suffix that resolve_sidecar_path() didn't look for, causing it to fall back to dev mode which used a compile-time CI path (CARGO_MANIFEST_DIR). - Switch from externalBin to bundle.resources to include all sidecar files - Pass Tauri resource_dir to sidecar manager for platform-aware path resolution - Remove rename_binary() since externalBin target triple naming is no longer needed - Remove broken production-to-dev fallback that could never work on user machines Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -41,9 +41,8 @@ jobs:
|
||||
|
||||
- name: Place sidecar for Tauri
|
||||
run: |
|
||||
mkdir -p src-tauri/binaries
|
||||
cp -r python/dist/voice-to-notes-sidecar/* src-tauri/binaries/
|
||||
chmod +x src-tauri/binaries/voice-to-notes-sidecar-${{ env.TARGET }}
|
||||
cp -r python/dist/voice-to-notes-sidecar src-tauri/sidecar
|
||||
chmod +x src-tauri/sidecar/voice-to-notes-sidecar
|
||||
|
||||
# ── Tauri app ──
|
||||
- name: Set up Node.js
|
||||
@@ -65,7 +64,7 @@ jobs:
|
||||
- name: Build Tauri app
|
||||
run: npm run tauri build
|
||||
env:
|
||||
TAURI_CONFIG: '{"bundle":{"externalBin":["binaries/voice-to-notes-sidecar"]}}'
|
||||
TAURI_CONFIG: '{"bundle":{"resources":["sidecar/**"]}}'
|
||||
|
||||
# ── Release ──
|
||||
- name: Upload to release
|
||||
|
||||
Reference in New Issue
Block a user