fix: actually pass the new optional env vars into the container
OIDC_ISSUER_MCP and OIDC_AUDIENCE_SCOPE were added to .env and read by the
app, but never reached it: the compose `environment:` block is an explicit
allow-list, not env_file, so anything not named there is silently dropped.
The aud scope only worked because its computed default happened to be right.
Also make optional vars tolerate the empty string. compose renders `${VAR:-}`
as "" rather than omitting the key, so an unset optional var would arrive as
"" and fail .url()/.min(1) validation — taking the app down at boot rather
than falling back to its default.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
+12
-2
@@ -4,6 +4,16 @@ const Bool = z
|
||||
.union([z.boolean(), z.enum(["true", "false", "1", "0"])])
|
||||
.transform((v) => v === true || v === "true" || v === "1");
|
||||
|
||||
/**
|
||||
* Treat an empty string as "not set".
|
||||
*
|
||||
* docker-compose renders `${VAR:-}` as an empty string rather than omitting
|
||||
* the key, so an unset optional var arrives as "" and would otherwise fail
|
||||
* `.url()` / `.min(1)` validation and take the whole app down at boot.
|
||||
*/
|
||||
const optional = <T extends z.ZodTypeAny>(schema: T) =>
|
||||
z.preprocess((v) => (v === "" ? undefined : v), schema.optional());
|
||||
|
||||
const envSchema = z.object({
|
||||
NODE_ENV: z.enum(["development", "test", "production"]).default("development"),
|
||||
LOG_LEVEL: z.enum(["debug", "info", "warn", "error"]).default("info"),
|
||||
@@ -25,7 +35,7 @@ const envSchema = z.object({
|
||||
//
|
||||
// Set this to the MCP application's issuer. Defaults to OIDC_ISSUER for
|
||||
// single-application setups.
|
||||
OIDC_ISSUER_MCP: z.string().url().optional(),
|
||||
OIDC_ISSUER_MCP: optional(z.string().url()),
|
||||
OIDC_CLIENT_ID_WEB: z.string().min(1),
|
||||
OIDC_CLIENT_SECRET_WEB: z.string().min(1),
|
||||
OIDC_CLIENT_ID_MCP: z.string().min(1),
|
||||
@@ -40,7 +50,7 @@ const envSchema = z.object({
|
||||
// every token arrives without an `aud` claim (-> 401 "claim invalid: aud").
|
||||
//
|
||||
// Defaults to the `aud-<audience>` convention used in the README setup.
|
||||
OIDC_AUDIENCE_SCOPE: z.string().min(1).optional(),
|
||||
OIDC_AUDIENCE_SCOPE: optional(z.string().min(1)),
|
||||
|
||||
// Database
|
||||
DATABASE_URL: z.string().url(),
|
||||
|
||||
@@ -113,6 +113,10 @@ services:
|
||||
OIDC_CLIENT_SECRET_WEB: ${OIDC_CLIENT_SECRET_WEB:?required}
|
||||
OIDC_CLIENT_ID_MCP: ${OIDC_CLIENT_ID_MCP:?required}
|
||||
OIDC_AUDIENCE: ${OIDC_AUDIENCE:?required}
|
||||
# Optional. This block is an explicit allow-list, not env_file — a var
|
||||
# added to .env but not listed here never reaches the container.
|
||||
OIDC_ISSUER_MCP: ${OIDC_ISSUER_MCP:-}
|
||||
OIDC_AUDIENCE_SCOPE: ${OIDC_AUDIENCE_SCOPE:-}
|
||||
|
||||
DATABASE_URL: postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@db:5432/${POSTGRES_DB}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user