shadowdaoandClaude Opus 5
c3bbea5134
memory.get no longer returns the embedding and content_tsv ---------------------------------------------------------- It used a bare select() and returned the raw DB row, while memory.list and memory.search already projected an explicit 9-field shape. On a ~13k-char memory those two internal columns were 55% of the response and pushed it past the MCP tool-output cap, so large memories could not be fetched inline at all. memory.get now returns the same 9 fields as its siblings; user_id is still selected for the authorization check and stripped before responding. memory.patch ------------ memory.update only accepts full replacement, so adding one line to a large document meant resending the whole document — expensive enough that edits were being skipped rather than risk silently truncating shared team documents. memory.patch replaces one exact occurrence of old_string. An absent or ambiguous match is an error, never a silent no-op and never an arbitrary pick; that refusal is what makes the operation safe to hand to an agent. The semantics live in lib/memory-patch.ts as a pure function, free of DB and auth, so both surfaces share them. Shared mutation layer --------------------- The MCP tools and the Web UI Server Actions each reimplemented authorize -> mutate -> re-embed -> CAS -> audit, and had drifted. Both now route through lib/memory-mutations.ts. BEHAVIOUR CHANGE: memory.delete over MCP skipped the project ACL whenever the caller authored the row, so a memory written while a share was rw stayed deletable by its author after an owner downgraded that share to ro. memory.update and the whole Web UI always checked. Authoring a row now grants no standing write privilege on any path. The one deliberate difference between the surfaces is injected as a ProjectResolver: MCP refuses an unknown project key so an agent cannot spawn near-miss projects off a typo, while the Web UI creates one because a person typing a name into a form means to. Tests and lint -------------- Adds vitest. The integration tests run against a real Postgres rather than a mocked DB. The embedder sidecar is the only stub and it is deterministic per-text, so re-embedding is verified by asserting the stored vector actually changed rather than that a mock was called. One test pins that content_tsv is a generated column and therefore cannot rot after a patch — only the embedding needs an explicit recompute. pnpm lint previously dropped into an interactive `next lint` setup prompt and exited 1; ESLint had never been configured here. Replaced with the ESLint CLI and a flat config bridging eslint-config-next through FlatCompat. Clean at --max-warnings=0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
78 lines
2.8 KiB
TypeScript
78 lines
2.8 KiB
TypeScript
import { describe, expect, test } from "vitest";
|
|
import { applyPatch } from "@/lib/memory-patch";
|
|
|
|
describe("applyPatch", () => {
|
|
test("replaces an old_string that occurs exactly once", () => {
|
|
const result = applyPatch("alpha beta gamma", "beta", "BETA");
|
|
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) expect(result.content).toBe("alpha BETA gamma");
|
|
});
|
|
|
|
test("refuses when old_string is absent, rather than silently doing nothing", () => {
|
|
const result = applyPatch("alpha beta gamma", "delta", "DELTA");
|
|
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.error).toMatch(/not found/i);
|
|
});
|
|
|
|
test("refuses when old_string is ambiguous, and reports the match count", () => {
|
|
const result = applyPatch("x marks the spot, x marks it twice", "x", "y");
|
|
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) {
|
|
expect(result.error).toMatch(/2/);
|
|
expect(result.error).toMatch(/match/i);
|
|
}
|
|
});
|
|
|
|
test("treats old_string literally, not as a regular expression", () => {
|
|
// A naive RegExp implementation would match "axb" here.
|
|
const result = applyPatch("axb and a.b", "a.b", "REPLACED");
|
|
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) expect(result.content).toBe("axb and REPLACED");
|
|
});
|
|
|
|
test("replaces a multi-line old_string, preserving surrounding text", () => {
|
|
const content = "## HEADING\n- one\n- two\n\n## OTHER\n";
|
|
const result = applyPatch(content, "## HEADING\n- one", "## HEADING\n- zero\n- one");
|
|
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) {
|
|
expect(result.content).toBe("## HEADING\n- zero\n- one\n- two\n\n## OTHER\n");
|
|
}
|
|
});
|
|
|
|
test("rejects a patch whose result would exceed the 64,000-char content limit", () => {
|
|
// The anchor must be unique, or the ambiguity check fires first and
|
|
// this stops testing the length limit at all.
|
|
const content = "A".repeat(63_950) + "ANCHOR";
|
|
const result = applyPatch(content, "ANCHOR", "B".repeat(100));
|
|
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.error).toMatch(/64,?000|limit/i);
|
|
});
|
|
|
|
test("rejects a no-op patch where new_string equals old_string", () => {
|
|
const result = applyPatch("alpha beta", "beta", "beta");
|
|
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.error).toMatch(/identical|no-op|unchanged/i);
|
|
});
|
|
|
|
test("allows a patch that deletes text by replacing with an empty string", () => {
|
|
const result = applyPatch("keep this, drop this", ", drop this", "");
|
|
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) expect(result.content).toBe("keep this");
|
|
});
|
|
|
|
test("rejects a patch that would empty the memory entirely", () => {
|
|
const result = applyPatch("all of it", "all of it", "");
|
|
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok) expect(result.error).toMatch(/empty/i);
|
|
});
|
|
});
|