Files
shared-memory/apps/web/app/(authed)/settings/tokens/page.tsx
shadowdaoandClaude Opus 5 c3bbea5134 feat: add memory.patch, trim memory.get, unify the memory write path
memory.get no longer returns the embedding and content_tsv
----------------------------------------------------------
It used a bare select() and returned the raw DB row, while memory.list
and memory.search already projected an explicit 9-field shape. On a
~13k-char memory those two internal columns were 55% of the response
and pushed it past the MCP tool-output cap, so large memories could not
be fetched inline at all. memory.get now returns the same 9 fields as
its siblings; user_id is still selected for the authorization check and
stripped before responding.

memory.patch
------------
memory.update only accepts full replacement, so adding one line to a
large document meant resending the whole document — expensive enough
that edits were being skipped rather than risk silently truncating
shared team documents.

memory.patch replaces one exact occurrence of old_string. An absent or
ambiguous match is an error, never a silent no-op and never an
arbitrary pick; that refusal is what makes the operation safe to hand
to an agent. The semantics live in lib/memory-patch.ts as a pure
function, free of DB and auth, so both surfaces share them.

Shared mutation layer
---------------------
The MCP tools and the Web UI Server Actions each reimplemented
authorize -> mutate -> re-embed -> CAS -> audit, and had drifted. Both
now route through lib/memory-mutations.ts.

BEHAVIOUR CHANGE: memory.delete over MCP skipped the project ACL
whenever the caller authored the row, so a memory written while a share
was rw stayed deletable by its author after an owner downgraded that
share to ro. memory.update and the whole Web UI always checked.
Authoring a row now grants no standing write privilege on any path.

The one deliberate difference between the surfaces is injected as a
ProjectResolver: MCP refuses an unknown project key so an agent cannot
spawn near-miss projects off a typo, while the Web UI creates one
because a person typing a name into a form means to.

Tests and lint
--------------
Adds vitest. The integration tests run against a real Postgres rather
than a mocked DB. The embedder sidecar is the only stub and it is
deterministic per-text, so re-embedding is verified by asserting the
stored vector actually changed rather than that a mock was called. One
test pins that content_tsv is a generated column and therefore cannot
rot after a patch — only the embedding needs an explicit recompute.

pnpm lint previously dropped into an interactive `next lint` setup
prompt and exited 1; ESLint had never been configured here. Replaced
with the ESLint CLI and a flat config bridging eslint-config-next
through FlatCompat. Clean at --max-warnings=0.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-11 14:58:11 -07:00

268 lines
8.9 KiB
TypeScript

import { revalidatePath } from "next/cache";
import { and, asc, desc, eq } from "drizzle-orm";
import { auth } from "@/auth";
import { env } from "@/lib/env";
import { db } from "@/lib/db/client";
import { cliTokens, projects, users } from "@/lib/db/schema";
import {
mintCliToken,
revokeCliToken,
CLI_TOKEN_TTL_SECONDS,
} from "@/lib/auth/cli-token";
import { ProjectKey } from "@shared-memory/schemas";
import { Container, PageHeader } from "@/app/_components/ui/container";
import { Card, CardBody, CardHeader } from "@/app/_components/ui/card";
import { Badge } from "@/app/_components/ui/badge";
import { EmptyState } from "@/app/_components/ui/empty-state";
import TokensManager, { type CreateTokenState } from "./tokens-manager";
export const dynamic = "force-dynamic";
async function createTokenAction(
_prev: CreateTokenState,
formData: FormData,
): Promise<CreateTokenState> {
"use server";
try {
const session = await auth();
if (!session?.user?.id) {
return { token: null, error: "not authenticated", projectKey: null };
}
const name = String(formData.get("name") ?? "").trim() || `Token ${new Date().toISOString().slice(0, 10)}`;
// Optional pin-to-project. The token JWT itself does NOT need a project
// claim — pinning is purely a UX shortcut so the generated `claude mcp
// add` snippet bakes in `X-Project-Key: <key>` and every call from
// that client lands on the right project by default.
const rawProject = String(formData.get("projectKey") ?? "").trim();
let projectKey: string | null = null;
if (rawProject.length > 0) {
const parsed = ProjectKey.safeParse(rawProject);
if (!parsed.success) {
return {
token: null,
error: `invalid project key: ${parsed.error.issues.map((i) => i.message).join("; ")}`,
projectKey: null,
};
}
// Cross-check the project belongs to this user (defense in depth —
// the dropdown is built from the user's projects, but the form is
// re-submittable so don't trust the value).
const found = await db
.select({ key: projects.key })
.from(projects)
.where(and(eq(projects.userId, session.user.id), eq(projects.key, parsed.data)))
.limit(1);
if (!found[0]) {
return {
token: null,
error: `unknown project '${parsed.data}'`,
projectKey: null,
};
}
projectKey = found[0].key;
}
const userRow = await db
.select({
oidcIss: users.oidcIss,
oidcSub: users.oidcSub,
email: users.email,
name: users.name,
})
.from(users)
.where(eq(users.id, session.user.id))
.limit(1);
const u = userRow[0];
if (!u) return { token: null, error: "user row not found", projectKey: null };
const minted = await mintCliToken(
{
userId: session.user.id,
oidcIss: u.oidcIss,
oidcSub: u.oidcSub,
email: u.email,
name: u.name,
},
{ tokenName: name },
);
revalidatePath("/settings/tokens");
return { token: minted.token, error: null, projectKey };
} catch (e) {
return {
token: null,
error: e instanceof Error ? e.message : "unknown error",
projectKey: null,
};
}
}
async function revokeTokenAction(formData: FormData) {
"use server";
const session = await auth();
if (!session?.user?.id) throw new Error("not authenticated");
const tokenId = String(formData.get("tokenId") ?? "");
await revokeCliToken(session.user.id, tokenId);
revalidatePath("/settings/tokens");
}
/**
* Points people at the plugin before they mint a token they don't need.
*
* Rendered only when this instance knows which marketplace it's published
* from — showing a copyable command that points nowhere is worse than showing
* nothing.
*/
function PluginHint({
marketplaceUrl,
marketplaceName,
}: {
marketplaceUrl: string | undefined;
marketplaceName: string;
}) {
if (!marketplaceUrl) return null;
return (
<Card className="mb-6">
<CardHeader className="text-sm font-medium text-fg">
If this machine has a browser, install the plugin instead
</CardHeader>
<CardBody>
<p className="text-sm text-fg-muted mb-3">
The plugin signs you in through {" "}
<span className="text-fg">your usual login</span>, so there&apos;s no
token to copy, store, or rotate. Generate a token below only when a
browser sign-in isn&apos;t possible.
</p>
<pre className="text-xs !whitespace-pre-wrap !break-all select-all">
{[
`claude plugin marketplace add ${marketplaceUrl}`,
`claude plugin install shared-memory@${marketplaceName}`,
].join("\n")}
</pre>
</CardBody>
</Card>
);
}
export default async function TokensPage() {
const session = await auth();
const userId = session!.user.id;
const [tokens, projectRows] = await Promise.all([
db
.select({
id: cliTokens.id,
name: cliTokens.name,
jti: cliTokens.jti,
createdAt: cliTokens.createdAt,
lastUsedAt: cliTokens.lastUsedAt,
expiresAt: cliTokens.expiresAt,
revokedAt: cliTokens.revokedAt,
})
.from(cliTokens)
.where(eq(cliTokens.userId, userId))
.orderBy(desc(cliTokens.createdAt)),
db
.select({
key: projects.key,
displayName: projects.displayName,
})
.from(projects)
.where(eq(projects.userId, userId))
.orderBy(asc(projects.key)),
]);
const active = tokens.filter((t) => !t.revokedAt && t.expiresAt > new Date());
const inactive = tokens.filter((t) => t.revokedAt || t.expiresAt <= new Date());
const ttlDays = Math.floor(CLI_TOKEN_TTL_SECONDS / 86400);
return (
<Container className="pt-6 max-w-3xl">
<PageHeader
title="CLI tokens"
description={`For machines that can't complete a browser sign-in — headless containers, CI runners, sealed devboxes. Tokens last ${ttlDays} days and can be revoked one at a time.`}
/>
<PluginHint
marketplaceUrl={env().PLUGIN_MARKETPLACE_URL}
marketplaceName={env().PLUGIN_MARKETPLACE_NAME}
/>
<Card className="mb-6">
<CardHeader className="text-sm font-medium text-fg">Generate a new token</CardHeader>
<CardBody>
<TokensManager
action={createTokenAction}
ttlDays={ttlDays}
projects={projectRows.map((p) => ({
key: p.key,
displayName: p.displayName,
}))}
publicUrl={env().PUBLIC_URL}
/>
</CardBody>
</Card>
<h2 className="text-sm font-medium text-fg-muted mt-8 mb-2">Active tokens</h2>
{active.length === 0 ? (
<EmptyState title="No active tokens" description="Generate one above to connect a headless client." />
) : (
<Card>
{active.map((t, i) => (
<div
key={t.id}
className={`px-4 py-3 flex items-center gap-3 ${i > 0 ? "border-t border-border" : ""}`}
>
<div className="flex-1 min-w-0">
<div className="text-sm text-fg truncate">{t.name}</div>
<div className="text-xs text-fg-subtle">
Created {new Date(t.createdAt).toLocaleDateString()} ·{" "}
{t.lastUsedAt
? `last used ${new Date(t.lastUsedAt).toLocaleString()}`
: "never used"}
{" · "}expires {new Date(t.expiresAt).toLocaleDateString()}
</div>
</div>
<form action={revokeTokenAction}>
<input type="hidden" name="tokenId" value={t.id} />
<button
type="submit"
className="text-xs text-danger hover:underline"
>
Revoke
</button>
</form>
</div>
))}
</Card>
)}
{inactive.length > 0 ? (
<>
<h2 className="text-sm font-medium text-fg-muted mt-8 mb-2">Revoked / expired</h2>
<Card>
{inactive.map((t, i) => (
<div
key={t.id}
className={`px-4 py-3 flex items-center gap-3 ${i > 0 ? "border-t border-border" : ""}`}
>
<div className="flex-1 min-w-0">
<div className="text-sm text-fg-muted truncate">{t.name}</div>
<div className="text-xs text-fg-subtle">
{t.revokedAt
? `Revoked ${new Date(t.revokedAt).toLocaleString()}`
: `Expired ${new Date(t.expiresAt).toLocaleString()}`}
</div>
</div>
<Badge tone="danger">{t.revokedAt ? "revoked" : "expired"}</Badge>
</div>
))}
</Card>
</>
) : null}
</Container>
);
}