From 23375b6414eb519b3bfecc41810b4f6445464bb4 Mon Sep 17 00:00:00 2001
From: Ken Fallon <ken@fallon.ie>
Date: Thu, 29 Feb 2024 16:10:34 +0100
Subject: [PATCH] Added clarification as to using url

---
 hub/upload.php | 38 ++++++++++++++++++++------------------
 1 file changed, 20 insertions(+), 18 deletions(-)

diff --git a/hub/upload.php b/hub/upload.php
index 7cd307b..b517288 100644
--- a/hub/upload.php
+++ b/hub/upload.php
@@ -123,11 +123,11 @@ include 'header.html';
   <form method="POST" action="upload_confirm.php" enctype="multipart/form-data">
   <table>
     <tr>
-      <td>Host Email (<a href="/request_a_slot.php#email" target="_blank">?</a>):</td>
+      <td>Host Email (<a href="<?php echo "${baseurl}about.html#email"; ?>" target="_blank">?</a>):</td>
       <td><?php echo $email;?></td>
     </tr>
     <tr>
-      <td style="vertical-align:top;">Image: (<a href="/request_a_slot.php#image" target="_blank">?</a>)</td>
+      <td style="vertical-align:top;">Image: (<a href="<?php echo "${baseurl}about.html#image"; ?>" target="_blank">?</a>)</td>
       <td>
       <?php 
       echo "<img src=\"$image_url\" alt=\"host image\" /><br /><small><em>";
@@ -143,11 +143,11 @@ include 'header.html';
       </td>
     </tr>
     <tr>
-      <td><strong>Name/Handle: (<a href="/request_a_slot.php#Name_Handle" target="_blank">?</a>)</strong></td>
+      <td><strong>Name/Handle: (<a href="<?php echo "${baseurl}about.html#Name_Handle"; ?>" target="_blank">?</a>)</strong></td>
       <td><input required type="text" name="host_name" size="40" maxlength="40" placeholder="Enter the name you wish to be know as on HPR" value="<?php echo $host?>"></td>
     </tr>
     <tr>
-      <td><strong>Your Default license: (<a href="/request_a_slot.php#Default_license" target="_blank">?</a>)</strong></td>
+      <td><strong>Your Default license: (<a href="<?php echo "${baseurl}about.html#Default_license"; ?>" target="_blank">?</a>)</strong></td>
       <td>
       <select name="host_license">
         <option value="CC-0" <?php if($license == "CC-0") echo "selected"; ?>>CC-Zero/Public Domain (CC-0)
@@ -161,7 +161,7 @@ include 'header.html';
       </td>
     </tr>
     <tr>
-      <td style="vertical-align:top;">Profile: (<a href="/request_a_slot.php#Profile" target="_blank">?</a>)</td>
+      <td style="vertical-align:top;">Profile: (<a href="<?php echo "${baseurl}about.html#Profile"; ?>" target="_blank">?</a>)</td>
 <!--  TODO https://xing.github.io/wysihtml5/      -->
       <td><textarea name="host_profile" maxlength="2000" rows="10" cols="50" placeholder="Enter some text about yourself with links to your blog or other online presence."><?php echo htmlspecialchars($profile) ?></textarea></td>
     </tr>
@@ -169,21 +169,21 @@ include 'header.html';
   <h2>Please fill in some information about this episode</h2>
   <table>
     <tr>
-      <td><strong>Title(*) (<a href="/request_a_slot.php#Title" target="_blank">?</a>):</strong></td>
+      <td><strong>Title(*) (<a href="<?php echo "${baseurl}about.html#Title"; ?>" target="_blank">?</a>):</strong></td>
       <td><input required type="text" name="title" size="50" maxlength="100" placeholder="Enter a short descriptive title for your show."></td>
     </tr>
     <tr>
-      <td><strong>Summary(*) (<a href="/request_a_slot.php#Short_Summary" target="_blank">?</a>):</strong></td>
+      <td><strong>Summary(*) (<a href="<?php echo "${baseurl}about.html#Short_Summary"; ?>" target="_blank">?</a>):</strong></td>
       <td><input required type="text" name="summary" size="70" maxlength="100" placeholder="This is a short 100 character summary of what your show is about."></td>
     </tr>
     <tr>
-      <td style="vertical-align:top;"><strong>Theme: (<a href="/request_a_slot.php#Theme" target="_blank">?</a>)</strong></td>
+      <td style="vertical-align:top;"><strong>Theme: (<a href="<?php echo "${baseurl}about.html#Theme"; ?>" target="_blank">?</a>)</strong></td>
       <td>
-        Please <strong>do not</strong> add a theme to your show: <small>See <a href="http://hackerpublicradio.org/pipermail/hpr_hackerpublicradio.org/2021-November/015100.html">Policy Decision</a> for more information.</small><br />
+        Please <strong>do not</strong> add a theme to your show: <small>See <a href="https://lists.hackerpublicradio.com/pipermail/hpr/2021-November/004328.html">Policy Decision</a> for more information.</small><br />
       </td>
     </tr>
     <tr>
-      <td><strong>Explicit: (<a href="/request_a_slot.php#Explicit" target="_blank">?</a>)</strong></td>
+      <td><strong>Explicit: (<a href="<?php echo "${baseurl}about.html#Explicit"; ?>" target="_blank">?</a>)</strong></td>
       <td>
         Is the show <em>Explicit</em> ?:
         <input required type="radio" name="explicit" value="Yes">Yes 
@@ -192,7 +192,7 @@ include 'header.html';
       </td>
     </tr>
     <tr>
-      <td><strong>License: (<a href="/request_a_slot.php#License" target="_blank">?</a>)</strong></td>
+      <td><strong>License: (<a href="<?php echo "${baseurl}about.html#License"; ?>" target="_blank">?</a>)</strong></td>
       <td>
         <select name="license">
             <option value="CC-BY-SA" selected>CC-BY-SA</option>
@@ -207,11 +207,11 @@ include 'header.html';
       </td>
     </tr>
     <tr>
-      <td><strong>Notes(*) (<a href="/request_a_slot.php#show_notes" target="_blank">?</a>):</strong></td>
+      <td><strong>Notes(*) (<a href="<?php echo "${baseurl}about.html#show_notes"; ?>" target="_blank">?</a>):</strong></td>
       <td><textarea required name="notes" maxlength="40000" rows="20" cols="70" placeholder="Please add your show notes here." ></textarea></td>
     </tr>
     <tr>
-      <td>Format: (<a href="/request_a_slot.php#shownotes_format" target="_blank">?</a>)</td>
+      <td>Format: (<a href="<?php echo "${baseurl}about.html#shownotes_format"; ?>" target="_blank">?</a>)</td>
       <td>
         <small>What format if any did you just use in the show notes above ?</small><br />
         <select name="shownotes_format">
@@ -225,7 +225,7 @@ include 'header.html';
       </td>
     </tr>
     <tr>
-      <td>Series: (<a href="/request_a_slot.php#series" target="_blank">?</a>)</td>
+      <td>Series: (<a href="<?php echo "${baseurl}about.html#series"; ?>" target="_blank">?</a>)</td>
       <td>
         <?php
         $result = mysqli_query($connection, "SELECT id, name FROM miniseries WHERE private=0 ORDER BY name ASC");
@@ -239,22 +239,24 @@ include 'header.html';
       </td>
     </tr>
     <tr>
-      <td>Tags: (<a href="/request_a_slot.php#tags" target="_blank">?</a>)</td>
+      <td>Tags: (<a href="<?php echo "${baseurl}about.html#tags"; ?>" target="_blank">?</a>)</td>
       <td><input required type="text" name="tags" size="70" maxlength="100" placeholder="Add a list of comma separated tags." /><br />
       Add a list of <strong>comma separated</strong> tags.<br />
       If you can provide tags for your show that would be appreciated; you are certainly the best judge of what makes good tags, but if not then a volunteer will add them later.
       </td>
     </tr>
     <tr>
-      <td style="vertical-align:top;"><strong>Upload Method: (<a href="/request_a_slot.php#upload_method" target="_blank">?</a>)</strong></td>
+      <td style="vertical-align:top;"><strong>Upload Method: (<a href="<?php echo "${baseurl}about.html#upload_method"; ?>" target="_blank">?</a>)</strong></td>
       <td>
         <em>You have the choice of the following upload options:</em> <br />
         <p>
-        <strong>1. Upload now</strong> via this browser: (<a href="/request_a_slot.php#browser" target="_blank">?</a>)<br />
+        <strong>1. Upload now</strong> via this browser: (<a href="<?php echo "${baseurl}about.html#browser"; ?>" target="_blank">?</a>)<br />
         <input type="file" multiple="multiple" name="media_files[]" title="select if using the http upload option" />
         </p>
         <p>
-        <strong>2. Provide a url</strong> for us to get it from: (<a href="/request_a_slot.php#url" target="_blank">?</a>)<br />
+        <strong>2. Provide a url</strong> we we can directly download it from: (<a href="<?php echo "${baseurl}about.html#url"; ?>" target="_blank">?</a>)<br />
+        This must be accessable using a curl or wget command.<br />
+        Please avoid services that require login or downloading via a browser.<br />
         <input type="url" size="30"  name="url" placeholder="https://example.com/hpr9999.flac">
         </p>
         <p>