Host abstraction, phase 1b: container lifecycle and exit watching behind the host layer #75

Merged

jknapp merged 4 commits from refactor/host-lifecycle into main 2026-11-13 22:29:32 +00:00

Conversation 0 Commits 4 Files Changed 29

+852 -526

4 Commits

Author	SHA1	Message	Date
shadowdaoandClaude Opus 5.5	7c004fed46	Move the project container lifecycle behind host::lifecycle::ProjectHost ... Phase 1b of the AWS host work. ProjectHost (one Docker variant) owns ensure_started (find → snapshot-and-recreate → create → start, moved verbatim from start_project_container_locked), find_current, stop, remove, discard_project_state and remove_legacy_leftovers. Start, stop, Reset, remove and reconcile keep only host-neutral steps and ask the host for the rest; the started ContainerTarget now flows to the auth bridge, marketplace sync and Bedrock credential sync. - create_container_for_project and default_docker_socket move to docker/ (migration used both; its duplicate socket helper is gone). - sync_bedrock_credentials and marketplace::spawn_project_sync take a ContainerTarget. - New boundary test: no lifecycle calls or ContainerTarget::docker(id) in non-test code outside host/ and docker/ (migration excepted). - Ignored live test round-trips a throwaway project container through the host; passes against Docker 29.9.3 and leaves nothing behind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-13 11:22:24 -08:00
shadowdao	45e55b5f7c	Merge branch 'worktree-agent-a50fe8b64e4be72dc' into refactor/host-lifecycle	2026-11-13 11:18:25 -08:00
shadowdaoandClaude Opus 5.5	83d63e756d	Host phase 1a follow-up: pass ContainerTarget instead of container ids ... Functions that took a bare container id and built `ContainerTarget::docker(id)` internally now take a target, and their callers resolve one from the project (`ContainerTarget::for_project`) or carry the one they already hold. Long-lived holders (auth bridge poller, browser-view proxy/session, file viewer commands) store the target. Collapses the string/target wrapper pairs: `detect::detect` now takes a target (`detect_in` removed) and `tunnel_connection_with_prelude` takes a target (`tunnel_into_with_prelude` removed). No behaviour change. Two temporary Docker constructions remain on the container-start path, marked "phase 1b": the auth bridge start in `start_project_container_locked` and `marketplace::spawn_project_sync`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-13 11:18:03 -08:00
shadowdaoandClaude Opus 5.5	cc973c8291	Move the container exit watcher's Docker calls behind host::watch ... container_watch keeps all of its logic (sweep, compare-and-set settle, backoff, cancellation) but no longer touches bollard: reachability, the death stream and the positive-exit check come from host::watch::ExitSource and ContainerTarget::has_exited, implemented for Docker in docker/events.rs. An AWS host can supply deaths by polling. container_watch.rs leaves the boundary test's allowlist. Verified with the live end-to-end watcher test against a real daemon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-13 11:14:58 -08:00