Test-feedback fixes: hosts settings layout, deploy/join for anyone, Docker status, bundled SSM plugin #86

Merged
jknapp merged 13 commits from fix/hosts-ui into main 2026-11-17 23:08:57 +00:00
Owner

Fixes from hands-on testing of Settings → Hosts on Linux.

  • Layout: the Settings sidebar is 224–320 px wide and no button could wrap, so buttons ran past their box. Button and StatusIndicator get an optional wrap setting. The host, environment, region and progress rows wrap, and ARNs, names and run summaries break instead of spilling over. Policy files show as a per-file "Copy " grid (one column when narrow). Code blocks scroll sideways and modal footers wrap.
  • Deploy for anyone who can: "Deploy a new environment" appears after any scan, not only when the permission check confirmed environment-admin rights. If the check didn't confirm them, a note says the deploy stops with AWS's message when a permission is missing. The policy files and "Request an environment from an admin…" move under a "Not an admin?" disclosure.
  • Join for anyone: anyone can join, or change EC2 capacity, directly. "Save an onboarding bundle for an admin…" remains the alternative. The backend never checked the tier, so only a comment changed.
  • When AWS refuses: the message names the denied action (e.g. "AWS denied s3:CreateBucket: …"), and the deploy and join windows, plus a failed run's progress row, offer to save a bundle for an admin.

Tests: vitest 1,380 passed, cargo test --locked passed, tsc and build clean. The narrow layout is checked by class assertions only (jsdom has no layout), so it needs a look in the preview build.

Also in this PR (combined for one preview build)

  • Bundled Session Manager plugin — merged from PR #85 (built from AWS's Apache-2.0 source, pinned; see #85 for details). Merging this PR merges #85.
  • Docker status: a new check_docker_status command classifies Docker as running / not running / no permission / not installed (11 unit tests). The dialog changes per state, with per-OS guidance (Linux systemctl/journalctl, including rootless; Docker Desktop on macOS/Windows; usermod -aG docker for permission), shows the endpoint tried (DOCKER_HOST when set), notes that AWS projects still work, and closes itself when Docker comes up. The top bar, welcome checklist and Docker settings use the same wording.

🤖 Generated with Claude Code

Fixes from hands-on testing of Settings → Hosts on Linux. - **Layout:** the Settings sidebar is 224–320 px wide and no button could wrap, so buttons ran past their box. `Button` and `StatusIndicator` get an optional `wrap` setting. The host, environment, region and progress rows wrap, and ARNs, names and run summaries break instead of spilling over. Policy files show as a per-file "Copy <file>" grid (one column when narrow). Code blocks scroll sideways and modal footers wrap. - **Deploy for anyone who can:** "Deploy a new environment" appears after any scan, not only when the permission check confirmed environment-admin rights. If the check didn't confirm them, a note says the deploy stops with AWS's message when a permission is missing. The policy files and "Request an environment from an admin…" move under a "Not an admin?" disclosure. - **Join for anyone:** anyone can join, or change EC2 capacity, directly. "Save an onboarding bundle for an admin…" remains the alternative. The backend never checked the tier, so only a comment changed. - **When AWS refuses:** the message names the denied action (e.g. "AWS denied s3:CreateBucket: …"), and the deploy and join windows, plus a failed run's progress row, offer to save a bundle for an admin. Tests: vitest 1,380 passed, `cargo test --locked` passed, tsc and build clean. The narrow layout is checked by class assertions only (jsdom has no layout), so it needs a look in the preview build. ## Also in this PR (combined for one preview build) - **Bundled Session Manager plugin** — merged from PR #85 (built from AWS's Apache-2.0 source, pinned; see #85 for details). Merging this PR merges #85. - **Docker status:** a new `check_docker_status` command classifies Docker as running / not running / no permission / not installed (11 unit tests). The dialog changes per state, with per-OS guidance (Linux systemctl/journalctl, including rootless; Docker Desktop on macOS/Windows; `usermod -aG docker` for permission), shows the endpoint tried (`DOCKER_HOST` when set), notes that AWS projects still work, and closes itself when Docker comes up. The top bar, welcome checklist and Docker settings use the same wording. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
jknapp added 1 commit 2026-11-17 20:17:13 +00:00
fix(aws): settings layout and deploy for anyone who can
Build App (Preview) / compute-version (pull_request) Successful in 5s
Secret Scan / scan (push) Successful in 23s
Secret Scan / scan (pull_request) Successful in 9s
Build App (Preview) / create-release (pull_request) Successful in 3s
Build App (Preview) / build-macos (pull_request) Successful in 6m24s
Build App (Preview) / build-windows (pull_request) Successful in 11m28s
Build App (Preview) / build-linux (pull_request) Successful in 23m6s
Build App (Preview) / test (pull_request) Successful in 26m21s
Build App (Preview) / prune-previews (pull_request) Successful in 5s
a93a8135be
Hosts settings live in a 224-320px sidebar; nowrap buttons and long ARNs,
policy names and run summaries overflowed it. Button and StatusIndicator get
an opt-in wrap prop; host, environment, progress and policy rows wrap with
min-w-0 children; policy copy buttons sit in an auto-fill grid; pre blocks
scroll; the Modal footer wraps.

Deploy a new environment and self-join are offered to anyone after a scan.
When the permission check didn't confirm environment-admin rights a note
says AWS has the last word, and the policies and environment request sit
under a 'Not an admin?' disclosure. The boundary note shows whenever the
boundary is missing. AWS refusals show AWS's message (awsErrorMessage now
names the denied action) and offer the admin bundle: in the deploy and join
modals, and under a failed deploy/join run whose output reads as denied.
The backend already had no tier check on onboard_aws_user; its comment is
corrected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jknapp added 1 commit 2026-11-17 20:19:06 +00:00
fix(aws): review fixes for hosts settings
Secret Scan / scan (push) Successful in 8s
Build App (Preview) / compute-version (pull_request) Successful in 6s
Secret Scan / scan (pull_request) Successful in 14s
Build App (Preview) / create-release (pull_request) Successful in 2s
Build App (Preview) / test (pull_request) Successful in 9m36s
Build App (Preview) / build-macos (pull_request) Successful in 6m14s
Build App (Preview) / build-windows (pull_request) Successful in 11m11s
Build App (Preview) / build-linux (pull_request) Successful in 21m26s
Build App (Preview) / prune-previews (pull_request) Successful in 3s
90fae8451f
- Runs carry an explicit kind (deploy, follow, repair, update, destroy,
  onboard, push, boundary); the admin-bundle offer after an AWS refusal
  keys on kind deploy/onboard, not the label, so a refused follow of an
  existing environment's deploy no longer offers a new-environment bundle.
- looksDenied no longer matches a bare "explicit deny" (SCP and bucket
  policy denies aren't fixed by a bundle); the hint says it may need an admin.
- The aws sso login hint breaks long profile names.
- The "Not an admin?" disclosure shows a ▸/▾ marker like the Environments
  toggle.
- Note: the previous commit's Modal footer flex-wrap is app-wide (every
  modal's buttons now wrap when the dialog is narrow); kept deliberately.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jknapp added 9 commits 2026-11-17 20:26:38 +00:00
scripts/fetch-ssm-plugin.sh (Linux/macOS, incl. universal via lipo) and
scripts/fetch-ssm-plugin.ps1 (Windows) download plugin 1.2.896.0 from AWS's
S3 path into app/src-tauri/binaries/session-manager-plugin-<triple>[.exe],
checking a pinned SHA-256 of each artifact before extraction, AWS's GPG
signature on the Linux .deb (key committed, fingerprint pinned) or AWS's
Authenticode signature on Windows, and a pinned SHA-256 of the binary.

THIRD_PARTY_NOTICES reproduces the plugin's LICENSE (Apache-2.0), NOTICE
and AWS's THIRD-PARTY statement. The binaries directory is never committed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bundle.externalBin ships the plugin beside the app binary (usr/bin in the
AppImage, Contents/MacOS, the Windows install dir) and THIRD_PARTY_NOTICES as
a resource. find_plugin() now resolves TRIPLEC_SSM_PLUGIN, then the bundled
sidecar next to current_exe(), then PATH and AWS's install locations, then
the install hint; the order is unit-tested against temp dirs.

tauri-build fails any build whose externalBin file is missing, so build.rs
writes a marked placeholder in debug builds (cargo test/check, tauri dev)
and refuses a missing file or a placeholder in release builds.
find_plugin() skips the placeholder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both build workflows fetch the pinned plugin before tauri build on Linux,
macOS (universal: both slices plus the lipo'd file) and Windows. The test
job needs no fetch: debug builds get build.rs's placeholder.

finalize-appimage.sh asserts usr/bin/session-manager-plugin is a running
ELF and THIRD_PARTY_NOTICES is in the image.

Windows: the plugin ships under AWS's Authenticode signature and is not
re-signed (Tauri skips a sidecar signtool verify accepts).
windows-sign.ps1 refuses it if it is ever presented rather than letting the
allowlist skip it unsigned; windows-verify-signatures.ps1 requires it in
the MSI, valid, timestamped and signed by Amazon Web Services, Inc.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
build: build session-manager-plugin from source, not AWS's binaries
Build App (Preview) / compute-version (pull_request) Successful in 5s
Secret Scan / scan (push) Successful in 8s
Secret Scan / scan (pull_request) Successful in 7s
Build App (Preview) / create-release (pull_request) Successful in 2s
Build App (Preview) / build-macos (pull_request) Successful in 6m42s
Build App (Preview) / build-linux (pull_request) Successful in 12m41s
Build App (Preview) / build-windows (pull_request) Successful in 13m57s
Build App (Preview) / test (pull_request) Successful in 23m29s
Build App (Preview) / prune-previews (pull_request) Successful in 3s
5b23dc1aec
AWS ships its prebuilt plugin as "AWS Content" under the AWS Customer
Agreement; the source is Apache-2.0. Replace the binary fetch with
scripts/build-ssm-plugin.sh (any triple, cross-compiles; universal via
lipo) and build-ssm-plugin.ps1 (Windows runner):

- source: tag 1.2.896.0 at commit 6430675a, GitHub archive SHA-256
  checked before extraction;
- Go 1.26.11 from go.dev, published SHA-256 checked before use;
- the repo's own build (GOPATH mode, vendored deps, -s -w,
  sessionmanagerplugin-main) with VERSION stamped to the tag, plus
  -trimpath, no VCS stamp, empty build id, CGO off;
- output must equal a pinned SHA-256 per target (reproducible builds).

Each platform job builds its own targets. Windows: the exe is now ours
and unsigned, so windows-sign.ps1 allowlists it and
windows-verify-signatures.ps1 requires it signed by the installer's own
certificate in the MSI and NSIS. THIRD_PARTY_NOTICES now carries the
source's LICENSE/NOTICE/THIRD-PARTY, the commit, every linked vendored
module's licence and Go's. AWS's GPG key and the AWS-signature checks
are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fix(ssm-plugin): review fixes for the source build and signing checks
Secret Scan / scan (push) Successful in 11s
Build App (Preview) / compute-version (pull_request) Successful in 11s
Secret Scan / scan (pull_request) Successful in 12s
Build App (Preview) / create-release (pull_request) Successful in 1s
Build App (Preview) / build-macos (pull_request) Successful in 6m42s
Build App (Preview) / test (pull_request) Successful in 15m11s
Build App (Preview) / build-linux (pull_request) Successful in 13m45s
Build App (Preview) / build-windows (pull_request) Successful in 13m59s
Build App (Preview) / prune-previews (pull_request) Successful in 2s
b62f472d79
- build-ssm-plugin.{sh,ps1}: skip the vendored SDK's Java codegen/ and
  test snapshot/ trees when extracting (codegen paths reach 258 chars,
  past MAX_PATH on Windows); the .ps1 works under a short
  %SystemDrive%\ssm-<8hex> root and falls back to rd /s /q on cleanup.
  Pinned output hashes unchanged (rebuilt every target).
- build-ssm-plugin.sh: the header no longer claims a git commit-id check.
- windows-verify-signatures.ps1: compare signer Subject + Issuer, not the
  thumbprint (Artifact Signing certificates rotate); require
  THIRD_PARTY_NOTICES in the MSI.
- windows-sign.ps1: allowlist exactly
  src-tauri\binaries\session-manager-plugin-x86_64-pc-windows-msvc.exe.
- macOS jobs: check the .app carries the two-slice plugin and
  Contents/Resources/THIRD_PARTY_NOTICES.
- CLAUDE.md: a local release build must re-run the build script.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fix(ssm-plugin): lock down the Windows work root; re-hash the output in place
Secret Scan / scan (push) Successful in 14s
Build App (Preview) / compute-version (pull_request) Successful in 14s
Secret Scan / scan (pull_request) Successful in 7s
Build App (Preview) / test (pull_request) Successful in 9m25s
Build App (Preview) / create-release (pull_request) Successful in 1s
Build App (Preview) / build-macos (pull_request) Successful in 6m40s
Build App (Preview) / build-linux (pull_request) Successful in 17m3s
Build App (Preview) / build-windows (pull_request) Successful in 13m53s
Build App (Preview) / prune-previews (pull_request) Successful in 2s
614e89bef4
The short %SystemDrive%\ssm-<8hex> root inherited the drive root's ACL,
where Authenticated Users can write, so another local user could swap the
source, toolchain or output between verification and use. Right after
creating it, icacls removes inheritance and grants full control only to
SYSTEM, Administrators and the current user's SID; failure aborts. It is
mandatory on Windows and skipped only off Windows (the pwsh test path).
The binary is hashed again at its final location.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
feat(docker): tell "not running" apart from "not installed"
Secret Scan / scan (push) Successful in 15s
Build App (Preview) / compute-version (pull_request) Successful in 7s
Secret Scan / scan (pull_request) Successful in 15s
Build App (Preview) / test (pull_request) Successful in 11m20s
Build App (Preview) / create-release (pull_request) Successful in 5s
Build App (Preview) / build-macos (pull_request) Successful in 6m51s
Build App (Preview) / build-linux (pull_request) Successful in 13m0s
Build App (Preview) / build-windows (pull_request) Successful in 13m49s
Build App (Preview) / prune-previews (pull_request) Successful in 2s
73eb507cfe
The app told a user whose Docker daemon had hit systemd start-limit-hit
to install Docker. New check_docker_status command classifies the ping
failure (io error kind in the bollard/hyper chain) plus cheap installed-
ness probes into running / not_running / no_permission / not_installed,
reports the endpoint tried (DOCKER_HOST respected), and the dialog, top
bar, welcome checklist and Docker settings show per-state guidance. The
dialog updates live from polling and closes when Docker comes up.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jknapp changed title from Hosts settings: fit the narrow sidebar; deploy and join without a confirmed admin tier to Test-feedback fixes: hosts settings layout, deploy/join for anyone, Docker status, bundled SSM plugin 2026-11-17 20:26:54 +00:00
jknapp added 1 commit 2026-11-17 22:22:30 +00:00
fix(aws): port mappings reach [::1]-only servers, never fail silently; clearer silent-agent error
Secret Scan / scan (push) Successful in 13s
Build App (Preview) / compute-version (pull_request) Successful in 8s
Secret Scan / scan (pull_request) Successful in 9s
Build App (Preview) / create-release (pull_request) Successful in 12s
Build App (Preview) / build-macos (pull_request) Successful in 7m30s
Build App (Preview) / test (pull_request) Successful in 11m4s
Build App (Preview) / build-windows (pull_request) Successful in 14m12s
Build App (Preview) / build-linux (pull_request) Successful in 15m52s
Build App (Preview) / prune-previews (pull_request) Successful in 5s
ff872f34a1
Port mappings (AWS):
- In the workspace each connection now picks 127.0.0.1 or [::1] from
  /proc/net/tcp{,6} (tunnel::mapping_command): a server bound to ::1 only
  (Vite, Node `localhost`) was unreachable through a mapping. No probe
  connection is made; nothing found falls back to 127.0.0.1.
- The first socat "Connection refused" per mapping is a `ports`
  workspace-warning: "nothing is listening on port N in the workspace
  (127.0.0.1 or ::1)".
- open_for_project warns instead of returning None when a Running project's
  mappings can't be opened (no tunnel, or the tunnel changed under the open).
- Info/warn logs at each step (mappings read, each opened/failed, set closed
  and why) so the next report shows where it stopped.
- Tests: start-path sequence (mapping saved while stopped, tunnel, Running,
  open) with IPv4 and ::1 clients; refusal reported once; never-silent cases;
  an ignored live test against a real agent container (0.0.0.0, [::1] and
  nothing-listening servers).

Silent agent: the error now says the image (named, escaped) may predate the
app's AWS support, that :latest moves only on a release, and to set
Settings → Docker → Custom image to ghcr.io/shadowdao/triple-c-sandbox:edge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jknapp added 1 commit 2026-11-17 22:37:40 +00:00
fix(ports): keep typed port mappings; never save or skip a half-filled row silently
Secret Scan / scan (push) Successful in 31s
Secret Scan / scan (pull_request) Successful in 12s
Build App (Preview) / compute-version (pull_request) Successful in 5s
Build App (Preview) / create-release (pull_request) Successful in 3s
Build App (Preview) / test (pull_request) Successful in 8m21s
Build App (Preview) / build-macos (pull_request) Successful in 7m2s
Build App (Preview) / build-windows (pull_request) Successful in 14m4s
Build App (Preview) / build-linux (pull_request) Successful in 13m16s
Build App (Preview) / prune-previews (pull_request) Successful in 5s
42c329ed24
The empty row's "8080" placeholders looked like a typed 8080 -> 8080, and
+ Add saved it as 0 -> 0 at once; a project refresh with a new-but-equal
array also reset in-progress edits. The editor now keeps ports as text,
saves only complete rows, marks incomplete ones inline, uses word
placeholders, and resyncs only on a by-value change while unfocused. A
connect reports a stored incomplete row as a ports warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jknapp merged commit 8359135432 into main 2026-11-17 23:08:57 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CyberCoveLLC/Triple-C#86