shadowdaoandClaude Sonnet 5
7146f78831
Linux, glibc. The LiveKit SDK's "linux-x64" asset is not actually generic:
it is built on Ubuntu 24.04 and needs GLIBC_2.38 and GLIBCXX_3.4.32, so
linking it on a 22.04 runner fails outright ("undefined reference to
std::ios_base_library_init()@GLIBCXX_3.4.32", "__isoc23_strtol@GLIBC_2.38").
That is exactly what happened when this repo's CI landed on the 22.04 Linux
runner instead of the 24.04 one. LiveKitSDK.cmake now defaults Linux to the
ubuntu-22.04 asset, which needs at most GLIBC_2.35 / GLIBCXX_3.4.30 (checked
with objdump against both archives) and therefore links and runs on 22.04 and
on everything newer -- the right floor for a plugin handed to directors as a
binary.
Linux, libobs version. The Linux job is pinned to ubuntu-24.04 rather than
ubuntu-latest, which this instance's two Linux runners answer with different
releases. 24.04's libobs-dev is 30.0.2 -- exactly the OBS version
buildspec.json pins for macOS/Windows -- so all three platforms build against
the same libobs. A 22.04 runner would have given OBS 27, a different API
surface.
macOS, no Xcode. The OBS sub-build failed its configure with "No
CMAKE_C_COMPILER could be found": the template hardcodes the Xcode generator,
and the `home-mac` runner has the Command Line Tools but no xcodebuild. The
sub-build now uses Ninja (with an explicit CMAKE_BUILD_TYPE, since Ninja is
single-config) and builds a single architecture rather than upstream's forced
universal -- this plugin is single-arch anyway, because client-sdk-cpp ships
single-arch dylibs, so a universal libobs would double the slowest step in CI
for a slice nothing links against.
While in there, generator flags are built as proper CMake lists so each
becomes its own argv entry. Upstream packs several into one space-separated
string and passes it unquoted, which execute_process hands to cmake as a
single argument; it happens not to matter for the optional flags upstream
passes, but it would silently swallow -DCMAKE_BUILD_TYPE.
Also lowers the libobs API floor in the adapter: video_format_get_parameters
instead of video_format_get_parameters_for_format. The _for_format variant
only exists from libobs 30 onwards and only differs for the 10-bit formats
(I010/P010) this source never receives, so using the older entry point keeps
the module loadable on an older OBS -- the direction that matters, since OBS
refuses modules built against a NEWER libobs than the one running.
Re-verified locally on Ubuntu 24.04 with the ubuntu-22.04 SDK asset:
ctest 6/6; the real-LiveKit integration test still reports "36 video frames,
323 audio frames, 10 state changes / 32 checks passed"; and the headless
libobs harness still logs "connected to ws://127.0.0.1:7880 ... watching
cam-test" followed by "video frame 640x360 I420" with the camera dropdown
populated from the live slot list.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RL8abRmgFXkVASHkkqiJbE
126 lines
4.2 KiB
YAML
126 lines
4.2 KiB
YAML
name: Build
|
|
|
|
# Every job builds the real plugin: the core library linked against the
|
|
# pinned livekit/client-sdk-cpp release, and -- where libobs is available --
|
|
# the OBS adapter module itself.
|
|
#
|
|
# Linux gets libobs from Ubuntu's libobs-dev. macOS and Windows have no
|
|
# equivalent system package, so they run obs-plugintemplate's buildspec
|
|
# bootstrap (buildspec.json + cmake/common/buildspec_common.cmake), which
|
|
# downloads the pinned obs-deps bundle and obs-studio source and builds just
|
|
# `libobs`. That step is the slow one: several minutes on a cold runner.
|
|
|
|
on:
|
|
push:
|
|
pull_request:
|
|
|
|
jobs:
|
|
linux:
|
|
name: Linux (ubuntu-24.04)
|
|
# Pinned to 24.04 rather than ubuntu-latest, which this instance's two
|
|
# Linux runners answer with different releases. 24.04's libobs-dev is
|
|
# 30.0.2, exactly the OBS version buildspec.json pins for macOS/Windows,
|
|
# so all three platforms build against the same libobs. On a 22.04 runner
|
|
# libobs-dev is OBS 27, which is a different API surface entirely.
|
|
runs-on: ubuntu-24.04
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Install build dependencies
|
|
run: |
|
|
sudo apt-get update -qq
|
|
sudo apt-get install -y -qq cmake ninja-build libobs-dev libcurl4-openssl-dev
|
|
|
|
- name: Configure
|
|
# Linux keeps its distribution libobs; the buildspec bootstrap is for
|
|
# the two platforms that have no such package.
|
|
run: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DSTPLUGIN_BOOTSTRAP_OBS=OFF
|
|
|
|
- name: Build
|
|
run: cmake --build build
|
|
|
|
- name: Test (core library)
|
|
run: ctest --test-dir build --output-on-failure
|
|
|
|
- name: Show what was built
|
|
run: |
|
|
ls -la build/package/bin build/package/data/locale build/package/licenses
|
|
ldd build/package/bin/streamer-tools-camera.so | grep -E 'obs|livekit'
|
|
nm -D build/package/bin/streamer-tools-camera.so | grep -E ' T obs_module_(load|unload)'
|
|
|
|
- name: Upload plugin
|
|
continue-on-error: true
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: streamer-tools-camera-linux-x64
|
|
path: build/package
|
|
|
|
macos:
|
|
name: macOS (macos-latest)
|
|
runs-on: macos-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Install build dependencies
|
|
run: brew install cmake ninja
|
|
|
|
- name: Configure
|
|
# The buildspec bootstrap runs here: it fetches obs-deps + the pinned
|
|
# obs-studio source and builds libobs before this project configures.
|
|
run: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release
|
|
|
|
- name: Build
|
|
run: cmake --build build
|
|
|
|
- name: Test (core library)
|
|
run: ctest --test-dir build --output-on-failure
|
|
|
|
- name: Show what was built
|
|
run: |
|
|
ls -la build/package/bin || true
|
|
otool -L build/package/bin/streamer-tools-camera.so || true
|
|
|
|
- name: Upload plugin
|
|
continue-on-error: true
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: streamer-tools-camera-macos
|
|
path: build/package
|
|
|
|
windows:
|
|
name: Windows (windows-latest)
|
|
runs-on: windows-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Install build dependencies
|
|
# winvm-builder is a self-hosted act_runner labeled "windows-latest";
|
|
# it is NOT the GitHub-hosted image, so none of that image's
|
|
# preinstalled tooling (cmake included) can be assumed present.
|
|
uses: lukka/get-cmake@latest
|
|
|
|
- name: Configure
|
|
# The default Visual Studio generator is required, not Ninja:
|
|
# cmake/windows/buildspec.cmake keys the dependency slice off
|
|
# CMAKE_VS_PLATFORM_NAME, which only a VS generator sets.
|
|
run: cmake -S . -B build -A x64
|
|
|
|
- name: Build
|
|
run: cmake --build build --config Release
|
|
|
|
- name: Test (core library)
|
|
run: ctest --test-dir build -C Release --output-on-failure
|
|
|
|
- name: Show what was built
|
|
run: dir build\package\bin
|
|
|
|
- name: Upload plugin
|
|
continue-on-error: true
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: streamer-tools-camera-windows-x64
|
|
path: build/package
|