feat(plugin): Implement OnDeleteStorageBucket

This commit is contained in:
Hugo committed 2024-03-04 19:42:01 +00:00
1 parent 37e8482110
commit f1f0055663
2 files changed
+8 -2

No files matched your search

+2 -1
View File
@@ -82,8 +82,9 @@ func (sp *StoragePlugin) OnUpdateStorageBucket(ctx context.Context, req *pb.OnUp
}
// OnDeleteStorageBucket is a hook that runs when a storage bucket is deleted.
// Since this plugin manages no state at the moment, this function is a no-op.
func (sp *StoragePlugin) OnDeleteStorageBucket(ctx context.Context, req *pb.OnDeleteStorageBucketRequest) (*pb.OnDeleteStorageBucketResponse, error) {
return nil, fmt.Errorf("unimplemented")
return &pb.OnDeleteStorageBucketResponse{}, nil
}
// ValidatePermissions is a hook that checks if the secrets associated with the
+6 -1
View File
@@ -264,7 +264,12 @@ func TestOnCreateStorageBucket(t *testing.T) {
func TestOnUpdateStorageBucket(t *testing.T) {}
func TestOnDeleteStorageBucket(t *testing.T) {}
func TestOnDeleteStorageBucket(t *testing.T) {
sp := new(StoragePlugin)
rsp, err := sp.OnDeleteStorageBucket(context.Background(), &plugin.OnDeleteStorageBucketRequest{})
require.NoError(t, err)
require.NotNil(t, rsp)
}
func TestValidatePermissions(t *testing.T) {
ctx := context.Background()