Compare commits
4
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
ddf4e7ee09 | ||
|
|
4fc2ce9449 | ||
|
|
a2235d93ce | ||
|
|
e0da13c89a |
No files matched your search
@@ -6,7 +6,11 @@ package storage
|
|||||||
import (
|
import (
|
||||||
"bytes"
|
"bytes"
|
||||||
"context"
|
"context"
|
||||||
|
"crypto/sha256"
|
||||||
|
"encoding/base64"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"os"
|
||||||
"path"
|
"path"
|
||||||
|
|
||||||
"github.com/google/uuid"
|
"github.com/google/uuid"
|
||||||
@@ -18,6 +22,7 @@ import (
|
|||||||
"google.golang.org/grpc/codes"
|
"google.golang.org/grpc/codes"
|
||||||
"google.golang.org/grpc/status"
|
"google.golang.org/grpc/status"
|
||||||
"google.golang.org/protobuf/types/known/structpb"
|
"google.golang.org/protobuf/types/known/structpb"
|
||||||
|
"google.golang.org/protobuf/types/known/timestamppb"
|
||||||
)
|
)
|
||||||
|
|
||||||
var _ pb.StoragePluginServiceServer = (*StoragePlugin)(nil)
|
var _ pb.StoragePluginServiceServer = (*StoragePlugin)(nil)
|
||||||
@@ -40,7 +45,7 @@ func (sp *StoragePlugin) OnCreateStorageBucket(ctx context.Context, req *pb.OnCr
|
|||||||
|
|
||||||
sa, err := getStorageAttributes(bucket.GetAttributes())
|
sa, err := getStorageAttributes(bucket.GetAttributes())
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err // getStorageAttributes already returns a "status"-type error.
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
sec, err := getStorageSecrets(bucket.GetSecrets())
|
sec, err := getStorageSecrets(bucket.GetSecrets())
|
||||||
@@ -78,7 +83,71 @@ func (sp *StoragePlugin) OnCreateStorageBucket(ctx context.Context, req *pb.OnCr
|
|||||||
|
|
||||||
// OnUpdateStorageBucket is a hook that runs when a storage bucket is updated.
|
// OnUpdateStorageBucket is a hook that runs when a storage bucket is updated.
|
||||||
func (sp *StoragePlugin) OnUpdateStorageBucket(ctx context.Context, req *pb.OnUpdateStorageBucketRequest) (*pb.OnUpdateStorageBucketResponse, error) {
|
func (sp *StoragePlugin) OnUpdateStorageBucket(ctx context.Context, req *pb.OnUpdateStorageBucketRequest) (*pb.OnUpdateStorageBucketResponse, error) {
|
||||||
return nil, fmt.Errorf("unimplemented")
|
newBucket := req.GetNewBucket()
|
||||||
|
if newBucket == nil {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "new bucket is required")
|
||||||
|
}
|
||||||
|
if newBucket.BucketName == "" {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "new bucketName is required")
|
||||||
|
}
|
||||||
|
oldBucket := req.GetCurrentBucket()
|
||||||
|
if oldBucket == nil {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "current bucket is required")
|
||||||
|
}
|
||||||
|
|
||||||
|
// current attributes
|
||||||
|
osa, err := getStorageAttributes(oldBucket.GetAttributes())
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
// new attributes and secrets
|
||||||
|
nsa, err := getStorageAttributes(newBucket.GetAttributes())
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
sec, err := getStorageSecrets(newBucket.GetSecrets())
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
switch {
|
||||||
|
case newBucket.GetBucketName() != oldBucket.GetBucketName():
|
||||||
|
return nil, status.Errorf(codes.InvalidArgument, "cannot update attribute BucketName")
|
||||||
|
case newBucket.GetBucketPrefix() != oldBucket.GetBucketPrefix():
|
||||||
|
return nil, status.Errorf(codes.InvalidArgument, "cannot update attribute BucketPrefix")
|
||||||
|
case nsa.Region != osa.Region:
|
||||||
|
return nil, status.Errorf(codes.InvalidArgument, "cannot update attribute Region")
|
||||||
|
case nsa.EndpointUrl != osa.EndpointUrl:
|
||||||
|
return nil, status.Errorf(codes.InvalidArgument, "cannot update attribute EndpointUrl")
|
||||||
|
}
|
||||||
|
|
||||||
|
if err = ensureServiceAccount(ctx, nsa, sec); err != nil {
|
||||||
|
return nil, status.Errorf(codes.InvalidArgument, "failed to ensure service account: %s", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
cl, err := minio.New(nsa.EndpointUrl, &minio.Options{
|
||||||
|
Creds: credentials.NewStaticV4(sec.AccessKeyId, sec.SecretAccessKey, ""),
|
||||||
|
Secure: nsa.UseSSL,
|
||||||
|
Region: nsa.Region,
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return nil, status.Errorf(codes.InvalidArgument, "failed to create minio sdk client: %s", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
if err = dryRun(ctx, cl, newBucket); err != nil {
|
||||||
|
return nil, status.Errorf(codes.InvalidArgument, "failed to verify provided minio environment: %s", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
persisted, err := structpb.NewStruct(sec.AsMap())
|
||||||
|
if err != nil {
|
||||||
|
return nil, status.Errorf(codes.InvalidArgument, "failed to convert storage attributes to protobuf struct: %s", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return &pb.OnUpdateStorageBucketResponse{
|
||||||
|
Persisted: &storagebuckets.StorageBucketPersisted{Data: persisted},
|
||||||
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// OnDeleteStorageBucket is a hook that runs when a storage bucket is deleted.
|
// OnDeleteStorageBucket is a hook that runs when a storage bucket is deleted.
|
||||||
@@ -100,7 +169,7 @@ func (sp *StoragePlugin) ValidatePermissions(ctx context.Context, req *pb.Valida
|
|||||||
|
|
||||||
sa, err := getStorageAttributes(bucket.GetAttributes())
|
sa, err := getStorageAttributes(bucket.GetAttributes())
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err // getStorageAttributes already returns a "status"-type error.
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
sec, err := getStorageSecrets(bucket.GetSecrets())
|
sec, err := getStorageSecrets(bucket.GetSecrets())
|
||||||
@@ -132,7 +201,47 @@ func (sp *StoragePlugin) ValidatePermissions(ctx context.Context, req *pb.Valida
|
|||||||
|
|
||||||
// HeadObject is a hook that retrieves metadata about an object.
|
// HeadObject is a hook that retrieves metadata about an object.
|
||||||
func (sp *StoragePlugin) HeadObject(ctx context.Context, req *pb.HeadObjectRequest) (*pb.HeadObjectResponse, error) {
|
func (sp *StoragePlugin) HeadObject(ctx context.Context, req *pb.HeadObjectRequest) (*pb.HeadObjectResponse, error) {
|
||||||
return nil, fmt.Errorf("unimplemented")
|
bucket := req.GetBucket()
|
||||||
|
if bucket == nil {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "no storage bucket information found")
|
||||||
|
}
|
||||||
|
if bucket.GetBucketName() == "" {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "storage bucket name is required")
|
||||||
|
}
|
||||||
|
|
||||||
|
if req.GetKey() == "" {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "object key is required")
|
||||||
|
}
|
||||||
|
|
||||||
|
sa, err := getStorageAttributes(bucket.GetAttributes())
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
sec, err := getStorageSecrets(bucket.GetSecrets())
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
cl, err := minio.New(sa.EndpointUrl, &minio.Options{
|
||||||
|
Creds: credentials.NewStaticV4(sec.AccessKeyId, sec.SecretAccessKey, ""),
|
||||||
|
Secure: sa.UseSSL,
|
||||||
|
Region: sa.Region,
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return nil, status.Errorf(codes.Unknown, "failed to create minio sdk client: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
objKey := path.Join(bucket.GetBucketPrefix(), req.GetKey())
|
||||||
|
oi, err := cl.StatObject(ctx, bucket.GetBucketName(), objKey, minio.StatObjectOptions{})
|
||||||
|
if err != nil {
|
||||||
|
return nil, status.Errorf(codes.Unknown, "failed to stat object: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return &pb.HeadObjectResponse{
|
||||||
|
ContentLength: oi.Size,
|
||||||
|
LastModified: timestamppb.New(oi.LastModified),
|
||||||
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetObject is a hook that retrieves objects.
|
// GetObject is a hook that retrieves objects.
|
||||||
@@ -143,7 +252,90 @@ func (sp *StoragePlugin) GetObject(req *pb.GetObjectRequest, objServer pb.Storag
|
|||||||
// PutObject is a hook that reads a file stored on local disk and stores it to
|
// PutObject is a hook that reads a file stored on local disk and stores it to
|
||||||
// an external object store.
|
// an external object store.
|
||||||
func (sp *StoragePlugin) PutObject(ctx context.Context, req *pb.PutObjectRequest) (*pb.PutObjectResponse, error) {
|
func (sp *StoragePlugin) PutObject(ctx context.Context, req *pb.PutObjectRequest) (*pb.PutObjectResponse, error) {
|
||||||
return nil, fmt.Errorf("unimplemented")
|
bucket := req.GetBucket()
|
||||||
|
if bucket == nil {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "no storage bucket information found")
|
||||||
|
}
|
||||||
|
if bucket.GetBucketName() == "" {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "storage bucket name is required")
|
||||||
|
}
|
||||||
|
if req.GetKey() == "" {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "object key is required")
|
||||||
|
}
|
||||||
|
if req.GetPath() == "" {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "path is required")
|
||||||
|
}
|
||||||
|
|
||||||
|
sa, err := getStorageAttributes(bucket.GetAttributes())
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
sec, err := getStorageSecrets(bucket.GetSecrets())
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
file, err := os.Open(req.GetPath())
|
||||||
|
if err != nil {
|
||||||
|
return nil, status.Errorf(codes.Internal, "failed to open file: %v", err)
|
||||||
|
}
|
||||||
|
defer file.Close()
|
||||||
|
|
||||||
|
info, err := file.Stat()
|
||||||
|
if err != nil {
|
||||||
|
return nil, status.Errorf(codes.Internal, "failed to read file info: %v", err)
|
||||||
|
}
|
||||||
|
if info.IsDir() {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "path is not a file")
|
||||||
|
}
|
||||||
|
if info.Size() == 0 {
|
||||||
|
return nil, status.Error(codes.InvalidArgument, "file is empty")
|
||||||
|
}
|
||||||
|
|
||||||
|
cl, err := minio.New(sa.EndpointUrl, &minio.Options{
|
||||||
|
Creds: credentials.NewStaticV4(sec.AccessKeyId, sec.SecretAccessKey, ""),
|
||||||
|
Secure: sa.UseSSL,
|
||||||
|
Region: sa.Region,
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return nil, status.Errorf(codes.Internal, "failed to create minio sdk client: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
hash := sha256.New()
|
||||||
|
if _, err := io.Copy(hash, file); err != nil {
|
||||||
|
return nil, status.Errorf(codes.Internal, "failed to calculate hash: %v", err)
|
||||||
|
}
|
||||||
|
checksum := base64.StdEncoding.EncodeToString(hash.Sum(nil))
|
||||||
|
|
||||||
|
if _, err = file.Seek(0, io.SeekStart); err != nil {
|
||||||
|
return nil, status.Errorf(codes.Internal, "failed to rewind file pointer: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
key := path.Join(bucket.GetBucketPrefix(), req.GetKey())
|
||||||
|
res, err := cl.PutObject(ctx, bucket.GetBucketName(), key, file, info.Size(), minio.PutObjectOptions{
|
||||||
|
UserMetadata: map[string]string{
|
||||||
|
"x-amz-checksum-algorithm": "SHA256",
|
||||||
|
"x-amz-checksum-sha256": checksum,
|
||||||
|
},
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return nil, status.Errorf(codes.Internal, "failed to put object into minio: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
if res.ChecksumSHA256 == "" {
|
||||||
|
return nil, status.Error(codes.Internal, "missing checksum response from minio")
|
||||||
|
}
|
||||||
|
if checksum != res.ChecksumSHA256 {
|
||||||
|
return nil, status.Error(codes.Internal, "mismatched checksum")
|
||||||
|
}
|
||||||
|
decodedChecksum, err := base64.StdEncoding.DecodeString(res.ChecksumSHA256)
|
||||||
|
if err != nil {
|
||||||
|
return nil, status.Errorf(codes.Internal, "failed to decode checksum value from minio: %v", err)
|
||||||
|
}
|
||||||
|
return &pb.PutObjectResponse{
|
||||||
|
ChecksumSha_256: decodedChecksum,
|
||||||
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// DeleteObjects deletes one or many files in an external object store via a
|
// DeleteObjects deletes one or many files in an external object store via a
|
||||||
|
|||||||
@@ -4,17 +4,27 @@
|
|||||||
package storage
|
package storage
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"bufio"
|
||||||
|
"bytes"
|
||||||
"context"
|
"context"
|
||||||
|
"crypto/sha256"
|
||||||
|
"fmt"
|
||||||
|
"os"
|
||||||
|
"path"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/google/go-cmp/cmp"
|
"github.com/google/go-cmp/cmp"
|
||||||
|
"github.com/google/uuid"
|
||||||
internaltest "github.com/hashicorp/boundary-plugin-minio/internal/testing"
|
internaltest "github.com/hashicorp/boundary-plugin-minio/internal/testing"
|
||||||
"github.com/hashicorp/boundary/sdk/pbs/controller/api/resources/storagebuckets"
|
"github.com/hashicorp/boundary/sdk/pbs/controller/api/resources/storagebuckets"
|
||||||
"github.com/hashicorp/boundary/sdk/pbs/plugin"
|
"github.com/hashicorp/boundary/sdk/pbs/plugin"
|
||||||
"github.com/minio/madmin-go/v3"
|
"github.com/minio/madmin-go/v3"
|
||||||
"github.com/minio/minio-go/v7"
|
"github.com/minio/minio-go/v7"
|
||||||
"github.com/minio/minio-go/v7/pkg/credentials"
|
"github.com/minio/minio-go/v7/pkg/credentials"
|
||||||
|
"github.com/stretchr/testify/assert"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/stretchr/testify/require"
|
||||||
|
"google.golang.org/grpc/codes"
|
||||||
|
"google.golang.org/grpc/status"
|
||||||
"google.golang.org/protobuf/testing/protocmp"
|
"google.golang.org/protobuf/testing/protocmp"
|
||||||
"google.golang.org/protobuf/types/known/structpb"
|
"google.golang.org/protobuf/types/known/structpb"
|
||||||
)
|
)
|
||||||
@@ -262,7 +272,401 @@ func TestOnCreateStorageBucket(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestOnUpdateStorageBucket(t *testing.T) {}
|
func TestOnUpdateStorageBucket(t *testing.T) {
|
||||||
|
ctx := context.Background()
|
||||||
|
server := internaltest.NewMinioServer(t)
|
||||||
|
|
||||||
|
bucketName := "test-bucket"
|
||||||
|
require.NoError(t, server.Client.MakeBucket(ctx, bucketName, minio.MakeBucketOptions{}))
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
req *plugin.OnUpdateStorageBucketRequest
|
||||||
|
expected *plugin.OnUpdateStorageBucketResponse
|
||||||
|
err string
|
||||||
|
errCode codes.Code
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "nilNewBucket",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{},
|
||||||
|
err: "new bucket is required",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "emptyNewBucketName",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{},
|
||||||
|
},
|
||||||
|
err: "new bucketName is required",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "nilCurrentBucket",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "current bucket is required",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "nilCurrentBucketAttributes",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{},
|
||||||
|
},
|
||||||
|
err: "empty attributes input",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "nilNewBucketAttributes",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Secrets: new(structpb.Struct),
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "empty attributes input",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "nilNewBucketSecrets",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "empty secrets input",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "errorReadingAttributes",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Secrets: new(structpb.Struct),
|
||||||
|
Attributes: new(structpb.Struct),
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "empty attributes input",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "errorReadingSecrets",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: new(structpb.Struct),
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "empty secrets input",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "invalidBucketNameUpdate",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo2",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "cannot update attribute BucketName",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "invalidBucketPrefixUpdate",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
BucketPrefix: "foo",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "cannot update attribute BucketPrefix",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "invalidRegionUpdate",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
"region": structpb.NewStringValue("a region"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "cannot update attribute Region",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "invalidEndpointUrlUpdate",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://localhost:9000"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: "foo",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "cannot update attribute EndpointUrl",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "usingNonServiceAccount",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.RootUsername),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.RootPassword),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Persisted: &storagebuckets.StorageBucketPersisted{
|
||||||
|
Data: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.RootUsername),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.RootPassword),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "The specified service account is not found (Specified service account does not exist)",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "dryRunFail",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: func() map[string]*structpb.Value {
|
||||||
|
creds, err := server.AdminClient.AddServiceAccount(ctx, madmin.AddServiceAccountReq{
|
||||||
|
Policy: policyDenyPutObject,
|
||||||
|
})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
return map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(creds.AccessKey),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(creds.SecretKey),
|
||||||
|
}
|
||||||
|
}(),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Persisted: &storagebuckets.StorageBucketPersisted{
|
||||||
|
Data: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.RootUsername),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.RootPassword),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
err: "failed to verify provided minio environment: failed to put object",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "success",
|
||||||
|
req: &plugin.OnUpdateStorageBucketRequest{
|
||||||
|
NewBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
CurrentBucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Persisted: &storagebuckets.StorageBucketPersisted{
|
||||||
|
Data: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.RootUsername),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.RootPassword),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expected: &plugin.OnUpdateStorageBucketResponse{
|
||||||
|
Persisted: &storagebuckets.StorageBucketPersisted{
|
||||||
|
Data: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
require := require.New(t)
|
||||||
|
sp := new(StoragePlugin)
|
||||||
|
res, err := sp.OnUpdateStorageBucket(ctx, tt.req)
|
||||||
|
if tt.err != "" {
|
||||||
|
require.ErrorContains(err, tt.err)
|
||||||
|
require.Equal(tt.errCode.String(), status.Code(err).String())
|
||||||
|
require.Nil(res)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
require.NoError(err)
|
||||||
|
require.NotNil(res)
|
||||||
|
require.EqualValues(tt.expected, res)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestOnDeleteStorageBucket(t *testing.T) {
|
func TestOnDeleteStorageBucket(t *testing.T) {
|
||||||
sp := new(StoragePlugin)
|
sp := new(StoragePlugin)
|
||||||
@@ -406,11 +810,470 @@ func TestValidatePermissions(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestHeadObject(t *testing.T) {}
|
func TestHeadObject(t *testing.T) {
|
||||||
|
ctx := context.Background()
|
||||||
|
server := internaltest.NewMinioServer(t)
|
||||||
|
|
||||||
|
bucketName := "test-bucket"
|
||||||
|
err := server.Client.MakeBucket(ctx, bucketName, minio.MakeBucketOptions{})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
objectKey := fmt.Sprintf("test-head-object-%s", uuid.New().String())
|
||||||
|
rd := bytes.NewReader([]byte("test-head-object-contents"))
|
||||||
|
_, err = server.Client.PutObject(ctx, bucketName, objectKey, rd, rd.Size(), minio.PutObjectOptions{})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
bucketPrefix := "prefix"
|
||||||
|
rd2 := bytes.NewReader([]byte("test-head-object-contents"))
|
||||||
|
_, err = server.Client.PutObject(ctx, bucketName, path.Join(bucketPrefix, objectKey), rd2, rd2.Size(), minio.PutObjectOptions{})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
req *plugin.HeadObjectRequest
|
||||||
|
expErrMsg string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "nilBucket",
|
||||||
|
req: &plugin.HeadObjectRequest{Bucket: nil},
|
||||||
|
expErrMsg: "no storage bucket information found",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "emptyBucket",
|
||||||
|
req: &plugin.HeadObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{},
|
||||||
|
},
|
||||||
|
expErrMsg: "storage bucket name is required",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "emptyObjectKey",
|
||||||
|
req: &plugin.HeadObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
},
|
||||||
|
Key: "",
|
||||||
|
},
|
||||||
|
expErrMsg: "object key is required",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "badStorageAttributes",
|
||||||
|
req: &plugin.HeadObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
"endpoint_url": structpb.NewStringValue("foo"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "object-key",
|
||||||
|
},
|
||||||
|
expErrMsg: "attributes.endpoint_url.format: unknown protocol, should be http:// or https://",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "badStorageSecrets",
|
||||||
|
req: &plugin.HeadObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
"endpoint_url": structpb.NewStringValue("http://foo"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
"access_key_id": structpb.NewStringValue("foo"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "object-key",
|
||||||
|
},
|
||||||
|
expErrMsg: "secrets.secret_access_key: missing required value \"secret_access_key\"",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "statObjectFail",
|
||||||
|
req: &plugin.HeadObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://localhost:1"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue("foo"),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue("bar"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "object-key",
|
||||||
|
},
|
||||||
|
expErrMsg: "failed to stat object",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "nonExistantKey",
|
||||||
|
req: &plugin.HeadObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "doesnt-exist",
|
||||||
|
},
|
||||||
|
expErrMsg: "failed to stat object: The specified key does not exist.",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "success",
|
||||||
|
req: &plugin.HeadObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: objectKey,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "successWithBucketPrefix",
|
||||||
|
req: &plugin.HeadObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
BucketPrefix: bucketPrefix,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: objectKey,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
sp := new(StoragePlugin)
|
||||||
|
rsp, err := sp.HeadObject(ctx, tt.req)
|
||||||
|
if tt.expErrMsg != "" {
|
||||||
|
require.ErrorContains(t, err, tt.expErrMsg)
|
||||||
|
require.Nil(t, rsp)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
require.NoError(t, err)
|
||||||
|
require.NotNil(t, rsp)
|
||||||
|
require.Equal(t, rd.Size(), rsp.GetContentLength())
|
||||||
|
require.NotEmpty(t, rsp.GetLastModified().AsTime())
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestGetObject(t *testing.T) {}
|
func TestGetObject(t *testing.T) {}
|
||||||
|
|
||||||
func TestPutObject(t *testing.T) {}
|
func TestPutObject(t *testing.T) {
|
||||||
|
td := t.TempDir()
|
||||||
|
|
||||||
|
dirPath := func(p string) string {
|
||||||
|
return path.Join(td, p)
|
||||||
|
}
|
||||||
|
|
||||||
|
ctx := context.Background()
|
||||||
|
server := internaltest.NewMinioServer(t)
|
||||||
|
|
||||||
|
bucketName := "test-bucket"
|
||||||
|
require.NoError(t, server.Client.MakeBucket(ctx, bucketName, minio.MakeBucketOptions{}))
|
||||||
|
|
||||||
|
cases := []struct {
|
||||||
|
name string
|
||||||
|
req *plugin.PutObjectRequest
|
||||||
|
setup func(*plugin.PutObjectRequest) (string, error)
|
||||||
|
err string
|
||||||
|
errCode codes.Code
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "nilRequest",
|
||||||
|
err: "no storage bucket information found",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "nilBucket",
|
||||||
|
req: &plugin.PutObjectRequest{Bucket: nil},
|
||||||
|
err: "no storage bucket information found",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "emptyBucket",
|
||||||
|
req: &plugin.PutObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{},
|
||||||
|
},
|
||||||
|
err: "storage bucket name is required",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "emptyObjectKey",
|
||||||
|
req: &plugin.PutObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
},
|
||||||
|
Key: "",
|
||||||
|
},
|
||||||
|
err: "object key is required",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "emptyFilePath",
|
||||||
|
req: &plugin.PutObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
},
|
||||||
|
Key: "test-key",
|
||||||
|
Path: "",
|
||||||
|
},
|
||||||
|
err: "path is required",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "badStorageAttributes",
|
||||||
|
req: &plugin.PutObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
"endpoint_url": structpb.NewStringValue("foo"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "object-key",
|
||||||
|
Path: "file-path",
|
||||||
|
},
|
||||||
|
err: "attributes.endpoint_url.format: unknown protocol, should be http:// or https://",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "badStorageSecrets",
|
||||||
|
req: &plugin.PutObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
"endpoint_url": structpb.NewStringValue("http://foo"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
"access_key_id": structpb.NewStringValue("foo"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "object-key",
|
||||||
|
Path: "file-path",
|
||||||
|
},
|
||||||
|
err: "secrets.secret_access_key: missing required value \"secret_access_key\"",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "emptyFile",
|
||||||
|
req: &plugin.PutObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "test-key",
|
||||||
|
Path: dirPath("empty-test-file"),
|
||||||
|
},
|
||||||
|
setup: func(req *plugin.PutObjectRequest) (string, error) {
|
||||||
|
file, err := os.Create(req.Path)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
file.Close()
|
||||||
|
return "", nil
|
||||||
|
},
|
||||||
|
err: "file is empty",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "pathIsDir",
|
||||||
|
req: &plugin.PutObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "test-key",
|
||||||
|
Path: td,
|
||||||
|
},
|
||||||
|
err: "path is not a file",
|
||||||
|
errCode: codes.InvalidArgument,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "success",
|
||||||
|
req: &plugin.PutObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "test-key",
|
||||||
|
Path: dirPath("test-file"),
|
||||||
|
},
|
||||||
|
setup: func(req *plugin.PutObjectRequest) (string, error) {
|
||||||
|
file, err := os.Create(req.Path)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
defer file.Close()
|
||||||
|
|
||||||
|
data := "test file data"
|
||||||
|
|
||||||
|
if _, err = file.WriteString(data); err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return data, nil
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "successWithBucketPrefix",
|
||||||
|
req: &plugin.PutObjectRequest{
|
||||||
|
Bucket: &storagebuckets.StorageBucket{
|
||||||
|
BucketName: bucketName,
|
||||||
|
BucketPrefix: "test-prefix",
|
||||||
|
Attributes: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstEndpointUrl: structpb.NewStringValue("http://" + server.ApiAddr),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Secrets: &structpb.Struct{
|
||||||
|
Fields: map[string]*structpb.Value{
|
||||||
|
ConstAccessKeyId: structpb.NewStringValue(server.ServiceAccountAccessKeyId),
|
||||||
|
ConstSecretAccessKey: structpb.NewStringValue(server.ServiceAccountSecretAccessKey),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Key: "test-key-with-prefix",
|
||||||
|
Path: dirPath("test-file-with-prefix"),
|
||||||
|
},
|
||||||
|
setup: func(req *plugin.PutObjectRequest) (string, error) {
|
||||||
|
file, err := os.Create(req.Path)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
defer file.Close()
|
||||||
|
|
||||||
|
data := "test file data for bucket with prefix"
|
||||||
|
|
||||||
|
if _, err = file.WriteString(data); err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
return data, nil
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range cases {
|
||||||
|
tt := tt
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
assert, require := assert.New(t), require.New(t)
|
||||||
|
var checksum []byte
|
||||||
|
var content string
|
||||||
|
if tt.setup != nil {
|
||||||
|
var err error
|
||||||
|
content, err = tt.setup(tt.req)
|
||||||
|
require.NoError(err)
|
||||||
|
hash := sha256.New()
|
||||||
|
_, err = hash.Write([]byte(content))
|
||||||
|
require.NoError(err)
|
||||||
|
checksum = hash.Sum(nil)
|
||||||
|
require.NoError(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
sp := new(StoragePlugin)
|
||||||
|
res, err := sp.PutObject(ctx, tt.req)
|
||||||
|
|
||||||
|
if tt.err != "" {
|
||||||
|
assert.ErrorContains(err, tt.err)
|
||||||
|
assert.Equal(tt.errCode.String(), status.Code(err).String())
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
require.NotNil(res)
|
||||||
|
assert.NotEmpty(res.GetChecksumSha_256())
|
||||||
|
assert.Equal(checksum, res.ChecksumSha_256)
|
||||||
|
|
||||||
|
// check the actual file content is the same
|
||||||
|
cl, err := minio.New(server.ApiAddr, &minio.Options{
|
||||||
|
Creds: credentials.NewStaticV4(server.RootUsername, server.RootPassword, ""),
|
||||||
|
Secure: false,
|
||||||
|
})
|
||||||
|
require.NoError(err)
|
||||||
|
obj, err := cl.GetObject(ctx, bucketName, path.Join(tt.req.Bucket.GetBucketPrefix(), tt.req.GetKey()), minio.GetObjectOptions{})
|
||||||
|
require.NoError(err)
|
||||||
|
defer obj.Close()
|
||||||
|
|
||||||
|
contentLen := len([]byte(content))
|
||||||
|
reader := bufio.NewReader(obj)
|
||||||
|
buffer := make([]byte, contentLen)
|
||||||
|
n, err := reader.Read(buffer)
|
||||||
|
require.NoError(err)
|
||||||
|
|
||||||
|
assert.Equal(contentLen, n)
|
||||||
|
assert.Equal(content, string(buffer))
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestDeleteObjects(t *testing.T) {}
|
func TestDeleteObjects(t *testing.T) {}
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user