Merge pull request #715 from hashicorp/host-sets

Host sets read/del/update capabilities

addons/api/mirage/factories/host-set.js

@@ -1,5 +1,13 @@
 import factory from '../generated/factories/host-set';
+import permissions from '../helpers/permissions';
 
 export default factory.extend({
+  authorized_actions: () =>
+    permissions.authorizedActionsFor('host-set') || [
+      'no-op',
+      'read',
+      'update',
+      'delete',
+    ],
   id: (i) => `host-set-id-${i}`,
 });

ui/admin/app/components/form/host-set/index.hbs

@@ -52,12 +52,12 @@
       </field.errors>
     {{/if}}
   </form.textarea>
-
-  <form.actions
-    @disabled={{if @model.cannotSave @model.cannotSave}}
-    @enableEditText={{t 'actions.edit-form'}}
-    @submitText={{t 'actions.save'}}
-    @cancelText={{t 'actions.cancel'}}
-  />
-
+  {{#if (can 'save model' @model)}}
+    <form.actions
+      @disabled={{if @model.cannotSave @model.cannotSave}}
+      @enableEditText={{t 'actions.edit-form'}}
+      @submitText={{t 'actions.save'}}
+      @cancelText={{t 'actions.cancel'}}
+    />
+  {{/if}}
 </Rose::Form>

ui/admin/app/templates/scopes/scope/host-catalogs/host-catalog/host-sets/host-set/-actions.hbs

@@ -13,12 +13,14 @@
   >
     {{t 'resources.host-set.actions.add-hosts'}}
   </dropdown.link>
-  <dropdown.separator />
-  <dropdown.button
-    @style='danger'
-    @disabled={{@model.canSave}}
-    {{on 'click' (route-action 'deleteHostSet' @model)}}
-  >
-    {{t 'resources.host-set.actions.delete'}}
-  </dropdown.button>
+  {{#if (can 'delete model' @model)}}
+    <dropdown.separator />
+    <dropdown.button
+      @style='danger'
+      @disabled={{@model.canSave}}
+      {{on 'click' (route-action 'deleteHostSet' @model)}}
+    >
+      {{t 'resources.host-set.actions.delete'}}
+    </dropdown.button>
+  {{/if}}
 </Rose::Dropdown>

ui/admin/app/templates/scopes/scope/host-catalogs/host-catalog/host-sets/index.hbs

@@ -12,12 +12,16 @@
       {{#each @model as |hostSet|}}
         <body.row as |row|>
           <row.headerCell>
-            <LinkTo
-              @route='scopes.scope.host-catalogs.host-catalog.host-sets.host-set'
-              @model={{hostSet.id}}
-            >
+            {{#if (can 'read model' hostSet)}}
+              <LinkTo
+                @route='scopes.scope.host-catalogs.host-catalog.host-sets.host-set'
+                @model={{hostSet.id}}
+              >
+                {{hostSet.displayName}}
+              </LinkTo>
+            {{else}}
               {{hostSet.displayName}}
-            </LinkTo>
+            {{/if}}
             <p>{{hostSet.description}}</p>
           </row.headerCell>
           <row.cell>

ui/admin/tests/acceptance/host-catalogs/host-sets-test.js

@@ -2,10 +2,7 @@ import { module, test } from 'qunit';
 import { visit, currentURL, find, click, fillIn } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
-import a11yAudit from 'ember-a11y-testing/test-support/audit';
 import { Response } from 'miragejs';
-import { resolve, reject } from 'rsvp';
-import sinon from 'sinon';
 import {
   authenticateSession,
   // These are left here intentionally for future reference.
@@ -73,23 +70,6 @@ module('Acceptance | host-catalogs | host sets', function (hooks) {
     authenticateSession({});
   });
 
-  test('visiting host sets', async function (assert) {
-    assert.expect(2);
-    await visit(urls.hostSets);
-    await a11yAudit();
-    assert.equal(currentURL(), urls.hostSets);
-    await visit(urls.hostSet);
-    await a11yAudit();
-    assert.equal(currentURL(), urls.hostSet);
-  });
-
-  test('visiting an unknown host set displays 404 message', async function (assert) {
-    assert.expect(1);
-    await visit(urls.unknownHostSet);
-    await a11yAudit();
-    assert.ok(find('.rose-message-subtitle').textContent.trim(), 'Error 404');
-  });
-
   test('can create new host', async function (assert) {
     assert.expect(1);
     const count = getHostSetCount();
@@ -141,157 +121,4 @@ module('Acceptance | host-catalogs | host sets', function (hooks) {
       'Name is required.'
     );
   });
-
-  test('can save changes to existing host', async function (assert) {
-    assert.expect(3);
-    assert.notEqual(instances.hostSet.name, 'random string');
-    await visit(urls.hostSet);
-    await click('form [type="button"]', 'Activate edit mode');
-    await fillIn('[name="name"]', 'random string');
-    await click('.rose-form-actions [type="submit"]');
-    assert.equal(currentURL(), urls.hostSet);
-    assert.equal(
-      this.server.schema.hostSets.all().models[0].name,
-      'random string'
-    );
-  });
-
-  test('can cancel changes to existing host', async function (assert) {
-    assert.expect(2);
-    await visit(urls.hostSet);
-    await click('form [type="button"]', 'Activate edit mode');
-    await fillIn('[name="name"]', 'random string');
-    await click('.rose-form-actions [type="button"]');
-    assert.notEqual(instances.hostSet.name, 'random string');
-    assert.equal(find('[name="name"]').value, instances.hostSet.name);
-  });
-
-  test('saving an existing host set with invalid fields displays error messages', async function (assert) {
-    assert.expect(2);
-    this.server.patch('/host-sets/:id', () => {
-      return new Response(
-        400,
-        {},
-        {
-          status: 400,
-          code: 'invalid_argument',
-          message: 'The request was invalid.',
-          details: {
-            request_fields: [
-              {
-                name: 'name',
-                description: 'Name is required.',
-              },
-            ],
-          },
-        }
-      );
-    });
-    await visit(urls.hostSet);
-    await click('form [type="button"]', 'Activate edit mode');
-    await fillIn('[name="name"]', 'random string');
-    await click('[type="submit"]');
-    assert.ok(
-      find('[role="alert"]').textContent.trim(),
-      'The request was invalid.'
-    );
-    assert.ok(
-      find('.rose-form-error-message').textContent.trim(),
-      'Name is required.'
-    );
-  });
-
-  test('can discard unsaved host set changes via dialog', async function (assert) {
-    assert.expect(5);
-    const confirmService = this.owner.lookup('service:confirm');
-    confirmService.enabled = true;
-    assert.notEqual(instances.hostSet.name, 'random string');
-    await visit(urls.hostSet);
-    await click('form [type="button"]', 'Activate edit mode');
-    await fillIn('[name="name"]', 'random string');
-    assert.equal(currentURL(), urls.hostSet);
-    try {
-      await visit(urls.hostSets);
-    } catch (e) {
-      assert.ok(find('.rose-dialog'));
-      await click('.rose-dialog-footer button:first-child');
-      assert.equal(currentURL(), urls.hostSets);
-      assert.notEqual(
-        this.server.schema.hostSets.all().models[0].name,
-        'random string'
-      );
-    }
-  });
-
-  test('can cancel discard unsaved host set changes via dialog', async function (assert) {
-    assert.expect(5);
-    const confirmService = this.owner.lookup('service:confirm');
-    confirmService.enabled = true;
-    assert.notEqual(instances.hostSet.name, 'random string');
-    await visit(urls.hostSet);
-    await click('form [type="button"]', 'Activate edit mode');
-    await fillIn('[name="name"]', 'random string');
-    assert.equal(currentURL(), urls.hostSet);
-    try {
-      await visit(urls.hostSets);
-    } catch (e) {
-      assert.ok(find('.rose-dialog'));
-      await click('.rose-dialog-footer button:last-child');
-      assert.equal(currentURL(), urls.hostSet);
-      assert.notEqual(
-        this.server.schema.hostSets.all().models[0].name,
-        'random string'
-      );
-    }
-  });
-
-  test('can delete host', async function (assert) {
-    assert.expect(1);
-    const count = getHostSetCount();
-    await visit(urls.hostSet);
-    await click('.rose-layout-page-actions .rose-dropdown-button-danger');
-    assert.equal(getHostSetCount(), count - 1);
-  });
-
-  test('can accept delete host set via dialog', async function (assert) {
-    assert.expect(2);
-    const confirmService = this.owner.lookup('service:confirm');
-    confirmService.enabled = true;
-    confirmService.confirm = sinon.fake.returns(resolve());
-    const count = getHostSetCount();
-    await visit(urls.hostSet);
-    await click('.rose-layout-page-actions .rose-dropdown-button-danger');
-    assert.equal(getHostSetCount(), count - 1);
-    assert.ok(confirmService.confirm.calledOnce);
-  });
-
-  test('cannot cancel delete host set via dialog', async function (assert) {
-    assert.expect(2);
-    const confirmService = this.owner.lookup('service:confirm');
-    confirmService.enabled = true;
-    confirmService.confirm = sinon.fake.returns(reject());
-    const count = getHostSetCount();
-    await visit(urls.hostSet);
-    await click('.rose-layout-page-actions .rose-dropdown-button-danger');
-    assert.equal(getHostSetCount(), count);
-    assert.ok(confirmService.confirm.calledOnce);
-  });
-
-  test('deleting a host set which errors displays error messages', async function (assert) {
-    assert.expect(1);
-    this.server.del('/host-sets/:id', () => {
-      return new Response(
-        490,
-        {},
-        {
-          status: 490,
-          code: 'error',
-          message: 'Oops.',
-        }
-      );
-    });
-    await visit(urls.hostSet);
-    await click('.rose-layout-page-actions .rose-dropdown-button-danger');
-    assert.ok(find('[role="alert"]').textContent.trim(), 'Oops.');
-  });
 });

ui/admin/tests/acceptance/host-catalogs/host-sets/delete-test.js

@@ -0,0 +1,134 @@
+import { module, test } from 'qunit';
+import { visit, find, click } from '@ember/test-helpers';
+import { setupApplicationTest } from 'ember-qunit';
+import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
+import { Response } from 'miragejs';
+import { resolve, reject } from 'rsvp';
+import sinon from 'sinon';
+import {
+  authenticateSession,
+  // These are left here intentionally for future reference.
+  //currentSession,
+  //invalidateSession,
+} from 'ember-simple-auth/test-support';
+
+module('Acceptance | host-catalogs | host sets | delete', function (hooks) {
+  setupApplicationTest(hooks);
+  setupMirage(hooks);
+
+  let getHostSetCount;
+
+  const instances = {
+    scopes: {
+      global: null,
+      org: null,
+      project: null,
+      hostCatalog: null,
+      host: null,
+    },
+  };
+  const urls = {
+    globalScope: null,
+    orgScope: null,
+    projectScope: null,
+    hostCatalogs: null,
+    hostCatalog: null,
+    hostSets: null,
+    hostSet: null,
+    unknownHostSet: null,
+    newHostSet: null,
+  };
+
+  hooks.beforeEach(function () {
+    // Generate resources
+    instances.scopes.global = this.server.create('scope', { id: 'global' });
+    instances.scopes.org = this.server.create('scope', {
+      type: 'org',
+      scope: { id: 'global', type: 'global' },
+    });
+    instances.scopes.project = this.server.create('scope', {
+      type: 'project',
+      scope: { id: instances.scopes.org.id, type: 'org' },
+    });
+    instances.hostCatalog = this.server.create('host-catalog', {
+      scope: instances.scopes.project,
+    });
+    instances.hostSet = this.server.create('host-set', {
+      scope: instances.scopes.project,
+      hostCatalog: instances.hostCatalog,
+    });
+    // Generate route URLs for resources
+    urls.globalScope = `/scopes/global/scopes`;
+    urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
+    urls.projectScope = `/scopes/${instances.scopes.project.id}`;
+    urls.hostCatalogs = `${urls.projectScope}/host-catalogs`;
+    urls.hostCatalog = `${urls.hostCatalogs}/${instances.hostCatalog.id}`;
+    urls.hostSets = `${urls.hostCatalog}/host-sets`;
+    urls.hostSet = `${urls.hostSets}/${instances.hostSet.id}`;
+    urls.unknownHostSet = `${urls.hostSets}/foo`;
+    urls.newHostSet = `${urls.hostSets}/new`;
+    // Generate resource couner
+    getHostSetCount = () => this.server.schema.hostSets.all().models.length;
+    authenticateSession({});
+  });
+
+  test('can delete host', async function (assert) {
+    assert.expect(1);
+    const count = getHostSetCount();
+    await visit(urls.hostSet);
+    await click('.rose-layout-page-actions .rose-dropdown-button-danger');
+    assert.equal(getHostSetCount(), count - 1);
+  });
+
+  test('can accept delete host set via dialog', async function (assert) {
+    assert.expect(2);
+    const confirmService = this.owner.lookup('service:confirm');
+    confirmService.enabled = true;
+    confirmService.confirm = sinon.fake.returns(resolve());
+    const count = getHostSetCount();
+    await visit(urls.hostSet);
+    await click('.rose-layout-page-actions .rose-dropdown-button-danger');
+    assert.equal(getHostSetCount(), count - 1);
+    assert.ok(confirmService.confirm.calledOnce);
+  });
+
+  test('cannot delete host set without proper authorization', async function (assert) {
+    assert.expect(1);
+    instances.hostSet.authorized_actions =
+      instances.hostSet.authorized_actions.filter((item) => item !== 'delete');
+    await visit(urls.hostSet);
+    assert.notOk(
+      find('.rose-layout-page-actions .rose-dropdown-button-danger')
+    );
+  });
+
+  test('cannot cancel delete host set via dialog', async function (assert) {
+    assert.expect(2);
+    const confirmService = this.owner.lookup('service:confirm');
+    confirmService.enabled = true;
+    confirmService.confirm = sinon.fake.returns(reject());
+    const count = getHostSetCount();
+    await visit(urls.hostSet);
+    await click('.rose-layout-page-actions .rose-dropdown-button-danger');
+    assert.equal(getHostSetCount(), count);
+    assert.ok(confirmService.confirm.calledOnce);
+  });
+
+  test('deleting a host set which errors displays error messages', async function (assert) {
+    assert.expect(1);
+    this.server.del('/host-sets/:id', () => {
+      return new Response(
+        490,
+        {},
+        {
+          status: 490,
+          code: 'error',
+          message: 'Oops.',
+        }
+      );
+    });
+    await visit(urls.hostSet);
+    await click('.rose-layout-page-actions .rose-dropdown-button-danger');
+    assert.ok(find('[role="alert"]').textContent.trim(), 'Oops.');
+  });
+});

ui/admin/tests/acceptance/host-catalogs/host-sets/read-test.js

@@ -0,0 +1,94 @@
+import { module, test } from 'qunit';
+import { visit, currentURL, find } from '@ember/test-helpers';
+import { setupApplicationTest } from 'ember-qunit';
+import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
+import a11yAudit from 'ember-a11y-testing/test-support/audit';
+import {
+  authenticateSession,
+  // These are left here intentionally for future reference.
+  //currentSession,
+  //invalidateSession,
+} from 'ember-simple-auth/test-support';
+
+module('Acceptance | host-catalogs | host sets | read', function (hooks) {
+  setupApplicationTest(hooks);
+  setupMirage(hooks);
+
+  const instances = {
+    scopes: {
+      global: null,
+      org: null,
+      project: null,
+      hostCatalog: null,
+      host: null,
+    },
+  };
+  const urls = {
+    globalScope: null,
+    orgScope: null,
+    projectScope: null,
+    hostCatalogs: null,
+    hostCatalog: null,
+    hostSets: null,
+    hostSet: null,
+    unknownHostSet: null,
+    newHostSet: null,
+  };
+
+  hooks.beforeEach(function () {
+    // Generate resources
+    instances.scopes.global = this.server.create('scope', { id: 'global' });
+    instances.scopes.org = this.server.create('scope', {
+      type: 'org',
+      scope: { id: 'global', type: 'global' },
+    });
+    instances.scopes.project = this.server.create('scope', {
+      type: 'project',
+      scope: { id: instances.scopes.org.id, type: 'org' },
+    });
+    instances.hostCatalog = this.server.create('host-catalog', {
+      scope: instances.scopes.project,
+    });
+    instances.hostSet = this.server.create('host-set', {
+      scope: instances.scopes.project,
+      hostCatalog: instances.hostCatalog,
+    });
+    // Generate route URLs for resources
+    urls.globalScope = `/scopes/global/scopes`;
+    urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
+    urls.projectScope = `/scopes/${instances.scopes.project.id}`;
+    urls.hostCatalogs = `${urls.projectScope}/host-catalogs`;
+    urls.hostCatalog = `${urls.hostCatalogs}/${instances.hostCatalog.id}`;
+    urls.hostSets = `${urls.hostCatalog}/host-sets`;
+    urls.hostSet = `${urls.hostSets}/${instances.hostSet.id}`;
+    urls.unknownHostSet = `${urls.hostSets}/foo`;
+    urls.newHostSet = `${urls.hostSets}/new`;
+    // Generate resource couner
+    authenticateSession({});
+  });
+
+  test('visiting host sets', async function (assert) {
+    assert.expect(2);
+    await visit(urls.hostSets);
+    await a11yAudit();
+    assert.equal(currentURL(), urls.hostSets);
+    await visit(urls.hostSet);
+    await a11yAudit();
+    assert.equal(currentURL(), urls.hostSet);
+  });
+
+  test('cannot navigate to a host set form without proper authorization', async function (assert) {
+    assert.expect(1);
+    instances.hostSet.authorized_actions =
+      instances.hostSet.authorized_actions.filter((item) => item !== 'read');
+    await visit(urls.hostSet);
+    assert.notOk(find('main tbody .rose-table-header-cell:nth-child(1) a'));
+  });
+
+  test('visiting an unknown host set displays 404 message', async function (assert) {
+    assert.expect(1);
+    await visit(urls.unknownHostSet);
+    await a11yAudit();
+    assert.ok(find('.rose-message-subtitle').textContent.trim(), 'Error 404');
+  });
+});

ui/admin/tests/acceptance/host-catalogs/host-sets/update-test.js

@@ -0,0 +1,191 @@
+import { module, test } from 'qunit';
+import { visit, currentURL, find, click, fillIn } from '@ember/test-helpers';
+import { setupApplicationTest } from 'ember-qunit';
+import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
+import { Response } from 'miragejs';
+import {
+  authenticateSession,
+  // These are left here intentionally for future reference.
+  //currentSession,
+  //invalidateSession,
+} from 'ember-simple-auth/test-support';
+
+module('Acceptance | host-catalogs | host sets | update', function (hooks) {
+  setupApplicationTest(hooks);
+  setupMirage(hooks);
+
+  const instances = {
+    scopes: {
+      global: null,
+      org: null,
+      project: null,
+      hostCatalog: null,
+      host: null,
+    },
+  };
+  const urls = {
+    globalScope: null,
+    orgScope: null,
+    projectScope: null,
+    hostCatalogs: null,
+    hostCatalog: null,
+    hostSets: null,
+    hostSet: null,
+    unknownHostSet: null,
+    newHostSet: null,
+  };
+
+  hooks.beforeEach(function () {
+    // Generate resources
+    instances.scopes.global = this.server.create('scope', { id: 'global' });
+    instances.scopes.org = this.server.create('scope', {
+      type: 'org',
+      scope: { id: 'global', type: 'global' },
+    });
+    instances.scopes.project = this.server.create('scope', {
+      type: 'project',
+      scope: { id: instances.scopes.org.id, type: 'org' },
+    });
+    instances.hostCatalog = this.server.create('host-catalog', {
+      scope: instances.scopes.project,
+    });
+    instances.hostSet = this.server.create('host-set', {
+      scope: instances.scopes.project,
+      hostCatalog: instances.hostCatalog,
+    });
+    // Generate route URLs for resources
+    urls.globalScope = `/scopes/global/scopes`;
+    urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
+    urls.projectScope = `/scopes/${instances.scopes.project.id}`;
+    urls.hostCatalogs = `${urls.projectScope}/host-catalogs`;
+    urls.hostCatalog = `${urls.hostCatalogs}/${instances.hostCatalog.id}`;
+    urls.hostSets = `${urls.hostCatalog}/host-sets`;
+    urls.hostSet = `${urls.hostSets}/${instances.hostSet.id}`;
+    urls.unknownHostSet = `${urls.hostSets}/foo`;
+    urls.newHostSet = `${urls.hostSets}/new`;
+    // Generate resource couner
+    authenticateSession({});
+  });
+
+  test('saving a new host set with invalid fields displays error messages', async function (assert) {
+    assert.expect(2);
+    this.server.post('/host-sets', () => {
+      return new Response(
+        400,
+        {},
+        {
+          status: 400,
+          code: 'invalid_argument',
+          message: 'The request was invalid.',
+          details: {
+            request_fields: [
+              {
+                name: 'name',
+                description: 'Name is required.',
+              },
+            ],
+          },
+        }
+      );
+    });
+    await visit(urls.newHostSet);
+    await click('[type="submit"]');
+    assert.ok(
+      find('[role="alert"]').textContent.trim(),
+      'The request was invalid.'
+    );
+    assert.ok(
+      find('.rose-form-error-message').textContent.trim(),
+      'Name is required.'
+    );
+  });
+
+  test('can save changes to existing host', async function (assert) {
+    assert.expect(3);
+    assert.notEqual(instances.hostSet.name, 'random string');
+    await visit(urls.hostSet);
+    await click('form [type="button"]', 'Activate edit mode');
+    await fillIn('[name="name"]', 'random string');
+    await click('.rose-form-actions [type="submit"]');
+    assert.equal(currentURL(), urls.hostSet);
+    assert.equal(
+      this.server.schema.hostSets.all().models[0].name,
+      'random string'
+    );
+  });
+
+  test('cannot make changes to an existing host without proper authorization', async function (assert) {
+    assert.expect(1);
+    instances.hostSet.authorized_actions =
+      instances.hostSet.authorized_actions.filter((item) => item !== 'update');
+    await visit(urls.hostSet);
+    assert.notOk(find('.rose-layout-page-actions .rose-button-secondary'));
+  });
+
+  test('can cancel changes to existing host', async function (assert) {
+    assert.expect(2);
+    await visit(urls.hostSet);
+    await click('form [type="button"]', 'Activate edit mode');
+    await fillIn('[name="name"]', 'random string');
+    await click('.rose-form-actions [type="button"]');
+    assert.notEqual(instances.hostSet.name, 'random string');
+    assert.equal(find('[name="name"]').value, instances.hostSet.name);
+  });
+
+  test('saving an existing host set with invalid fields displays error messages', async function (assert) {
+    assert.expect(2);
+    this.server.patch('/host-sets/:id', () => {
+      return new Response(
+        400,
+        {},
+        {
+          status: 400,
+          code: 'invalid_argument',
+          message: 'The request was invalid.',
+          details: {
+            request_fields: [
+              {
+                name: 'name',
+                description: 'Name is required.',
+              },
+            ],
+          },
+        }
+      );
+    });
+    await visit(urls.hostSet);
+    await click('form [type="button"]', 'Activate edit mode');
+    await fillIn('[name="name"]', 'random string');
+    await click('[type="submit"]');
+    assert.ok(
+      find('[role="alert"]').textContent.trim(),
+      'The request was invalid.'
+    );
+    assert.ok(
+      find('.rose-form-error-message').textContent.trim(),
+      'Name is required.'
+    );
+  });
+
+  test('can discard unsaved host set changes via dialog', async function (assert) {
+    assert.expect(5);
+    const confirmService = this.owner.lookup('service:confirm');
+    confirmService.enabled = true;
+    assert.notEqual(instances.hostSet.name, 'random string');
+    await visit(urls.hostSet);
+    await click('form [type="button"]', 'Activate edit mode');
+    await fillIn('[name="name"]', 'random string');
+    assert.equal(currentURL(), urls.hostSet);
+    try {
+      await visit(urls.hostSets);
+    } catch (e) {
+      assert.ok(find('.rose-dialog'));
+      await click('.rose-dialog-footer button:first-child');
+      assert.equal(currentURL(), urls.hostSets);
+      assert.notEqual(
+        this.server.schema.hostSets.all().models[0].name,
+        'random string'
+      );
+    }
+  });
+});