Merge pull request #167 from hashicorp/host-assignment-view-updates

Host assignment view updates
2020-09-10 15:26:37 -04:00
commit 1d414e8e1c
@@ -0,0 +1,56 @@
+{{#if this.hasAvailableHosts}}
+  <Rose::Form
+    class="full-width"
+    @onSubmit={{fn this.submit @submit}}
+    @cancel={{@cancel}}
+    @disabled={{@model.isSaving}}
+    @error={{@model.errors.base}}
+    as |form|
+  >
+
+    <form.actions
+      @submitText={{t "actions.add-hosts"}}
+      @cancelText={{t "actions.cancel"}} />
+
+    <Rose::Table as |table|>
+      <table.header as |header|>
+        <header.row as |row|>
+          <row.headerCell>{{t "form.label.name"}}</row.headerCell>
+          <row.headerCell>{{t "form.label.type"}}</row.headerCell>
+          <row.headerCell>{{t "form.label.id"}}</row.headerCell>
+        </header.row>
+      </table.header>
+      <table.body as |body|>
+        {{#each this.filteredHosts as |host|}}
+          <body.row as |row|>
+            <row.cell>
+              <form.checkbox
+                @label={{host.id}}
+                @description={{host.description}}
+                onChange={{fn this.toggleHost host}} />
+            </row.cell>
+            <row.cell>{{host.name}}</row.cell>
+            <row.cell>
+              <Rose::Badge>{{host.type}}</Rose::Badge>
+            </row.cell>
+          </body.row>
+        {{/each}}
+      </table.body>
+    </Rose::Table>
+
+  </Rose::Form>
+{{/if}}
+
+{{#unless this.hasAvailableHosts}}
+  <Rose::Layout::Centered>
+    <Rose::Message @title={{t "titles.no-host-set-hosts"}} as |message|>
+      <message.description>
+        {{t "descriptions.no-host-set-hosts"}}
+      </message.description>
+      <message.link @route="scopes.scope.projects.project.host-catalogs.host-catalog.host-sets.host-set.hosts">
+        <Rose::Icon @name="chevron-left" />
+        {{t "actions.back"}}
+      </message.link>
+    </Rose::Message>
+  </Rose::Layout::Centered>
+{{/unless}}
@@ -0,0 +1,58 @@
+import Component from '@glimmer/component';
+import { computed, action } from '@ember/object';
+import { A } from '@ember/array';
+
+export default class FormHostSetAddHostsIndexComponent extends Component {
+
+  // =properties
+
+  /**
+   * Array of selected host IDs.
+   * @type {EmberArray}
+   */
+  selectedHostIDs = A();
+
+  /**
+   * Checks for unassigned hosts.
+   * @param {[HostModel]} filteredHosts
+   * @type {boolean}
+   */
+  @computed('filteredHosts')
+  get hasAvailableHosts() {
+    return this.filteredHosts.length > 0;
+  }
+
+  /**
+   * Hosts currently not assigned to current host set.
+   * @type {[HostModel]}
+   */
+  @computed('args.{model,hosts}')
+  get filteredHosts() {
+    const currentHostIDs = this.args.model.host_ids.map(host => host.value);
+    return this.args.hosts.filter(({ id }) => !currentHostIDs.includes(id));
+  }
+
+  // =actions
+
+  /**
+   * Toggle host selection
+   * @param {HostModel} host
+   */
+  @action
+  toggleHost(host) {
+    if (!this.selectedHostIDs.includes(host.id)) {
+      this.selectedHostIDs.addObject(host.id);
+    } else {
+      this.selectedHostIDs.removeObject(host.id);
+    }
+  }
+
+  /**
+   * Callback submit with selected host ids
+   * @param {requestCallback} fn
+   */
+  @action
+  submit(fn) {
+    fn(this.selectedHostIDs);
+  }
+}
@@ -26,6 +26,7 @@ Router.map(function () {
              this.route('host-sets', function() {
                this.route('host-set', { path: ':host_set_id' }, function() {
                  this.route('hosts');
+                  this.route('add-hosts');
                });
                this.route('new');
              });
@@ -13,6 +13,7 @@ export default class ScopesScopeProjectsProjectHostCatalogsHostCatalogHostSetsHo
    const { id: scopeID } = this.modelFor('scopes.scope.projects.project');
    const hostCatalogID = this.modelFor('scopes.scope.projects.project.host-catalogs.host-catalog').id;
    return this.store.findRecord('host-set', host_set_id, {
+      reload: true,
      adapterOptions: { scopeID, hostCatalogID }
    });
  }
@@ -0,0 +1,107 @@
+import Route from '@ember/routing/route';
+import { inject as service } from '@ember/service';
+import { action } from '@ember/object';
+import { hash } from 'rsvp';
+
+export default class ScopesScopeProjectsProjectHostCatalogsHostCatalogHostSetsHostSetAddHostsRoute extends Route {
+
+  // =services
+
+  @service intl;
+  @service notify;
+
+  // =methods
+
+  /**
+   * Empty out any previously loaded hosts.
+   */
+  beforeModel() {
+    this.store.unloadAll('host');
+  }
+
+  /**
+   * Loads current host set and all hosts under the current host catalog.
+   * @return {Promise{HostSetModel,[HostModel]}}
+   */
+  async model() {
+    const scopeID = this.modelFor('scopes.scope.projects.project').id;
+    const hostCatalogID = this.modelFor('scopes.scope.projects.project.host-catalogs.host-catalog').id;
+    return hash({
+      hostSet: this.modelFor('scopes.scope.projects.project.host-catalogs.host-catalog.host-sets.host-set'),
+      hosts: this.store.findAll('host', { adapterOptions: { scopeID, hostCatalogID } })
+    });
+  }
+
+  /**
+   * Renders the add-hosts-specific header template.
+   * Empties the actions and navigation outlets and renders a custom empty header.
+   * @override
+   */
+  renderTemplate() {
+    super.renderTemplate(...arguments);
+
+    this.render('scopes/scope/projects/project/host-catalogs/host-catalog/host-sets/host-set/add-hosts/-header', {
+      into: 'scopes/scope/projects/project/host-catalogs/host-catalog',
+      outlet: 'header',
+    });
+
+    this.render('-empty', {
+      into: 'scopes/scope/projects/project/host-catalogs/host-catalog',
+      outlet: 'navigation',
+    });
+
+    this.render('-empty', {
+      into: 'scopes/scope/projects/project/host-catalogs/host-catalog',
+      outlet: 'actions',
+    });
+  }
+
+  // =actions
+
+  /**
+   * Toggles the presence of the passed host ID in the passed host set's
+   * `host_ids` field.
+   * @param {HostSetModel} hostSet
+   * @param {HostModel} host
+   */
+  @action
+  toggleHost(hostSet, host) {
+    const isHostSelected = Boolean(hostSet.host_ids.findBy('value', host.id));
+    const fragment = hostSet.host_ids.findBy('value', host.id);
+    if (isHostSelected) {
+      // if host is already selected, filter it out
+      hostSet.host_ids.removeObject(fragment);
+    } else {
+      // if host is not selected, add it
+      hostSet.host_ids.addObject({ value: host.id });
+    }
+  }
+
+  /**
+   * Saves host IDs on the host set.
+   * @param {HostSetModel} hostSet
+   */
+  @action
+  async addHosts(hostSet, hostIDs) {
+    try {
+      const scopeID = this.modelFor('scopes.scope.projects.project').id;
+      const hostCatalogID = this.modelFor('scopes.scope.projects.project.host-catalogs.host-catalog').id;
+      await hostSet.addHosts(hostIDs, { adapterOptions : { scopeID, hostCatalogID } });
+      this.notify.success(
+        this.intl.t('notify.save-success')
+      );
+      this.replaceWith('scopes.scope.projects.project.host-catalogs.host-catalog.host-sets.host-set.hosts');
+    } catch (error) {
+      // TODO: replace with translated strings
+      this.notify.error(error.message, { closeAfter: null });
+    }
+  }
+
+  /**
+   * Redirect to hosts as if nothing ever happened.
+   */
+  @action
+  cancel() {
+    this.replaceWith('scopes.scope.projects.project.host-catalogs.host-catalog.host-sets.host-set.hosts');
+  }
+}
@@ -1,7 +1,7 @@
 import Route from '@ember/routing/route';
-import { inject as service } from '@ember/service';
+import { hash, all } from 'rsvp';
 import { action } from '@ember/object';
-import { hash } from 'rsvp';
+import { inject as service } from '@ember/service';

 export default class ScopesScopeProjectsProjectHostCatalogsHostCatalogHostSetsHostSetHostsRoute extends Route {

@@ -13,58 +13,44 @@ export default class ScopesScopeProjectsProjectHostCatalogsHostCatalogHostSetsHo
  // =methods

  /**
-   * Loads all hosts under the current host catalog.
-   * @return {Promise{[HostModel]}}
+   * Empty out any previously loaded hosts.
+   */
+  beforeModel() {
+    this.store.unloadAll('host');
+  }
+
+  /**
+   * Loads all hosts under the current host set.
+   * @return {Promise{HostSetModel,[HostModel]}}
   */
  async model() {
    const scopeID = this.modelFor('scopes.scope.projects.project').id;
    const hostCatalogID = this.modelFor('scopes.scope.projects.project.host-catalogs.host-catalog').id;
    const hostSet = this.modelFor('scopes.scope.projects.project.host-catalogs.host-catalog.host-sets.host-set');
-    this.store.unloadAll('host');
    return hash({
      hostSet,
-      hosts: this.store.findAll('host', { adapterOptions: { scopeID, hostCatalogID } })
+      hosts: all(hostSet.host_ids.map(host =>
+        this.store.findRecord('host', host.value, { adapterOptions: { scopeID, hostCatalogID } })
+      ))
    });
  }

-  // =actions
-
  /**
-   * Toggles the presence of the passed host ID in the passed host set's
-   * `host_ids` field.
+   * Remove a host from the current host set and redirect to hosts index.
   * @param {HostSetModel} hostSet
   * @param {HostModel} host
   */
  @action
-  toggleHost(hostSet, host) {
-    const isHostSelected = Boolean(hostSet.host_ids.findBy('value', host.id));
-    const fragment = hostSet.host_ids.findBy('value', host.id);
-    if (isHostSelected) {
-      // if host is already selected, filter it out
-      hostSet.host_ids.removeObject(fragment);
-    } else {
-      // if host is not selected, add it
-      hostSet.host_ids.addObject({ value: host.id });
-    }
-  }
-
-  /**
-   * Saves host IDs on the host set.
-   * @param {HostSetModel} hostSet
-   */
-  @action
-  async save(hostSet) {
+  async removeHost(hostSet, host) {
    try {
+      const scopeID = this.modelFor('scopes.scope.projects.project').id;
      const hostCatalogID = this.modelFor('scopes.scope.projects.project.host-catalogs.host-catalog').id;
-      const options = { adapterOptions : { hostCatalogID } };
-      await hostSet.saveHostIDs(options);
-      this.notify.success(
-        this.intl.t('notify.save-success')
-      );
+      await hostSet.removeHost(host.id, { adapterOptions : { scopeID, hostCatalogID } });
+      this.refresh();
+      this.notify.success(this.intl.t('notify.delete-success'));
    } catch (error) {
      // TODO: replace with translated strings
      this.notify.error(error.message, { closeAfter: null });
    }
  }
-
 }
@@ -1,4 +1,7 @@
 <Rose::Dropdown @text="{{t 'actions.manage'}}" @dropdownRight={{true}} as |dropdown|>
+  <dropdown.link @route="scopes.scope.projects.project.host-catalogs.host-catalog.host-sets.host-set.add-hosts">
+    {{t 'actions.add-hosts'}}
+  </dropdown.link>
  <dropdown.button
    @style="danger"
    @disabled={{@model.canSave}}
@@ -0,0 +1,8 @@
+{{title (t "actions.add-hosts")}}
+
+<Form::HostSet::AddHosts
+  @model={{@model.hostSet}}
+  @hosts={{@model.hosts}}
+  @submit={{route-action "addHosts" @model.hostSet}}
+  @cancel={{route-action "cancel"}}
+/>
@@ -0,0 +1 @@
+<h2>{{t "actions.add-hosts"}}</h2>
@@ -1,11 +1,53 @@
 {{#if @model.hosts}}
-  <Form::HostSet::Hosts
-    @model={{@model.hostSet}}
-    @hosts={{@model.hosts}}
-    @submit={{route-action "save" @model.hostSet}}
-    @cancel={{route-action "cancel" @model.hostSet}}
-    @toggleHost={{route-action "toggleHost" @model.hostSet}}
-  />
+
+  <Rose::Table as |table|>
+    <table.header as |header|>
+      <header.row as |row|>
+        <row.headerCell>{{t "form.label.name"}}</row.headerCell>
+        <row.headerCell>{{t "form.label.type"}}</row.headerCell>
+        <row.headerCell>{{t "form.label.id"}}</row.headerCell>
+        <row.headerCell>{{t "form.label.actions"}}</row.headerCell>
+      </header.row>
+    </table.header>
+    <table.body as |body|>
+      {{#each @model.hosts as |host|}}
+        <body.row as |row|>
+          <row.headerCell>
+            <LinkTo
+              @route="scopes.scope.projects.project.host-catalogs.host-catalog.hosts.host"
+              @model={{host.id}}
+            >
+              {{host.displayName}}
+            </LinkTo>
+            <p>{{host.description}}</p>
+          </row.headerCell>
+          <row.cell>
+            <Rose::Badge>{{host.type}}</Rose::Badge>
+          </row.cell>
+          <row.cell>
+            <code>{{host.id}}</code>
+          </row.cell>
+          <row.cell>
+            <Rose::Dropdown
+              @icon="more-horizontal"
+              @iconOnly={{true}}
+              @showCaret={{false}}
+              @dropdownRight={{true}}
+              @text="{{t "actions.manage"}}" as |dropdown|
+            >
+              <dropdown.button
+                @style="danger"
+                {{on "click" (route-action "removeHost" @model.hostSet host)}}
+              >
+                {{t "actions.remove"}}
+              </dropdown.button>
+            </Rose::Dropdown>
+          </row.cell>
+        </body.row>
+      {{/each}}
+    </table.body>
+  </Rose::Table>
+
 {{/if}}

 {{#unless @model.hosts}}
@@ -183,9 +183,30 @@ export default function() {
  this.post('/scopes/:scope_id/host-catalogs/:hostCatalogId/host-sets/:idMethod', function ({ hostSets }, { params: { idMethod } }) {
    const attrs = this.normalizedRequestAttrs();
    const id = idMethod.split(':')[0];
+    const method = idMethod.split(':')[1];
    const hostSet = hostSets.find(id);
-    attrs.id = id;
-    return hostSet.update(attrs);
+    const updatedAttrs = {
+      version: attrs.version,
+      hostIds: hostSet.hostIds
+    }
+
+    // If adding hosts, push them into the array
+    if(method === 'add-hosts') {
+      attrs.hostIds.forEach(id => {
+        if(!updatedAttrs.hostIds.includes(id)) {
+          updatedAttrs.hostIds.push(id);
+        }
+      })
+    }
+
+    // If deleting hosts, filter them out of the array
+    if (method === 'remove-hosts') {
+      updatedAttrs.hostIds = updatedAttrs.hostIds.filter(id => {
+        return !attrs.hostIds.includes(id);
+      });
+    }
+
+    return hostSet.update(updatedAttrs);
  });

  // target
@@ -0,0 +1,12 @@
+import { module, test } from 'qunit';
+import { setupRenderingTest } from 'ember-qunit';
+// import { render } from '@ember/test-helpers';
+// import { hbs } from 'ember-cli-htmlbars';
+
+module('Integration | Component | form/host-set/add-hosts', function(hooks) {
+  setupRenderingTest(hooks);
+
+  test('it renders', async function(assert) {
+    assert.expect(0);
+  });
+});
@@ -0,0 +1,11 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('Unit | Route | scopes/scope/projects/project/host-catalogs/host-catalog/host-sets/host-set/add-hosts', function(hooks) {
+  setupTest(hooks);
+
+  test('it exists', function(assert) {
+    let route = this.owner.lookup('route:scopes/scope/projects/project/host-catalogs/host-catalog/host-sets/host-set/add-hosts');
+    assert.ok(route);
+  });
+});
@@ -26,6 +26,7 @@ actions:
  add-host-sets: Add Host Sets
  add-principals: Add Principals
  add-members: Add Members
+  add-hosts: Add Hosts
 auth:
  titles:
    no-scopes: No Scopes Available