feat: 🎸 reintroduce host catalogs

This commit is contained in:
Randall Morey committed 2020-10-28 18:19:14 -04:00
1 parent f7118f2216
commit 225373d437
22 files changed
+724 -4

No files matched your search

@@ -0,0 +1,53 @@
<Rose::Form
@onSubmit={{@submit}}
@cancel={{@cancel}}
@disabled={{@model.isSaving}}
@error={{@model.errors.base}}
@showEditToggle={{if @model.isNew false true}}
as |form|
>
<form.input
@name="name"
@type="name"
@value={{@model.name}}
@label={{t "form.name.label"}}
@helperText={{t "form.name.help"}}
@error={{@model.errors.name}}
readonly={{false}}
as |field|>
{{#if @model.errors.name}}
<field.errors as |errors|>
{{#each @model.errors.name as |error|}}
<errors.message>{{error.message}}</errors.message>
{{/each}}
</field.errors>
{{/if}}
</form.input>
<form.textarea
@name="description"
@type="description"
@value={{@model.description}}
@label={{t "form.description.label"}}
@helperText={{t "form.description.help"}}
@error={{@model.errors.description}}
disabled={{@model.isSaving}}
readonly={{false}}
as |field|>
{{#if @model.errors.description}}
<field.errors as |errors|>
{{#each @model.errors.description as |error|}}
<errors.message>{{error.message}}</errors.message>
{{/each}}
</field.errors>
{{/if}}
</form.textarea>
<form.actions
@disabled={{if @model.cannotSave @model.cannotSave}}
@enableEditText={{t "actions.edit-form"}}
@submitText={{t "actions.save"}}
@cancelText={{t "actions.cancel"}} />
</Rose::Form>
+5 -2
View File
@@ -9,7 +9,6 @@ export default class Router extends EmberRouter {
Router.map(function () {
this.route('scopes', function () {
this.route('scope', { path: ':scope_id' }, function () {
this.route('authenticate', function () {
this.route('method', { path: ':auth_method_id' });
});
@@ -64,7 +63,11 @@ Router.map(function () {
});
this.route('new');
});
this.route('host-catalogs', function() {
this.route('new');
this.route('host-catalog', { path: ':host_catalog_id' }, function() {});
});
});
});
@@ -0,0 +1,70 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { action } from '@ember/object';
import loading from 'ember-loading/decorator';
import { confirm } from '../../../decorators/confirm';
import { notifySuccess, notifyError } from '../../../decorators/notify';
export default class ScopesScopeHostCatalogsRoute extends Route {
// =services
@service intl;
@service notify;
// =methods
/**
* Loads all host catalogs under the current scope.
* @return {Promise{[HostCatalogModel]}}
*/
async model() {
const { id: scope_id } = this.modelFor('scopes.scope');
return this.store.query('host-catalog', { scope_id });
}
// =actions
/**
* Rollback changes on host catalog.
* @param {HostCatalogModel} hostCatalog
*/
@action
cancel(hostCatalog) {
const { isNew } = hostCatalog;
hostCatalog.rollbackAttributes();
if (isNew) this.transitionTo('scopes.scope.host-catalogs');
}
/**
* Handle save.
* @param {HostCatalogModel} hostCatalog
* @param {Event} e
*/
@action
@loading
@notifyError(({ message }) => message)
@notifySuccess(({ isNew }) => isNew ? 'notifications.create-success' : 'notifications.save-success')
async save(hostCatalog) {
await hostCatalog.save();
await this.transitionTo(
'scopes.scope.host-catalogs.host-catalog',
hostCatalog
);
this.refresh();
}
/**
* Deletes the host catalog and redirects to index.
* @param {HostCatalogModel} hostCatalog
*/
@action
@loading
@confirm('questions.delete-confirm')
@notifyError(({ message }) => message, { catch: true })
@notifySuccess('notifications.delete-success')
async delete(hostCatalog) {
await hostCatalog.destroyRecord();
await this.replaceWith('scopes.scope.host-catalogs');
this.refresh();
}
}
@@ -0,0 +1,53 @@
import Route from '@ember/routing/route';
export default class ScopesScopeHostCatalogsHostCatalogRoute extends Route {
// =methods
/**
* Load a host catalog.
* @param {object} params
* @param {string} params.host_catalog_id
* @return {HostCatalogModel}
*/
async model({ host_catalog_id }) {
return this.store.findRecord('host-catalog', host_catalog_id);
}
/**
* Renders the host-catalog specific templates for header, navigation,
* and actions page sections.
* @override
* @param {object} controller
* @param {object} model
*/
renderTemplate(controller, model) {
super.renderTemplate(...arguments);
this.render(
'scopes/scope/host-catalogs/host-catalog/-header',
{
into: 'scopes/scope/host-catalogs/host-catalog',
outlet: 'header',
model: model,
}
);
this.render(
'scopes/scope/host-catalogs/host-catalog/-navigation',
{
into: 'scopes/scope/host-catalogs/host-catalog',
outlet: 'navigation',
model: model,
}
);
this.render(
'scopes/scope/host-catalogs/host-catalog/-actions',
{
into: 'scopes/scope/host-catalogs/host-catalog',
outlet: 'actions',
model: model,
}
);
}
}
@@ -0,0 +1,3 @@
import Route from '@ember/routing/route';
export default class ScopesScopeHostCatalogsHostCatalogIndexRoute extends Route {}
@@ -0,0 +1,4 @@
import Route from '@ember/routing/route';
export default class ScopesScopeHostCatalogsIndexRoute extends Route {
}
@@ -0,0 +1,17 @@
import Route from '@ember/routing/route';
export default class ScopesScopeHostCatalogsNewRoute extends Route {
// =methods
/**
* Creates a new unsaved host catalog belonging to the current scope.
* @return {HostCatalogModel}
*/
model() {
const scopeModel = this.modelFor('scopes.scope');
return this.store.createRecord('host-catalog', {
type: 'static',
scopeModel,
});
}
}
-2
View File
@@ -81,14 +81,12 @@
@size="medium" />
{{t "resources.target.title_plural"}}
</nav.link>
{{!--
<nav.link @route="scopes.scope.host-catalogs">
<Rose::Icon
@name="app-icons/host-catalogs"
@size="medium" />
{{t "resources.host-catalog.title_plural"}}
</nav.link>
--}}
</Rose::Nav::Sidebar>
{{/if}}
@@ -0,0 +1,3 @@
{{title (t "resources.host-catalog.title_plural")}}
{{outlet}}
@@ -0,0 +1,25 @@
{{title @model.displayName}}
<Rose::Layout::Page as |page|>
<page.breadcrumbs>
<BreadCrumbs />
</page.breadcrumbs>
<page.header>
{{outlet "header"}}
</page.header>
<page.actions>
{{outlet "actions"}}
</page.actions>
<page.navigation>
{{outlet "navigation"}}
</page.navigation>
<page.body>
{{outlet}}
</page.body>
</Rose::Layout::Page>
@@ -0,0 +1,24 @@
<Rose::Dropdown @text="{{t 'actions.manage'}}" @dropdownRight={{true}} as |dropdown|>
{{!--
<dropdown.link
@route="scopes.scope.host-catalogs.host-catalog.hosts.new"
@model={{@model}}
>
{{t "resources.host.actions.create"}}
</dropdown.link>
<dropdown.link
@route="scopes.scope.host-catalogs.host-catalog.host-sets.new"
@model={{@model}}
>
{{t "resources.host-set.actions.create"}}
</dropdown.link>
--}}
<dropdown.separator />
<dropdown.button
@style="danger"
@disabled={{@model.canSave}}
{{on "click" (route-action "delete" @model)}}
>
{{t "resources.host-catalog.actions.delete"}}
</dropdown.button>
</Rose::Dropdown>
@@ -0,0 +1,12 @@
<h2>
{{t "resources.host-catalog.title"}}
<DocLink @doc="host-catalog" @iconSize="large" />
</h2>
<p>{{t "resources.host-catalog.description"}}</p>
<Copyable
@text={{@model.id}}
@buttonText={{t "actions.copy-to-clipboard"}}
@acknowledgeText={{t "states.copied"}}
>
<code>{{@model.id}}</code>
</Copyable>
@@ -0,0 +1,13 @@
<Rose::Nav::Tabs as |nav|>
<nav.link @route='scopes.scope.host-catalogs.host-catalog.index'>
{{t 'titles.details'}}
</nav.link>
{{!--
<nav.link @route='scopes.scope.host-catalogs.host-catalog.host-sets'>
{{t 'resources.host-set.title_plural'}}
</nav.link>
<nav.link @route='scopes.scope.host-catalogs.host-catalog.hosts'>
{{t 'resources.host.title_plural'}}
</nav.link>
--}}
</Rose::Nav::Tabs>
@@ -0,0 +1,5 @@
<Form::HostCatalog
@model={{@model}}
@submit={{route-action "save" @model}}
@cancel={{route-action "cancel" @model}}
/>
@@ -0,0 +1,86 @@
<Rose::Layout::Page as |page|>
<page.breadcrumbs>
<BreadCrumbs />
</page.breadcrumbs>
<page.header>
<h2>
{{t "resources.host-catalog.title_plural"}}
<DocLink @doc="host-catalog" @iconSize="large" />
</h2>
{{#if @model}}
<p>{{t "resources.host-catalog.description"}}</p>
{{/if}}
</page.header>
<page.actions>
{{#if @model}}
<Rose::LinkButton @route="scopes.scope.host-catalogs.new" @style="primary">
{{t "titles.new"}}
</Rose::LinkButton>
{{/if}}
</page.actions>
<page.body>
{{#if @model}}
<Rose::Table as |table|>
<table.header as |header|>
<header.row as |row|>
<row.headerCell>{{t "form.name.label"}}</row.headerCell>
<row.headerCell>{{t "form.type.label"}}</row.headerCell>
<row.headerCell>{{t "form.id.label"}}</row.headerCell>
</header.row>
</table.header>
<table.body as |body|>
{{#each @model as |hostCatalog|}}
<body.row as |row|>
<row.headerCell>
<LinkTo
@route="scopes.scope.host-catalogs.host-catalog"
@model={{hostCatalog.id}}
>
{{hostCatalog.displayName}}
</LinkTo>
<p>{{hostCatalog.description}}</p>
</row.headerCell>
<row.cell>
<Rose::Badge>
{{t (concat 'resources.host-catalog.types.' hostCatalog.type)}}
</Rose::Badge>
</row.cell>
<row.cell>
<Copyable
@text={{hostCatalog.id}}
@buttonText={{t "actions.copy-to-clipboard"}}
@acknowledgeText={{t "states.copied"}}
>
<code>{{hostCatalog.id}}</code>
</Copyable>
</row.cell>
</body.row>
{{/each}}
</table.body>
</Rose::Table>
{{else}}
<Rose::Layout::Centered>
<Rose::Message @title={{t "resources.host-catalog.messages.welcome.title"}} as |message|>
<message.description>
{{t "resources.host-catalog.description"}}
</message.description>
<message.link @route="scopes.scope.host-catalogs.new">
<Rose::Icon @name="plus-circle-outline" />
{{t "titles.new"}}
</message.link>
</Rose::Message>
</Rose::Layout::Centered>
{{/if}}
</page.body>
</Rose::Layout::Page>
@@ -0,0 +1,24 @@
{{title (t 'titles.new')}}
<Rose::Layout::Page as |page|>
<page.breadcrumbs>
<BreadCrumbs />
</page.breadcrumbs>
<page.header>
<h2>
{{t "titles.new"}}
<DocLink @doc="host-catalog.new" @iconSize="large" />
</h2>
</page.header>
<page.body>
<Form::HostCatalog
@model={{@model}}
@submit={{route-action "save" @model}}
@cancel={{route-action "cancel" @model}}
/>
</page.body>
</Rose::Layout::Page>
@@ -0,0 +1,272 @@
import { module, test } from 'qunit';
import { visit, currentURL, find, click, fillIn } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { Response } from 'miragejs';
import { resolve, reject } from 'rsvp';
import sinon from 'sinon';
import {
authenticateSession,
// These are left here intentionally for future reference.
//currentSession,
//invalidateSession,
} from 'ember-simple-auth/test-support';
module('Acceptance | host-catalogs', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);
let gethostCatalogCount;
const instances = {
scopes: {
global: null,
org: null,
project: null,
}
};
const urls = {
globalScope: null,
orgScope: null,
projectScope: null,
hostCatalogs: null,
hostCatalog: null,
newHostCatalog: null,
};
hooks.beforeEach(function () {
// Generate resources
instances.scopes.global = this.server.create('scope', { id: 'global' });
instances.scopes.org = this.server.create('scope', {
type: 'org',
scope: { id: 'global', type: 'global' },
});
instances.scopes.project = this.server.create('scope', {
type: 'project',
scope: { id: instances.scopes.org.id, type: 'org' },
});
instances.hostCatalog = this.server.create('host-catalog', {
scope: instances.scopes.project,
});
// Generate route URLs for resources
urls.globalScope = `/scopes/global/scopes`;
urls.orgScope = `/scopes/${instances.scopes.org.id}/scopes`;
urls.projectScope = `/scopes/${instances.scopes.project.id}`;
urls.hostCatalogs = `${urls.projectScope}/host-catalogs`;
urls.hostCatalog = `${urls.hostCatalogs}/${instances.hostCatalog.id}`;
urls.unknownHostCatalog = `${urls.hostCatalogs}/foo`;
urls.newHostCatalog = `${urls.hostCatalogs}/new`;
// Generate resource couner
gethostCatalogCount = () => this.server.schema.hostCatalogs.all().models.length;
authenticateSession({});
});
test('visiting host catalogs', async function (assert) {
assert.expect(2);
await visit(urls.hostCatalogs);
await a11yAudit();
assert.equal(currentURL(), urls.hostCatalogs);
await visit(urls.hostCatalog);
await a11yAudit();
assert.equal(currentURL(), urls.hostCatalog);
});
test('visiting an unknown host catalog displays 404 message', async function (assert) {
assert.expect(1);
await visit(urls.unknownHostCatalog);
await a11yAudit();
assert.ok(find('.rose-message-subtitle').textContent.trim(), 'Error 404');
});
test('can create new host catalogs', async function (assert) {
assert.expect(1);
const count = gethostCatalogCount();
await visit(urls.newHostCatalog);
await fillIn('[name="name"]', 'random string');
await click('[type="submit"]');
assert.equal(gethostCatalogCount(), count + 1);
});
test('can cancel create new host catalogs', async function (assert) {
assert.expect(2);
const count = gethostCatalogCount();
await visit(urls.newHostCatalog);
await fillIn('[name="name"]', 'random string');
await click('.rose-form-actions [type="button"]');
assert.equal(currentURL(), urls.hostCatalogs);
assert.equal(gethostCatalogCount(), count);
});
test('saving a new host catalog with invalid fields displays error messages', async function (assert) {
assert.expect(2);
this.server.post('/host-catalogs', () => {
return new Response(
400,
{},
{
status: 400,
code: 'invalid_argument',
message: 'The request was invalid.',
details: {
request_fields: [
{
name: 'name',
description: 'Name is required.',
},
],
},
}
);
});
await visit(urls.newHostCatalog);
await click('[type="submit"]');
assert.ok(find('[role="alert"]').textContent.trim(), 'The request was invalid.');
assert.ok(
find('.rose-form-error-message').textContent.trim(),
'Name is required.'
);
});
test('can save changes to existing host catalog', async function (assert) {
assert.expect(3);
assert.notEqual(instances.hostCatalog.name, 'random string');
await visit(urls.hostCatalog);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
await click('.rose-form-actions [type="submit"]');
assert.equal(currentURL(), urls.hostCatalog);
assert.equal(this.server.schema.hostCatalogs.all().models[0].name, 'random string');
});
test('can cancel changes to existing host catalog', async function (assert) {
assert.expect(2);
await visit(urls.hostCatalog);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
await click('.rose-form-actions [type="button"]');
assert.notEqual(instances.hostCatalog.name, 'random string');
assert.equal(find('[name="name"]').value, instances.hostCatalog.name);
});
test('saving an existing host catalog with invalid fields displays error messages', async function (assert) {
assert.expect(2);
this.server.patch('/host-catalogs/:id', () => {
return new Response(
400,
{},
{
status: 400,
code: 'invalid_argument',
message: 'The request was invalid.',
details: {
request_fields: [
{
name: 'name',
description: 'Name is required.',
},
],
},
}
);
});
await visit(urls.hostCatalog);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
await click('[type="submit"]');
assert.ok(find('[role="alert"]').textContent.trim(), 'The request was invalid.');
assert.ok(
find('.rose-form-error-message').textContent.trim(),
'Name is required.'
);
});
test('can discard unsaved host catalog changes via dialog', async function (assert) {
assert.expect(5);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
assert.notEqual(instances.hostCatalog.name, 'random string');
await visit(urls.hostCatalog);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
assert.equal(currentURL(), urls.hostCatalog);
try {
await visit(urls.hostCatalogs);
} catch (e) {
assert.ok(find('.rose-dialog'));
await click('.rose-dialog-footer button:first-child');
assert.equal(currentURL(), urls.hostCatalogs);
assert.notEqual(this.server.schema.hostCatalogs.all().models[0].name, 'random string');
}
});
test('can cancel discard unsaved host catalog changes via dialog', async function (assert) {
assert.expect(5);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
assert.notEqual(instances.hostCatalog.name, 'random string');
await visit(urls.hostCatalog);
await click('form [type="button"]', 'Activate edit mode');
await fillIn('[name="name"]', 'random string');
assert.equal(currentURL(), urls.hostCatalog);
try {
await visit(urls.hostCatalogs);
} catch (e) {
assert.ok(find('.rose-dialog'));
await click('.rose-dialog-footer button:last-child');
assert.equal(currentURL(), urls.hostCatalog);
assert.notEqual(this.server.schema.hostCatalogs.all().models[0].name, 'random string');
}
});
test('can delete host catalog', async function (assert) {
assert.expect(1);
const count = gethostCatalogCount();
await visit(urls.hostCatalog);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.equal(gethostCatalogCount(), count - 1);
});
test('can accept delete host catalog via dialog', async function (assert) {
assert.expect(2);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
confirmService.confirm = sinon.fake.returns(resolve());
const count = gethostCatalogCount();
await visit(urls.hostCatalog);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.equal(gethostCatalogCount(), count - 1);
assert.ok(confirmService.confirm.calledOnce);
});
test('cannot cancel delete host catalog via dialog', async function (assert) {
assert.expect(2);
const confirmService = this.owner.lookup('service:confirm');
confirmService.enabled = true;
confirmService.confirm = sinon.fake.returns(reject());
const count = gethostCatalogCount();
await visit(urls.hostCatalog);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.equal(gethostCatalogCount(), count);
assert.ok(confirmService.confirm.calledOnce);
});
test('deleting a host catalog which errors displays error messages', async function (assert) {
assert.expect(1);
this.server.del('/host-catalogs/:id', () => {
return new Response(
490,
{},
{
status: 490,
code: 'error',
message: 'Oops.',
}
);
});
await visit(urls.hostCatalog);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
assert.ok(find('[role="alert"]').textContent.trim(), 'Oops.');
});
});
@@ -0,0 +1,11 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
module('Unit | Route | scopes/scope/host-catalogs', function(hooks) {
setupTest(hooks);
test('it exists', function(assert) {
let route = this.owner.lookup('route:scopes/scope/host-catalogs');
assert.ok(route);
});
});
@@ -0,0 +1,11 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
module('Unit | Route | scopes/scope/host-catalogs/host-catalog', function(hooks) {
setupTest(hooks);
test('it exists', function(assert) {
let route = this.owner.lookup('route:scopes/scope/host-catalogs/host-catalog');
assert.ok(route);
});
});
@@ -0,0 +1,11 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
module('Unit | Route | scopes/scope/host-catalogs/host-catalog/index', function(hooks) {
setupTest(hooks);
test('it exists', function(assert) {
let route = this.owner.lookup('route:scopes/scope/host-catalogs/host-catalog/index');
assert.ok(route);
});
});
@@ -0,0 +1,11 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
module('Unit | Route | scopes/scope/host-catalogs/index', function(hooks) {
setupTest(hooks);
test('it exists', function(assert) {
let route = this.owner.lookup('route:scopes/scope/host-catalogs/index');
assert.ok(route);
});
});
@@ -0,0 +1,11 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
module('Unit | Route | scopes/scope/host-catalogs/new', function(hooks) {
setupTest(hooks);
test('it exists', function(assert) {
let route = this.owner.lookup('route:scopes/scope/host-catalogs/new');
assert.ok(route);
});
});