fix: 🐛 Fix deleted resources existing on session recordings (#205)

addons/api/mirage/factories/session-recording.js

@@ -36,9 +36,9 @@ export default factory.extend({
       target.id = 'deleted_target';
 
       sessionRecording.update({
-        user,
-        target,
-        session,
+        user: user.attrs,
+        target: target.attrs,
+        sessionId: session.id,
       });
     },
   }),
@@ -52,9 +52,9 @@ export default factory.extend({
       );
 
       sessionRecording.update({
-        user,
-        target,
-        session,
+        user: user.attrs,
+        target: target.attrs,
+        sessionId: session.id,
       });
     },
   }),

addons/api/mirage/models/session-recording.js

@@ -7,8 +7,5 @@ import { belongsTo, hasMany, Model } from 'miragejs';
 
 export default Model.extend({
   scope: belongsTo(),
-  user: belongsTo(),
-  session: belongsTo(),
-  target: belongsTo(),
   connection_recordings: hasMany(),
 });

ui/admin/tests/acceptance/session-recordings/list-test.js

@@ -38,7 +38,7 @@ module('Acceptance | session recordings | list', function (hooks) {
       scope: instances.scopes.global,
     });
     instances.sessionRecording = this.server.create('session-recording', {
-      target: instances.scopes.targetModel,
+      target: instances.scopes.targetModel.attrs,
     });
     urls.globalScope = `/scopes/global`;
     urls.sessionRecordings = `${urls.globalScope}/session-recordings`;