refactor: 💡 remove renderTemplate usage from groups resource

This commit is contained in:
Randall Morey committed 2022-01-25 09:40:30 -05:00
1 parent bc9526f008
commit 2febf3ac3c
10 files changed
+142 -153

No files matched your search

@@ -12,27 +12,4 @@ export default class ScopesScopeGroupsGroupRoute extends Route {
model({ group_id }) {
return this.store.findRecord('group', group_id, { reload: true });
}
/**
* Renders the route-set specific page sections
* @override
*/
renderTemplate() {
super.renderTemplate(...arguments);
this.render('scopes/scope/groups/group/-header', {
into: 'scopes/scope/groups/group',
outlet: 'header',
});
this.render('scopes/scope/groups/group/-actions', {
into: 'scopes/scope/groups/group',
outlet: 'actions',
});
this.render('scopes/scope/groups/group/-navigation', {
into: 'scopes/scope/groups/group',
outlet: 'navigation',
});
}
}
@@ -34,29 +34,6 @@ export default class ScopesScopeGroupsGroupAddMembersRoute extends Route {
});
}
/**
* Renders the route-set specific page sections
* @override
*/
renderTemplate() {
super.renderTemplate(...arguments);
this.render('scopes/scope/groups/group/add-members/-header', {
into: 'scopes/scope/groups/group',
outlet: 'header',
});
this.render('-empty', {
into: 'scopes/scope/groups/group',
outlet: 'actions',
});
this.render('-empty', {
into: 'scopes/scope/groups/group',
outlet: 'navigation',
});
}
// =actions
/**
@@ -1,25 +1,3 @@
{{page-title @model.displayName}}
<Rose::Layout::Page as |page|>
<page.breadcrumbs>
<BreadCrumbs />
</page.breadcrumbs>
<page.header>
{{outlet 'header'}}
</page.header>
<page.navigation>
{{outlet 'navigation'}}
</page.navigation>
<page.actions>
{{outlet 'actions'}}
</page.actions>
<page.body>
{{outlet}}
</page.body>
</Rose::Layout::Page>
{{outlet}}
@@ -1,8 +1,26 @@
{{page-title (t 'resources.group.messages.add-members.title')}}
<Form::Group::AddMembers
@model={{@model.group}}
@users={{@model.users}}
@submit={{route-action 'addMembers' @model.group}}
@cancel={{route-action 'cancel'}}
/>
<Rose::Layout::Page as |page|>
<page.breadcrumbs>
<BreadCrumbs />
</page.breadcrumbs>
<page.header>
<h2>
{{t 'resources.group.messages.add-members.title'}}
<DocLink @doc='group.add-members' @iconSize='large' />
</h2>
<p>{{t 'resources.group.messages.add-members.description'}}</p>
</page.header>
<page.body>
<Form::Group::AddMembers
@model={{@model.group}}
@users={{@model.users}}
@submit={{route-action 'addMembers' @model.group}}
@cancel={{route-action 'cancel'}}
/>
</page.body>
</Rose::Layout::Page>
@@ -1,5 +0,0 @@
<h2>
{{t 'resources.group.messages.add-members.title'}}
<DocLink @doc='group.add-members' @iconSize='large' />
</h2>
<p>{{t 'resources.group.messages.add-members.description'}}</p>
@@ -1,5 +1,27 @@
<Form::Group
@model={{@model}}
@submit={{route-action 'save' @model}}
@cancel={{route-action 'cancel' @model}}
/>
<Rose::Layout::Page as |page|>
<page.breadcrumbs>
<BreadCrumbs />
</page.breadcrumbs>
<page.header>
<Groups::Group::Header @model={{@model}} />
</page.header>
<page.navigation>
<Groups::Group::Nav @model={{@model}} />
</page.navigation>
<page.actions>
<Groups::Group::Actions @model={{@model}} />
</page.actions>
<page.body>
<Form::Group
@model={{@model}}
@submit={{route-action 'save' @model}}
@cancel={{route-action 'cancel' @model}}
/>
</page.body>
</Rose::Layout::Page>
@@ -1,75 +1,97 @@
{{page-title (t 'resources.group.messages.members.title')}}
{{#if @model.members}}
<Rose::Layout::Page as |page|>
<Rose::Table as |table|>
<table.header as |header|>
<header.row as |row|>
<row.headerCell>{{t 'form.name.label'}}</row.headerCell>
<row.headerCell>{{t 'form.id.label'}}</row.headerCell>
<row.headerCell>{{t 'titles.actions'}}</row.headerCell>
</header.row>
</table.header>
<table.body as |body|>
{{#each @model.members as |member|}}
<body.row as |row|>
<row.headerCell>
{{member.displayName}}
{{#if member.accountName}}
<br /><Rose::Badge>{{member.accountName}}</Rose::Badge>
{{/if}}
</row.headerCell>
<row.cell>
<Copyable
@text={{member.id}}
@buttonText={{t 'actions.copy-to-clipboard'}}
@acknowledgeText={{t 'states.copied'}}
>
<code>{{member.id}}</code>
</Copyable>
</row.cell>
<row.cell>
{{#if (can 'removeMembers group' @model.group)}}
<Rose::Dropdown
@icon='flight-icons/svg/more-horizontal-16'
@iconOnly={{true}}
@showCaret={{false}}
@dropdownRight={{true}}
@text='{{t 'actions.manage'}}'
as |dropdown|
>
<dropdown.button
@style='danger'
{{on
'click'
(route-action 'removeMember' @model.group member)
}}
<page.breadcrumbs>
<BreadCrumbs />
</page.breadcrumbs>
<page.header>
<Groups::Group::Header @model={{@model.group}} />
</page.header>
<page.navigation>
<Groups::Group::Nav @model={{@model.group}} />
</page.navigation>
<page.actions>
<Groups::Group::Actions @model={{@model.group}} />
</page.actions>
<page.body>
{{#if @model.members}}
<Rose::Table as |table|>
<table.header as |header|>
<header.row as |row|>
<row.headerCell>{{t 'form.name.label'}}</row.headerCell>
<row.headerCell>{{t 'form.id.label'}}</row.headerCell>
<row.headerCell>{{t 'titles.actions'}}</row.headerCell>
</header.row>
</table.header>
<table.body as |body|>
{{#each @model.members as |member|}}
<body.row as |row|>
<row.headerCell>
{{member.displayName}}
{{#if member.accountName}}
<br /><Rose::Badge>{{member.accountName}}</Rose::Badge>
{{/if}}
</row.headerCell>
<row.cell>
<Copyable
@text={{member.id}}
@buttonText={{t 'actions.copy-to-clipboard'}}
@acknowledgeText={{t 'states.copied'}}
>
{{t 'actions.remove'}}
</dropdown.button>
</Rose::Dropdown>
{{/if}}
</row.cell>
</body.row>
{{/each}}
</table.body>
</Rose::Table>
<code>{{member.id}}</code>
</Copyable>
</row.cell>
<row.cell>
{{#if (can 'removeMembers group' @model.group)}}
<Rose::Dropdown
@icon='flight-icons/svg/more-horizontal-16'
@iconOnly={{true}}
@showCaret={{false}}
@dropdownRight={{true}}
@text='{{t 'actions.manage'}}'
as |dropdown|
>
<dropdown.button
@style='danger'
{{on
'click'
(route-action 'removeMember' @model.group member)
}}
>
{{t 'actions.remove'}}
</dropdown.button>
</Rose::Dropdown>
{{/if}}
</row.cell>
</body.row>
{{/each}}
</table.body>
</Rose::Table>
{{else}}
{{else}}
<Rose::Layout::Centered>
<Rose::Message
@title={{t 'resources.group.messages.members.title'}}
as |message|
>
<message.description>
{{t 'resources.group.messages.members.description'}}
</message.description>
<message.link @route='scopes.scope.groups.group.add-members'>
<Rose::Icon @name='flight-icons/svg/plus-circle-16' />
{{t 'resources.group.actions.add-members'}}
</message.link>
</Rose::Message>
</Rose::Layout::Centered>
<Rose::Layout::Centered>
<Rose::Message
@title={{t 'resources.group.messages.members.title'}}
as |message|
>
<message.description>
{{t 'resources.group.messages.members.description'}}
</message.description>
<message.link @route='scopes.scope.groups.group.add-members'>
<Rose::Icon @name='flight-icons/svg/plus-circle-16' />
{{t 'resources.group.actions.add-members'}}
</message.link>
</Rose::Message>
</Rose::Layout::Centered>
{{/if}}
{{/if}}
</page.body>
</Rose::Layout::Page>