fix: Add type check for account username

This commit is contained in:
Susmitha Girumala committed 2020-09-18 14:15:19 -04:00
1 parent 925b6a2db5
commit 3ae2db9562
2 files changed
+7 -4

No files matched your search

+5 -3
View File
@@ -13,12 +13,14 @@ export default class AccountModel extends GeneratedAccountModel {
@fragment('fragment-account-attributes', { defaultValue: {} }) attributes;
/**
* Convenience for getting login_name attribute.
* Convenience for getting username in account.
* @type {string}
*/
@computed('attributes.login_name')
@computed('attributes')
get username() {
return this.attributes.login_name;
if(this.type === 'password') {
return this.attributes.login_name;
}
}
// =methods
+2 -1
View File
@@ -10,7 +10,7 @@ module('Unit | Model | account', function (hooks) {
assert.ok(model);
});
test('it has an username attribute', function (assert) {
test('it has an username attribute for password account', function (assert) {
assert.expect(2);
const store = this.owner.lookup('service:store');
let model = store.createRecord('account', {
@@ -21,4 +21,5 @@ module('Unit | Model | account', function (hooks) {
model.attributes.login_name = 'username';
assert.equal(model.username, 'username');
});
});