CyberCoveLLC/threshold-ui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: 💡 Manage dropdown HDS refactoring for managed-groups (#2455)

Browse Source 
* refactor: 💡 Manage dropdown HDS refactoring for managed-groups

Updated the manage dropdown to reflect HDS design

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-14603

* refactor: 💡 Changed up naming convention for Manage dropdown

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-14603

---------

Co-authored-by: Cameron Perera <cameron.perera@hashicorp.com>
This commit is contained in:
WadiandCameron Perera authored and GitHub committed 2024-08-26 10:48:36 -05:00
1 parent a3082e97e6
commit 3d60d047e3
2 files changed
+21 -20
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ui/admin/app/components/auth-methods/auth-method/managed-groups/managed-group/actions/index.hbs
+7 -12
View File
@@ -4,17 +4,12 @@
}}
{{#if (can 'delete model' @model)}}
<Rose::Dropdown
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
<dropdown.button
@style='danger'
@disabled={{@model.canSave}}
<Hds::Dropdown data-test-managed-group-dropdown as |dd|>
<dd.ToggleButton @text={{t 'actions.manage'}} @color='secondary' />
<dd.Interactive
@text={{t 'resources.managed-group.actions.delete'}}
@color='critical'
{{on 'click' (fn @delete @model)}}
>
{{t 'resources.managed-group.actions.delete'}}
</dropdown.button>
</Rose::Dropdown>
/>
</Hds::Dropdown>
{{/if}}
ui/admin/tests/acceptance/managed-groups/delete-test.js
+14 -8
View File
@@ -21,8 +21,10 @@ module('Acceptance | managed-groups | delete', function (hooks) {
let getManagedGroupCount;
const DELETE_DROPDOWN_SELECTOR =
'.rose-layout-page-actions .rose-dropdown-button-danger';
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-managed-group-dropdown] div:first-child button';
const DELETE_ACTION_SELECTOR =
'[data-test-managed-group-dropdown] ul li button';
const ERROR_MSG_SELECTOR = '.rose-notification-body';
const instances = {
@@ -89,7 +91,8 @@ module('Acceptance | managed-groups | delete', function (hooks) {
await visit(urls.managedGroups);
await click(`[href="${urls.managedGroup}"]`);
await click(DELETE_DROPDOWN_SELECTOR);
await click(MANAGE_DROPDOWN_SELECTOR);
await click(DELETE_ACTION_SELECTOR);
assert.strictEqual(getManagedGroupCount(), managedGroupsCount - 1);
assert.strictEqual(currentURL(), urls.managedGroups);
@@ -100,7 +103,8 @@ module('Acceptance | managed-groups | delete', function (hooks) {
await visit(urls.ldapManagedGroups);
await click(`[href="${urls.ldapManagedGroup}"]`);
await click(DELETE_DROPDOWN_SELECTOR);
await click(MANAGE_DROPDOWN_SELECTOR);
await click(DELETE_ACTION_SELECTOR);
assert.strictEqual(getManagedGroupCount(), managedGroupsCount - 1);
assert.strictEqual(currentURL(), urls.ldapManagedGroups);
@@ -115,7 +119,7 @@ module('Acceptance | managed-groups | delete', function (hooks) {
await click(`[href="${urls.managedGroup}"]`);
assert.dom(DELETE_DROPDOWN_SELECTOR).doesNotExist();
assert.dom(MANAGE_DROPDOWN_SELECTOR).doesNotExist();
});
test('User cannot delete a ldap managed-group without proper authorization', async function (assert) {
@@ -127,7 +131,7 @@ module('Acceptance | managed-groups | delete', function (hooks) {
await click(`[href="${urls.ldapManagedGroup}"]`);
assert.dom(DELETE_DROPDOWN_SELECTOR).doesNotExist();
assert.dom(MANAGE_DROPDOWN_SELECTOR).doesNotExist();
});
test('Errors are displayed when delete on managed group fails', async function (assert) {
@@ -145,7 +149,8 @@ module('Acceptance | managed-groups | delete', function (hooks) {
await visit(urls.managedGroups);
await click(`[href="${urls.managedGroup}"]`);
await click(DELETE_DROPDOWN_SELECTOR);
await click(MANAGE_DROPDOWN_SELECTOR);
await click(DELETE_ACTION_SELECTOR);
await a11yAudit();
assert.dom(ERROR_MSG_SELECTOR).hasText('Oops.');
@@ -167,7 +172,8 @@ module('Acceptance | managed-groups | delete', function (hooks) {
await visit(urls.ldapManagedGroups);
await click(`[href="${urls.ldapManagedGroup}"]`);
await click(DELETE_DROPDOWN_SELECTOR);
await click(MANAGE_DROPDOWN_SELECTOR);
await click(DELETE_ACTION_SELECTOR);
await a11yAudit();
assert.dom(ERROR_MSG_SELECTOR).hasText('Oops.');