(HACK WEEK 2025) refactor: 💡 remove explicit a11yAudit usage (#2936)

* refactor: 💡 remove explicit usage of a11yAudit

* Delete a11yAudit method from readme

---------

Co-authored-by: calcaide <ccorvo@hashicorp.com>
This commit is contained in:
Cameron Pereraandcalcaide committed 2025-08-19 10:51:44 -05:00
1 parent 3918f82e14
commit 42013a919f
66 files changed
+11 -276

No files matched your search

@@ -8,7 +8,6 @@ import { visit, click, currentURL } from '@ember/test-helpers';
import { setupApplicationTest } from 'admin/tests/helpers';
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import { setupIndexedDb } from 'api/test-support/helpers/indexed-db';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { Response } from 'miragejs';
import { authenticateSession } from 'ember-simple-auth/test-support';
import { TYPE_AUTH_METHOD_LDAP } from 'api/models/auth-method';
@@ -104,7 +103,6 @@ module('Acceptance | auth-methods | delete', function (hooks) {
await click(commonSelectors.HREF(urls.authMethod));
await click(selectors.MANAGE_DROPDOWN);
await click(selectors.MANAGE_DROPDOWN_DELETE);
await a11yAudit();
assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText('Oops.');
});
@@ -127,7 +125,6 @@ module('Acceptance | auth-methods | delete', function (hooks) {
await click(commonSelectors.HREF(urls.ldapAuthMethod));
await click(selectors.MANAGE_DROPDOWN);
await click(selectors.MANAGE_DROPDOWN_DELETE);
await a11yAudit();
assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText('Oops.');
});
@@ -7,7 +7,6 @@ import { module, test } from 'qunit';
import { visit, currentURL, click } from '@ember/test-helpers';
import { setupApplicationTest } from 'admin/tests/helpers';
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { authenticateSession } from 'ember-simple-auth/test-support';
import { TYPE_AUTH_METHOD_OIDC } from 'api/models/auth-method';
import * as commonSelectors from 'admin/tests/helpers/selectors';
@@ -49,7 +48,6 @@ module('Acceptance | auth-methods | oidc', function (hooks) {
test('visiting oidc auth method', async function (assert) {
await visit(urls.authMethod);
await a11yAudit();
assert.strictEqual(currentURL(), urls.authMethod);
});
@@ -8,7 +8,6 @@ import { visit, currentURL, click } from '@ember/test-helpers';
import { setupApplicationTest } from 'admin/tests/helpers';
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import { setupIndexedDb } from 'api/test-support/helpers/indexed-db';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { authenticateSession } from 'ember-simple-auth/test-support';
import {
TYPE_AUTH_METHOD_LDAP,
@@ -71,7 +70,6 @@ module('Acceptance | auth-methods | read', function (hooks) {
await visit(urls.orgScope);
await click(commonSelectors.HREF(urls.orgAuthMethods));
await a11yAudit();
assert.strictEqual(currentURL(), urls.orgAuthMethods);
});
@@ -80,7 +78,6 @@ module('Acceptance | auth-methods | read', function (hooks) {
await visit(urls.globalScope);
await click(commonSelectors.HREF(urls.globalAuthMethods));
await a11yAudit();
assert.strictEqual(currentURL(), urls.globalAuthMethods);
});
@@ -100,7 +97,6 @@ module('Acceptance | auth-methods | read', function (hooks) {
await click(
selectors.TABLE_ROW_NAME_LINK(instances.passwordAuthMethodOrg.id),
);
await a11yAudit();
assert.strictEqual(currentURL(), urls.passwordAuthMethodOrg);
});
@@ -120,7 +116,6 @@ module('Acceptance | auth-methods | read', function (hooks) {
await click(
selectors.TABLE_ROW_NAME_LINK(instances.oidcAuthMethodGlobal.id),
);
await a11yAudit();
assert.strictEqual(currentURL(), urls.oidcAuthMethodGlobal);
});
@@ -8,7 +8,6 @@ import { visit, click, fillIn, select, findAll } from '@ember/test-helpers';
import { setupApplicationTest } from 'admin/tests/helpers';
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
import { setupIndexedDb } from 'api/test-support/helpers/indexed-db';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { Response } from 'miragejs';
import { authenticateSession } from 'ember-simple-auth/test-support';
import {
@@ -445,7 +444,6 @@ module('Acceptance | auth-methods | update', function (hooks) {
await click(commonSelectors.EDIT_BTN);
await fillIn(commonSelectors.FIELD_NAME, commonSelectors.FIELD_NAME_VALUE);
await click(commonSelectors.SAVE_BTN);
await a11yAudit();
assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText(errorMessage);
assert.dom(commonSelectors.FIELD_NAME_ERROR).hasText(errorDescription);
@@ -480,7 +478,6 @@ module('Acceptance | auth-methods | update', function (hooks) {
await click(commonSelectors.EDIT_BTN);
await fillIn(selectors.FIELD_URLS, '');
await click(commonSelectors.SAVE_BTN);
await a11yAudit();
assert.dom(commonSelectors.ALERT_TOAST_BODY).hasText(errorMessage);
assert.dom(commonSelectors.FIELD_ERROR).hasText(errorDescription);