chore: Add windows icon in desktop

ui/desktop/electron-app/config/cli.js

@@ -11,12 +11,12 @@ const artifactDestination = path.resolve(__dirname, '..', 'cli');
 const downloadArtifact = (version) => {
   const archivePlatform = {};
   // TODO: Support all available build machines
-  if (isMac) {
+  if (isMac()) {
     archivePlatform.name = 'darwin';
     archivePlatform.arch = 'amd64';
   }
 
-  if (isWindows) {
+  if (isWindows()) {
     archivePlatform.name = 'windows';
     archivePlatform.arch = 'amd64';
   }

ui/desktop/electron-app/config/forge.js

@@ -32,8 +32,7 @@ const createConfig = () => {
   // Version
   if (config.RELEASE_VERSION)
     config.packagerConfig.version = config.RELEASE_VERSION;
-
-  if (isMac) {
+  if (isMac()) {
     config.packagerConfig.icon = './config/macos/icon.icns';
     config.packagerConfig.osxSign = {
       'hardened-runtime': true,
@@ -64,7 +63,9 @@ const createConfig = () => {
     });
   }
 
-  if (isWindows) {
+  if (isWindows()) {
+    config.packagerConfig.icon = './config/windows/icon.ico';
+
     // Generate EXE file
     config.makers.push({
       name: '@electron-forge/maker-squirrel',

ui/desktop/electron-app/src/helpers/platform.js

@@ -1,6 +1,6 @@
 const os = require('os');
 
 module.exports = {
-  isMac: () => Boolean(os.type().match(/darwin/i)),
+  isMac: () => Boolean(os.type().match(/(darwin)/i)),
   isWindows: () => Boolean(os.type().match(/(windows)/i)),
 };