CyberCoveLLC/threshold-ui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: 💡 Updated Manage Dropdown for hosts form (#2423)

Browse Source 
* refactor: 💡 Updated Manage Dropdown for hosts form

Continuing refactoring upgrades for HDS managed dropdowns

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-14602

* refactor: 💡 Removed disabled attribute from dropdown

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-14602
This commit is contained in:
Wadi authored and GitHub committed 2024-08-05 12:53:55 -04:00
1 parent a68d7d103a
commit 89cfb14d6e
2 files changed
+19 -16
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ui/admin/app/components/host-catalogs/host-catalog/hosts/host/actions/index.hbs
+7 -12
View File
@@ -4,17 +4,12 @@
}}
{{#if (can 'delete model' @model)}}
<Rose::Dropdown
@text={{t 'actions.manage'}}
@dropdownRight={{true}}
as |dropdown|
>
<dropdown.button
@style='danger'
@disabled={{@model.canSave}}
<Hds::Dropdown data-test-manage-hosts-dropdown as |dd|>
<dd.ToggleButton @text={{t 'actions.manage'}} @color='secondary' />
<dd.Interactive
@text={{t 'resources.host.actions.delete'}}
@color='critical'
{{on 'click' (fn @delete @model)}}
>
{{t 'resources.host.actions.delete'}}
</dropdown.button>
</Rose::Dropdown>
/>
</Hds::Dropdown>
{{/if}}
ui/admin/tests/acceptance/host-catalogs/hosts/delete-test.js
+12 -4
View File
@@ -22,6 +22,10 @@ module('Acceptance | host-catalogs | hosts | delete', function (hooks) {
setupMirage(hooks);
let getHostCount;
const MANAGE_DROPDOWN_SELECTOR =
'[data-test-manage-hosts-dropdown] div:first-child button';
const DELETE_ACTION_SELECTOR =
'[data-test-manage-hosts-dropdown] ul li button';
const instances = {
scopes: {
@@ -80,7 +84,8 @@ module('Acceptance | host-catalogs | hosts | delete', function (hooks) {
test('can delete host', async function (assert) {
const count = getHostCount();
await visit(urls.host);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
await click(MANAGE_DROPDOWN_SELECTOR);
await click(DELETE_ACTION_SELECTOR);
assert.strictEqual(getHostCount(), count - 1);
});
@@ -99,7 +104,8 @@ module('Acceptance | host-catalogs | hosts | delete', function (hooks) {
confirmService.confirm = sinon.fake.returns(resolve());
const count = getHostCount();
await visit(urls.host);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
await click(MANAGE_DROPDOWN_SELECTOR);
await click(DELETE_ACTION_SELECTOR);
assert.strictEqual(getHostCount(), count - 1);
assert.ok(confirmService.confirm.calledOnce);
});
@@ -110,7 +116,8 @@ module('Acceptance | host-catalogs | hosts | delete', function (hooks) {
confirmService.confirm = sinon.fake.returns(reject());
const count = getHostCount();
await visit(urls.host);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
await click(MANAGE_DROPDOWN_SELECTOR);
await click(DELETE_ACTION_SELECTOR);
assert.strictEqual(getHostCount(), count);
assert.ok(confirmService.confirm.calledOnce);
});
@@ -128,7 +135,8 @@ module('Acceptance | host-catalogs | hosts | delete', function (hooks) {
);
});
await visit(urls.host);
await click('.rose-layout-page-actions .rose-dropdown-button-danger');
await click(MANAGE_DROPDOWN_SELECTOR);
await click(DELETE_ACTION_SELECTOR);
assert.ok(find('[role="alert"]').textContent.trim(), 'Oops.');
});
});