refactor: 💡 Update name radio option label & set toggle default to on (#2652)

* refactor: 💡 Update name radio option label & default toggle on

addons/core/translations/en-us.yaml

@@ -156,5 +156,5 @@ worker-filter-generator:
     label: Name
     helper: Format a worker name
   operator:
-    matches: matches
+    matches: matches (regex)
     contains: contains

ui/admin/app/components/worker-filter-generator/index.hbs

@@ -32,6 +32,7 @@
 <Hds::Separator />
 
 <Hds::Form::Toggle::Field
+  checked={{this.showFilterGenerator}}
   name='show_filter_generator'
   {{on 'change' this.toggleFilterGenerator}}
   as |F|

ui/admin/app/components/worker-filter-generator/index.js

@@ -13,7 +13,7 @@ export default class WorkerFilterGeneratorIndexComponent extends Component {
   generatorTagType = 'tag';
   generatorNameType = 'name';
   operatorOptions = ['==', 'matches', 'contains'];
-  @tracked showFilterGenerator;
+  @tracked showFilterGenerator = true;
   @tracked selectedGeneratorType = this.generatorTagType;
   @tracked key = '';
   @tracked value = '';

ui/admin/tests/integration/components/worker-filter-generator/index-test.js

@@ -53,6 +53,10 @@ module(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
 
+      assert.dom(FILTER_GENERATOR).isVisible();
+
+      await click(SHOW_FILTER_GENERATOR);
+
       assert.dom(FILTER_GENERATOR).isNotVisible();
 
       await click(SHOW_FILTER_GENERATOR);
@@ -65,7 +69,9 @@ module(
       await render(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
-      await click(SHOW_FILTER_GENERATOR);
+
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(TAG_TYPE_OPTION);
 
       assert.dom(TAG_KEY).isVisible();
@@ -78,7 +84,9 @@ module(
       await render(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
-      await click(SHOW_FILTER_GENERATOR);
+
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(TAG_TYPE_OPTION);
       await fillIn(TAG_KEY, 'key1');
       await fillIn(TAG_VALUE, 'val1');
@@ -92,7 +100,8 @@ module(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
 
-      await click(SHOW_FILTER_GENERATOR);
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(NAME_TYPE_OPTION);
 
       assert.dom(NAME_OPERATOR).isVisible();
@@ -106,7 +115,8 @@ module(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
 
-      await click(SHOW_FILTER_GENERATOR);
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(NAME_TYPE_OPTION);
       await fillIn(TAG_VALUE, 'val1');
       await select(NAME_OPERATOR, '==');
@@ -120,7 +130,8 @@ module(
         hbs`<WorkerFilterGenerator @name='ingress_worker_filter' @model={{this.model}} />`,
       );
 
-      await click(SHOW_FILTER_GENERATOR);
+      assert.dom(FILTER_GENERATOR).isVisible();
+
       await click(NAME_TYPE_OPTION);
       await fillIn(TAG_VALUE, 'val1');
       await select(NAME_OPERATOR, '==');